address review comments

Author: davidkyle

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elasticsearch/ElasticsearchInternalModel.java

@@ -91,7 +91,7 @@ public ElasticsearchInternalServiceSettings getServiceSettings() {
         return (ElasticsearchInternalServiceSettings) super.getServiceSettings();
     }
 
-    public void updateNumAllocation(Integer numAllocations) {
+    public void updateNumAllocations(Integer numAllocations) {
         this.internalServiceSettings.setNumAllocations(numAllocations);
     }
 

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elasticsearch/ElasticsearchInternalService.java

@@ -790,8 +790,16 @@ public List<DefaultConfigId> defaultConfigIds() {
 
     @Override
     public void updateModelsWithDynamicFields(List<Model> models, ActionListener<List<Model>> listener) {
+
+        if (models.isEmpty()) {
+            listener.onResponse(models);
+            return;
+        }
+
         var modelsByDeploymentIds = new HashMap<String, ElasticsearchInternalModel>();
         for (var model : models) {
+            assert model instanceof ElasticsearchInternalModel;
+
             if (model instanceof ElasticsearchInternalModel esModel) {
                 modelsByDeploymentIds.put(esModel.mlNodeDeploymentId(), esModel);
             } else {
@@ -806,19 +814,14 @@ public void updateModelsWithDynamicFields(List<Model> models, ActionListener<Lis
             }
         }
 
-        if (modelsByDeploymentIds.isEmpty()) {
-            listener.onResponse(models);
-            return;
-        }
-
         String deploymentIds = String.join(",", modelsByDeploymentIds.keySet());
         client.execute(
             GetDeploymentStatsAction.INSTANCE,
             new GetDeploymentStatsAction.Request(deploymentIds),
             ActionListener.wrap(stats -> {
                 for (var deploymentStats : stats.getStats().results()) {
                     var model = modelsByDeploymentIds.get(deploymentStats.getDeploymentId());
-                    model.updateNumAllocation(deploymentStats.getNumberOfAllocations());
+                    model.updateNumAllocations(deploymentStats.getNumberOfAllocations());
                 }
                 listener.onResponse(new ArrayList<>(modelsByDeploymentIds.values()));
             }, e -> {

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/elasticsearch/ElserInternalModelTests.java

@@ -21,10 +21,10 @@ public void testUpdateNumAllocation() {
             null
         );
 
-        model.updateNumAllocation(1);
+        model.updateNumAllocations(1);
         assertEquals(1, model.getServiceSettings().getNumAllocations().intValue());
 
-        model.updateNumAllocation(null);
+        model.updateNumAllocations(null);
         assertNull(model.getServiceSettings().getNumAllocations());
     }
 }