fix(cmake): Add -Wno-stringop-overflow on certain GCC versions to avoid false positives; Enable Ubuntu 24.04 in CI. (y-scope#140)

Co-authored-by: kirkrodrigues <[email protected]>

Author: davidlion

.github/workflows/build.yaml

@@ -33,6 +33,7 @@ jobs:
         os:
           - "macos-15"
           - "ubuntu-22.04"
+          - "ubuntu-24.04"
         build_type:
           - "debug"
           - "release"

.github/workflows/lint.yml

@@ -17,7 +17,9 @@ jobs:
   lint:
     strategy:
       matrix:
-        os: ["macos-latest", "ubuntu-latest"]
+        os:
+          - "macos-15"
+          - "ubuntu-24.04"
     runs-on: "${{matrix.os}}"
     steps:
       - uses: "actions/checkout@v4"
@@ -31,7 +33,7 @@ jobs:
       - name: "Install task"
         run: "npm install -g @go-task/cli"
 
-      - if: "matrix.os == 'macos-latest'"
+      - if: "matrix.os == 'macos-15'"
         name: "Install coreutils (for md5sum)"
         run: "brew install coreutils"
 

CMakeLists.txt

@@ -143,6 +143,18 @@ target_compile_options(log_surgeon PRIVATE
     $<$<NOT:$<CXX_COMPILER_ID:MSVC>>:-Wall -Wextra -Wpedantic -Werror>
     )
 
+# Disable -Wstringop-overflow to avoid a false positive in the following compiler versions.
+# See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117983
+if("GNU" STREQUAL "${CMAKE_CXX_COMPILER_ID}"
+    AND ((CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 12
+         AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 12.5)
+         OR (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 13
+             AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 13.4)
+         OR (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 14
+             AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 14.3)))
+    target_compile_options(log_surgeon PRIVATE "-Wno-stringop-overflow")
+endif()
+
 # Make off_t 64-bit
 target_compile_definitions(log_surgeon
     PRIVATE