Remove no-op compaction logic

Author: simolus3

packages/powersync_core/lib/src/sync/bucket_storage.dart

@@ -20,8 +20,6 @@ typedef LocalOperationCounters = ({int atLast, int sinceLast});
 class BucketStorage {
   final SqliteConnection _internalDb;
   bool _hasCompletedSync = false;
-  bool _pendingBucketDeletes = false;
-  int _compactCounter = compactOperationInterval;
 
   BucketStorage(SqliteConnection db) : _internalDb = db {
     _init();
@@ -67,11 +65,8 @@ class BucketStorage {
   }
 
   Future<void> saveSyncData(SyncDataBatch batch) async {
-    var count = 0;
-
     await writeTransaction((tx) async {
       for (var b in batch.buckets) {
-        count += b.data.length;
         await _updateBucket2(
             tx,
             jsonEncode({
@@ -82,7 +77,6 @@ class BucketStorage {
       // We get major initial sync performance improvements with IndexedDB by
       // not flushing here.
     }, flush: false);
-    _compactCounter += count;
   }
 
   Future<void> _updateBucket2(SqliteWriteContext tx, String json) async {
@@ -103,8 +97,6 @@ class BucketStorage {
           ['delete_bucket', bucket]);
       // No need to flush - not directly visible to the user
     }, flush: false);
-
-    _pendingBucketDeletes = true;
   }
 
   Future<bool> hasCompletedSync() async {
@@ -154,8 +146,6 @@ class BucketStorage {
       return SyncLocalDatabaseResult(ready: false);
     }
 
-    await forceCompact();
-
     return SyncLocalDatabaseResult(ready: true);
   }
 
@@ -226,52 +216,6 @@ UPDATE ps_buckets SET count_since_last = 0, count_at_last = ?1->name
     }
   }
 
-  Future<void> forceCompact() async {
-    _compactCounter = compactOperationInterval;
-    _pendingBucketDeletes = true;
-
-    await autoCompact();
-  }
-
-  Future<void> autoCompact() async {
-    // This is a no-op since powersync-sqlite-core v0.3.0
-
-    // 1. Delete buckets
-    await _deletePendingBuckets();
-
-    // 2. Clear REMOVE operations, only keeping PUT ones
-    await _clearRemoveOps();
-  }
-
-  Future<void> _deletePendingBuckets() async {
-    // This is a no-op since powersync-sqlite-core v0.3.0
-    if (_pendingBucketDeletes) {
-      // Executed once after start-up, and again when there are pending deletes.
-      await writeTransaction((tx) async {
-        await tx.execute(
-            'INSERT INTO powersync_operations(op, data) VALUES (?, ?)',
-            ['delete_pending_buckets', '']);
-        // No need to flush - not directly visible to the user
-      }, flush: false);
-      _pendingBucketDeletes = false;
-    }
-  }
-
-  Future<void> _clearRemoveOps() async {
-    if (_compactCounter < compactOperationInterval) {
-      return;
-    }
-
-    // This is a no-op since powersync-sqlite-core v0.3.0
-    await writeTransaction((tx) async {
-      await tx.execute(
-          'INSERT INTO powersync_operations(op, data) VALUES (?, ?)',
-          ['clear_remove_ops', '']);
-      // No need to flush - not directly visible to the user
-    }, flush: false);
-    _compactCounter = 0;
-  }
-
   void setTargetCheckpoint(Checkpoint checkpoint) {
     // No-op for now
   }

packages/powersync_core/test/bucket_storage_test.dart

@@ -556,8 +556,6 @@ void main() {
           writeCheckpoint: '4',
           checksums: [checksum(bucket: 'bucket1', checksum: 7)]));
 
-      await bucketStorage.forceCompact();
-
       await syncLocalChecked(Checkpoint(
           lastOpId: '4',
           writeCheckpoint: '4',
@@ -604,8 +602,6 @@ void main() {
           writeCheckpoint: '4',
           checksums: [checksum(bucket: 'bucket1', checksum: 2147483642)]));
 
-      await bucketStorage.forceCompact();
-
       await syncLocalChecked(Checkpoint(
           lastOpId: '4',
           writeCheckpoint: '4',
@@ -645,8 +641,6 @@ void main() {
           writeCheckpoint: '4',
           checksums: [checksum(bucket: 'bucket1', checksum: -3)]));
 
-      await bucketStorage.forceCompact();
-
       await syncLocalChecked(Checkpoint(
           lastOpId: '4',
           writeCheckpoint: '4',