review comments

Author: js2702

packages/powersync_core/lib/src/database/powersync_db_mixin.dart

@@ -134,12 +134,12 @@ mixin PowerSyncDatabaseMixin implements SqliteConnection {
     await _afterSchemaReady();
   }
 
-  void _assertSchemaIsReady() {
+  void _checkSchemaIsReady() {
     if (!manualSchemaManagement || _manualSchemaManagementCompleted) {
       return;
     }
 
-    throw AssertionError(
+    throw StateError(
         'In manual schema management mode, you need to mark the powersync database as ready');
   }
 
@@ -319,7 +319,7 @@ mixin PowerSyncDatabaseMixin implements SqliteConnection {
     // the lock for the connection.
     await initialize();
 
-    _assertSchemaIsReady();
+    _checkSchemaIsReady();
 
     final resolvedOptions = ResolvedSyncOptions.resolve(
       options,
@@ -484,15 +484,15 @@ mixin PowerSyncDatabaseMixin implements SqliteConnection {
   /// Get an unique id for this client.
   /// This id is only reset when the database is deleted.
   Future<String> getClientId() async {
-    _assertSchemaIsReady(); // TODO(skilldevs): Needed?
+    _checkSchemaIsReady(); // TODO(skilldevs): Needed?
     final row = await get('SELECT powersync_client_id() as client_id');
     return row['client_id'] as String;
   }
 
   /// Get upload queue size estimate and count.
   Future<UploadQueueStats> getUploadQueueStats(
       {bool includeSize = false}) async {
-    _assertSchemaIsReady();
+    _checkSchemaIsReady();
     if (includeSize) {
       final row = await getOptional(
           'SELECT SUM(cast(data as blob) + 20) as size, count(*) as count FROM ps_crud');
@@ -520,7 +520,7 @@ mixin PowerSyncDatabaseMixin implements SqliteConnection {
   /// data by transaction. One batch may contain data from multiple transactions,
   /// and a single transaction may be split over multiple batches.
   Future<CrudBatch?> getCrudBatch({int limit = 100}) async {
-    _assertSchemaIsReady();
+    _checkSchemaIsReady();
     final rows = await getAll(
         'SELECT id, tx_id, data FROM ps_crud ORDER BY id ASC LIMIT ?',
         [limit + 1]);
@@ -567,7 +567,7 @@ mixin PowerSyncDatabaseMixin implements SqliteConnection {
   /// Unlike [getCrudBatch], this only returns data from a single transaction at a time.
   /// All data for the transaction is loaded into memory.
   Future<CrudTransaction?> getNextCrudTransaction() async {
-    _assertSchemaIsReady();
+    _checkSchemaIsReady();
     return await readTransaction((tx) async {
       final first = await tx.getOptional(
           'SELECT id, tx_id, data FROM ps_crud ORDER BY id ASC LIMIT 1');

packages/powersync_core/lib/src/schema.dart

@@ -316,9 +316,8 @@ class Column {
   Map<String, dynamic> toJson() => {'name': name, 'type': type.sqlite};
 }
 
-class RawTable {
-  final String
-      name; // TODO: it does not need to be the same name as the raw table
+final class RawTable {
+  final String name;
   final PendingStatement put;
   final PendingStatement delete;
 
@@ -335,7 +334,7 @@ class RawTable {
       };
 }
 
-class PendingStatement {
+final class PendingStatement {
   final String sql;
   final List<PendingStatementValue> params;
 
@@ -348,12 +347,15 @@ class PendingStatement {
 }
 
 sealed class PendingStatementValue {
+  factory PendingStatementValue.id() = _PendingStmtValueId;
+  factory PendingStatementValue.column(String column) = _PendingStmtValueColumn;
+
   dynamic toJson();
 }
 
-class PendingStmtValueColumn extends PendingStatementValue {
+class _PendingStmtValueColumn implements PendingStatementValue {
   final String column;
-  PendingStmtValueColumn(this.column);
+  const _PendingStmtValueColumn(this.column);
 
   @override
   dynamic toJson() {
@@ -363,7 +365,9 @@ class PendingStmtValueColumn extends PendingStatementValue {
   }
 }
 
-class PendingStmtValueId extends PendingStatementValue {
+class _PendingStmtValueId implements PendingStatementValue {
+  const _PendingStmtValueId();
+
   @override
   dynamic toJson() {
     return 'Id';