Properly resolve on build as well as dev

Author: davidmyersdev

.pnp.cjs

@@ -35,6 +35,7 @@
   "devDependencies": {
     "@types/node": "^18.7.23",
     "esbuild": "^0.15.10",
+    "rollup": "2.78.1",
     "typescript": "4.8.3",
     "vite": "^3.1.4",
     "vite-plugin-externalize-deps": "^0.1.5",
@@ -45,6 +46,9 @@
     "@rollup/plugin-inject": "^4.0.4",
     "node-stdlib-browser": "^1.2.0"
   },
+  "peerDependencies": {
+    "vite": "^2.0.0 || ^3.0.0"
+  },
   "publishConfig": {
     "access": "public"
   },

package.json

@@ -4,3 +4,9 @@ declare module 'node-stdlib-browser/helpers/esbuild/plugin' {
 
   export default function(options: typeof stdLibBrowser): Plugin
 }
+
+declare module 'node-stdlib-browser/helpers/rollup/plugin' {
+  import type { WarningHandlerWithDefault } from 'rollup'
+
+  export const handleCircularDependancyWarning: WarningHandlerWithDefault
+}

src/env.d.ts

@@ -1,6 +1,7 @@
 import { createRequire } from 'node:module'
 import inject from '@rollup/plugin-inject'
 import stdLibBrowser from 'node-stdlib-browser'
+import { handleCircularDependancyWarning } from 'node-stdlib-browser/helpers/rollup/plugin'
 import esbuildPlugin from 'node-stdlib-browser/helpers/esbuild/plugin'
 import type { Plugin } from 'vite'
 
@@ -12,6 +13,22 @@ export const nodePolyfills = (_options = {}): Plugin => {
     name: 'vite-plugin-node-polyfills',
     config: (_config, _env) => {
       return {
+        build: {
+          rollupOptions: {
+            onwarn: (warning, rollupWarn) => {
+              handleCircularDependancyWarning(warning, rollupWarn)
+            },
+            plugins: [
+              {
+                ...inject({
+                  Buffer: 'Buffer',
+                  global: 'global',
+                  process: 'process',
+                }),
+              },
+            ],
+          },
+        },
         optimizeDeps: {
           esbuildOptions: {
             // https://github.com/niksy/node-stdlib-browser/blob/3e7cd7f3d115ac5c4593b550e7d8c4a82a0d4ac4/README.md?plain=1#L203-L209
@@ -28,20 +45,11 @@ export const nodePolyfills = (_options = {}): Plugin => {
             ],
           },
         },
-        plugins: [
-          // https://github.com/niksy/node-stdlib-browser/blob/3e7cd7f3d115ac5c4593b550e7d8c4a82a0d4ac4/README.md?plain=1#L155-L179
-          {
-            ...inject({
-              Buffer: [globalShims, 'Buffer'],
-              global: [globalShims, 'global'],
-              process: [globalShims, 'process'],
-            }),
-            enforce: 'post',
-          }
-        ],
         resolve: {
           // https://github.com/niksy/node-stdlib-browser/blob/3e7cd7f3d115ac5c4593b550e7d8c4a82a0d4ac4/README.md?plain=1#L150
-          alias: stdLibBrowser,
+          alias: {
+            ...stdLibBrowser,
+          },
         },
       }
     },

src/index.ts

@@ -1,3 +1,3 @@
-import { resolve } from 'node:path'
+import { resolve } from 'path'
 
 console.log(resolve('.'))

test/src/main.ts

@@ -21,7 +21,7 @@ export default defineConfig({
           exports: 'named',
           format: 'cjs',
           inlineDynamicImports: true,
-          interop: 'esModule',
+          interop: 'auto',
         },
       ],
     },

vite.config.ts

@@ -2109,7 +2109,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"rollup@npm:~2.78.0":
+"rollup@npm:2.78.1, rollup@npm:~2.78.0":
   version: 2.78.1
   resolution: "rollup@npm:2.78.1"
   dependencies:
@@ -2502,6 +2502,7 @@ __metadata:
     "@types/node": ^18.7.23
     esbuild: ^0.15.10
     node-stdlib-browser: ^1.2.0
+    rollup: 2.78.1
     typescript: 4.8.3
     vite: ^3.1.4
     vite-plugin-externalize-deps: ^0.1.5