Add a specific test for disabling process

davidmyersdev · davidmyersdev · commit b61a5bbc6a3d · 2024-05-19T18:07:27.000-04:00
diff --git a/examples/vanilla/src/main.ts b/examples/vanilla/src/main.ts
@@ -1,7 +1,7 @@
 /* eslint-disable no-console */
 import { Buffer } from 'node:buffer'
 import { resolve } from 'node:path'
-import * as process from 'node:process'
+import process from 'node:process'
 import fs, { readFileSync } from 'node:fs'
 import { cloneDeep } from 'lodash-es'
 import { fetch } from 'ohmyfetch'
diff --git a/examples/vanilla/test/e2e/main.spec.ts b/examples/vanilla/test/e2e/main.spec.ts
@@ -29,7 +29,7 @@ test('logs the correct values', async ({ page }) => {
       '{Volume: , vol: Volume, createFsFromVolume: , fs: Object, memfs: }',
       'function fetch() { [native code] }',
       '/',
-      'Module',
+      '{nextTick: , title: browser, browser: true, env: Object, argv: Array(0)}',
       '{}',
       'function Array() { [native code] }',
       '4294967295',
diff --git a/examples/vanilla/vite.config.ts b/examples/vanilla/vite.config.ts
@@ -9,9 +9,6 @@ export default defineConfig({
   },
   plugins: [
     nodePolyfills({
-      globals: {
-        process: 'build',
-      },
       overrides: {
         fs: 'memfs',
       },
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/test/error-repros/process-disabled/index.html b/test/error-repros/process-disabled/index.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html lang="en">
+  <head>
+    <meta charset="UTF-8" />
+    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+    <title>Example (Vanilla)</title>
+  </head>
+  <body>
+    <script type="module" src="/src/main.ts"></script>
+  </body>
+</html>
diff --git a/test/error-repros/process-disabled/package.json b/test/error-repros/process-disabled/package.json
@@ -0,0 +1,23 @@
+{
+  "type": "module",
+  "private": true,
+  "scripts": {
+    "build": "vite build",
+    "dev": "vite",
+    "test:e2e": "CI=true run-p test:e2e:*",
+    "test:e2e:build": "VITE_COMMAND=build WEB_SERVER_COMMAND='vite build && vite preview --port 15178' WEB_SERVER_URL='http://localhost:15178' playwright test",
+    "test:e2e:dev": "VITE_COMMAND=dev WEB_SERVER_COMMAND='vite dev --port 15177' WEB_SERVER_URL='http://localhost:15177' playwright test",
+    "typecheck": "tsc"
+  },
+  "devDependencies": {
+    "@types/lodash-es": "^4.17.12",
+    "@types/node": "^18.18.8",
+    "lodash-es": "^4.17.21",
+    "memfs": "^4.6.0",
+    "npm-run-all": "^4.1.5",
+    "ohmyfetch": "^0.4.21",
+    "typescript": "^5.2.2",
+    "vite": "^4.5.0",
+    "vite-plugin-node-polyfills": "workspace:*"
+  }
+}
diff --git a/test/error-repros/process-disabled/playwright.config.ts b/test/error-repros/process-disabled/playwright.config.ts
@@ -0,0 +1,29 @@
+import { defineConfig, devices } from '@playwright/test'
+
+const webServerCommand = process.env.WEB_SERVER_COMMAND || 'pnpm dev'
+const webServerUrl = process.env.WEB_SERVER_URL || 'http://localhost:5173'
+
+// https://playwright.dev/docs/test-configuration
+export default defineConfig({
+  forbidOnly: !!process.env.CI,
+  fullyParallel: true,
+  projects: [
+    {
+      name: 'chromium',
+      use: { ...devices['Desktop Chrome'] },
+    },
+  ],
+  reporter: 'html',
+  retries: process.env.CI ? 2 : 0,
+  testDir: './test/e2e',
+  use: {
+    baseURL: webServerUrl,
+    trace: 'on-first-retry',
+  },
+  webServer: {
+    command: webServerCommand,
+    stdout: 'ignore',
+    url: webServerUrl,
+  },
+  workers: process.env.CI ? 1 : undefined,
+})
diff --git a/test/error-repros/process-disabled/src/env.d.ts b/test/error-repros/process-disabled/src/env.d.ts
@@ -0,0 +1 @@
+/// <reference types="vite/client" />
diff --git a/test/error-repros/process-disabled/src/main.ts b/test/error-repros/process-disabled/src/main.ts
@@ -0,0 +1,3 @@
+/* eslint-disable no-console */
+console.log(process)
+console.log(process.env)
diff --git a/test/error-repros/process-disabled/test/e2e/main.spec.ts b/test/error-repros/process-disabled/test/e2e/main.spec.ts
@@ -0,0 +1,32 @@
+import { expect, test } from '@playwright/test'
+
+test('sets the page title', async ({ page }) => {
+  await page.goto('/')
+
+  await expect(page).toHaveTitle('Example (Vanilla)')
+})
+
+test('logs the correct values', async ({ page }) => {
+  const errors = []
+  const logs = []
+
+  page.on('console', (message) => {
+    if (/^\[vite\]/.test(message.text())) {
+      return
+    }
+
+    logs.push(message.text())
+  })
+
+  page.on('pageerror', (error) => {
+    errors.push(error.message)
+  })
+
+  await page.goto('/')
+
+  expect(errors).toEqual([
+    'process is not defined',
+  ])
+
+  expect(logs).toEqual([])
+})
diff --git a/test/error-repros/process-disabled/test/utils/index.ts b/test/error-repros/process-disabled/test/utils/index.ts
@@ -0,0 +1,2 @@
+export const isBuild = process.env.VITE_COMMAND === 'build'
+export const isDev = process.env.VITE_COMMAND === 'dev'
diff --git a/test/error-repros/process-disabled/tsconfig.json b/test/error-repros/process-disabled/tsconfig.json
@@ -0,0 +1,12 @@
+{
+  "compilerOptions": {
+    "baseUrl": ".",
+    "module": "ESNext",
+    "moduleResolution": "Bundler",
+    "noEmit": true,
+    "paths": {
+      "/*": ["./*"]
+    },
+    "skipLibCheck": true
+  }
+}
diff --git a/test/error-repros/process-disabled/vite.config.ts b/test/error-repros/process-disabled/vite.config.ts
@@ -0,0 +1,19 @@
+import { resolve } from 'node:path'
+import { defineConfig } from 'vite'
+import { nodePolyfills } from 'vite-plugin-node-polyfills'
+
+// https://vitejs.dev/config/
+export default defineConfig({
+  build: {
+    minify: false,
+  },
+  plugins: [
+    nodePolyfills({
+      globals: {
+        process: false,
+      },
+      protocolImports: true,
+    }),
+  ],
+  root: resolve(__dirname),
+})

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+/* eslint-disable no-console */`
	`2`	`+console.log(process)`
	`3`	`+console.log(process.env)`