Don't search again for unfound games when updating missing. They will only be checked again when a full sync is done.

fix(sync): marked unfound games to exclude from discovery queries

Author: sam1am

web/routes/discover.py

@@ -35,7 +35,7 @@ def discover(request: Request, conn: sqlite3.Connection = Depends(get_db)):
                   igdb_summary, description, igdb_screenshots, total_rating,
                   igdb_rating, aggregated_rating, genres, playtime_hours
            FROM games
-           WHERE igdb_id IS NOT NULL""" + EXCLUDE_HIDDEN_FILTER + """
+           WHERE igdb_id IS NOT NULL AND igdb_id > 0""" + EXCLUDE_HIDDEN_FILTER + """
            ORDER BY total_rating DESC NULLS LAST"""
     )
     library_games = cursor.fetchall()
@@ -119,7 +119,7 @@ def fetch_by_popularity_type(pop_type, limit=10):
                   igdb_summary, description, igdb_screenshots, total_rating,
                   igdb_rating, aggregated_rating, genres, playtime_hours
            FROM games
-           WHERE igdb_id IS NOT NULL AND total_rating >= 90""" + EXCLUDE_HIDDEN_FILTER + """
+           WHERE igdb_id IS NOT NULL AND igdb_id > 0 AND total_rating >= 90""" + EXCLUDE_HIDDEN_FILTER + """
            ORDER BY total_rating DESC
            LIMIT 10"""
     )
@@ -131,7 +131,7 @@ def fetch_by_popularity_type(pop_type, limit=10):
                   igdb_summary, description, igdb_screenshots, total_rating,
                   igdb_rating, aggregated_rating, genres, playtime_hours
            FROM games
-           WHERE igdb_id IS NOT NULL
+           WHERE igdb_id IS NOT NULL AND igdb_id > 0
              AND total_rating >= 75
              AND total_rating < 90
              AND aggregated_rating IS NULL""" + EXCLUDE_HIDDEN_FILTER + """
@@ -146,7 +146,7 @@ def fetch_by_popularity_type(pop_type, limit=10):
                   igdb_summary, description, igdb_screenshots, total_rating,
                   igdb_rating, aggregated_rating, genres, playtime_hours
            FROM games
-           WHERE igdb_id IS NOT NULL AND playtime_hours > 0""" + EXCLUDE_HIDDEN_FILTER + """
+           WHERE igdb_id IS NOT NULL AND igdb_id > 0 AND playtime_hours > 0""" + EXCLUDE_HIDDEN_FILTER + """
            ORDER BY playtime_hours DESC
            LIMIT 10"""
     )
@@ -158,7 +158,7 @@ def fetch_by_popularity_type(pop_type, limit=10):
                   igdb_summary, description, igdb_screenshots, total_rating,
                   igdb_rating, aggregated_rating, genres, playtime_hours
            FROM games
-           WHERE igdb_id IS NOT NULL AND aggregated_rating >= 80""" + EXCLUDE_HIDDEN_FILTER + """
+           WHERE igdb_id IS NOT NULL AND igdb_id > 0 AND aggregated_rating >= 80""" + EXCLUDE_HIDDEN_FILTER + """
            ORDER BY aggregated_rating DESC
            LIMIT 10"""
     )
@@ -170,7 +170,7 @@ def fetch_by_popularity_type(pop_type, limit=10):
                   igdb_summary, description, igdb_screenshots, total_rating,
                   igdb_rating, aggregated_rating, genres, playtime_hours
            FROM games
-           WHERE igdb_id IS NOT NULL""" + EXCLUDE_HIDDEN_FILTER + """
+           WHERE igdb_id IS NOT NULL AND igdb_id > 0""" + EXCLUDE_HIDDEN_FILTER + """
            ORDER BY RANDOM()
            LIMIT 10"""
     )

web/services/igdb_sync.py

@@ -374,6 +374,12 @@ def sync_games(conn, client, limit=None, force=False):
 
             if not results:
                 print("No results")
+                # Mark as searched but not found (igdb_id = 0)
+                cursor.execute(
+                    "UPDATE games SET igdb_id = 0, igdb_matched_at = CURRENT_TIMESTAMP WHERE id = ?",
+                    (game_id,)
+                )
+                conn.commit()
                 failed += 1
                 continue
 
@@ -460,6 +466,12 @@ def sync_games(conn, client, limit=None, force=False):
                 matched += 1
             else:
                 print(f"No good match (best score: {best_score:.0f})")
+                # Mark as searched but not found (igdb_id = 0)
+                cursor.execute(
+                    "UPDATE games SET igdb_id = 0, igdb_matched_at = CURRENT_TIMESTAMP WHERE id = ?",
+                    (game_id,)
+                )
+                conn.commit()
                 failed += 1
 
             # Rate limiting - IGDB allows 4 requests/second
@@ -479,7 +491,8 @@ def get_stats(conn):
     cursor.execute("SELECT COUNT(*) FROM games")
     total = cursor.fetchone()[0]
 
-    cursor.execute("SELECT COUNT(*) FROM games WHERE igdb_id IS NOT NULL")
+    # Count matched games (igdb_id > 0, not counting 0 which means "not found")
+    cursor.execute("SELECT COUNT(*) FROM games WHERE igdb_id IS NOT NULL AND igdb_id > 0")
     matched = cursor.fetchone()[0]
 
     cursor.execute(

web/services/metacritic_sync.py

@@ -377,6 +377,16 @@ def update_database(game_id, name, result):
             ),
         )
 
+    def mark_not_found(name):
+        """Mark all games with this name as searched but not found (metacritic_score = -1)."""
+        cursor.execute(
+            """UPDATE games SET
+                metacritic_score = -1,
+                metacritic_matched_at = CURRENT_TIMESTAMP
+            WHERE LOWER(name) = LOWER(?)""",
+            (name,),
+        )
+
     # Process games in parallel
     with ThreadPoolExecutor(max_workers=max_workers) as executor:
         # Submit all tasks
@@ -409,12 +419,18 @@ def update_database(game_id, name, result):
 
                     print(f"[{completed}/{total}] {name} → Matched: {result['match_name']} (match: {result['match_score']:.0f}){score_str}")
                 else:
+                    # Mark as searched but not found
                     with results_lock:
+                        mark_not_found(name)
+                        conn.commit()
                         failed += 1
                     print(f"[{completed}/{total}] {name} → {result}")
 
             except Exception as e:
+                # Mark as searched but not found on exception
                 with results_lock:
+                    mark_not_found(name)
+                    conn.commit()
                     failed += 1
                 print(f"[{completed}/{total}] {name} → Exception: {e}")
 
@@ -428,11 +444,12 @@ def get_stats(conn):
     cursor.execute("SELECT COUNT(*) FROM games")
     total = cursor.fetchone()[0]
 
-    cursor.execute("SELECT COUNT(*) FROM games WHERE metacritic_score IS NOT NULL")
+    # Count matched games (metacritic_score >= 0, not counting -1 which means "not found")
+    cursor.execute("SELECT COUNT(*) FROM games WHERE metacritic_score IS NOT NULL AND metacritic_score >= 0")
     matched = cursor.fetchone()[0]
 
     cursor.execute(
-        "SELECT AVG(metacritic_score) FROM games WHERE metacritic_score IS NOT NULL"
+        "SELECT AVG(metacritic_score) FROM games WHERE metacritic_score IS NOT NULL AND metacritic_score >= 0"
     )
     avg_critic_score = cursor.fetchone()[0]
 
@@ -443,7 +460,7 @@ def get_stats(conn):
 
     cursor.execute(
         """SELECT name, metacritic_score FROM games
-           WHERE metacritic_score IS NOT NULL
+           WHERE metacritic_score IS NOT NULL AND metacritic_score >= 0
            ORDER BY metacritic_score DESC LIMIT 5"""
     )
     top_rated = cursor.fetchall()