In some cases, optional could run a destructor without having a contained object

davidstone · davidstone · commit 2a6f52d741bb · 2025-02-12T10:47:18.000-07:00
diff --git a/source/tv/optional.cpp b/source/tv/optional.cpp
@@ -102,7 +102,9 @@ struct optional_storage<T> {
 	}
 
 	constexpr auto uninitialize() -> void {
-		bounded::destroy(m_data);
+		if (is_initialized()) {
+			bounded::destroy(m_data);
+		}
 		bounded::construct_at(m_data, make_uninitialized);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,9 @@ struct optional_storage<T> {`
`102`	`102`	`}`
`103`	`103`
`104`	`104`	`constexpr auto uninitialize() -> void {`
`105`		`- bounded::destroy(m_data);`
	`105`	`+ if (is_initialized()) {`
	`106`	`+ bounded::destroy(m_data);`
	`107`	`+ }`
`106`	`108`	`bounded::construct_at(m_data, make_uninitialized);`
`107`	`109`	`}`
`108`	`110`