Remove comparison operators from generate_n_iterator and indexed_generate_n_iterator

davidstone · davidstone · commit d8e2817c8d45 · 2023-11-11T14:53:26.000-10:00
diff --git a/source/containers/algorithms/generate.cpp b/source/containers/algorithms/generate.cpp
@@ -49,17 +49,9 @@ struct generate_n_iterator {
 	}
 	OPERATORS_ARROW_DEFINITIONS
 
-	// It is undefined behavior to compare iterators into different ranges
-	friend constexpr auto operator<=>(generate_n_iterator const lhs, generate_n_iterator const rhs) {
-		return lhs.m_remaining <=> rhs.m_remaining;
-	}
 	friend constexpr auto operator<=>(generate_n_iterator const lhs, generate_sentinel) {
 		return lhs.m_remaining <=> 0_bi;
 	}
-
-	friend constexpr auto operator==(generate_n_iterator const lhs, generate_n_iterator const rhs) -> bool {
-		return lhs.m_remaining == rhs.m_remaining;
-	}
 	friend constexpr auto operator==(generate_n_iterator const lhs, generate_sentinel) -> bool {
 		return lhs.m_remaining == 0_bi;
 	}

Original file line number	Diff line number	Diff line change
`@@ -49,17 +49,9 @@ struct generate_n_iterator {`
`49`	`49`	`}`
`50`	`50`	`OPERATORS_ARROW_DEFINITIONS`
`51`	`51`
`52`		`- // It is undefined behavior to compare iterators into different ranges`
`53`		`- friend constexpr auto operator<=>(generate_n_iterator const lhs, generate_n_iterator const rhs) {`
`54`		`- return lhs.m_remaining <=> rhs.m_remaining;`
`55`		`- }`
`56`	`52`	`friend constexpr auto operator<=>(generate_n_iterator const lhs, generate_sentinel) {`
`57`	`53`	`return lhs.m_remaining <=> 0_bi;`
`58`	`54`	`}`
`59`		`-`
`60`		`- friend constexpr auto operator==(generate_n_iterator const lhs, generate_n_iterator const rhs) -> bool {`
`61`		`- return lhs.m_remaining == rhs.m_remaining;`
`62`		`- }`
`63`	`55`	`friend constexpr auto operator==(generate_n_iterator const lhs, generate_sentinel) -> bool {`
`64`	`56`	`return lhs.m_remaining == 0_bi;`
`65`	`57`	`}`