Skip to content

Commit 7394a1b

Browse files
committed
consistent build-std-crates
1 parent 66a0f58 commit 7394a1b

File tree

4 files changed

+17
-17
lines changed

4 files changed

+17
-17
lines changed

text/0000-build-std/4-build-std-always.md

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -58,14 +58,14 @@ respect the `RUSTFLAGS` environment variable.
5858
> artifacts produced by build-std match the pre-built standard library as much
5959
> as is feasible.
6060
61-
Alongside `build-std`, a `build-std-crate` key will be introduced
61+
Alongside `build-std`, a `build-std-crates` key will be introduced
6262
([?][rationale-build-std-crate]), which can be used to specify which crates from
6363
the standard library should be built. Only "core", "alloc" and "std" are valid
64-
values for `build-std-crate`.
64+
values for `build-std-crates`.
6565

6666
```toml
6767
[build]
68-
build-std-crate = "std"
68+
build-std-crates = "std"
6969
```
7070

7171
A value of "std" means that every crate in the graph has a direct dependency on
@@ -77,7 +77,7 @@ default test harness then Cargo will also build the `test` crate.
7777

7878
If [*Standard library dependencies*][deps] are implemented then `builtin`
7979
dependencies will be used if `build-std-crates` is not explicitly set.
80-
Otherwise, `build-std-crate` will default to the crate intended to be supported
80+
Otherwise, `build-std-crates` will default to the crate intended to be supported
8181
by the target (see later
8282
[*Default standard library crate for targets*][default-std-crate-for-target]
8383
section).
@@ -147,7 +147,7 @@ target in the project.
147147
- [*Why does `[target]` take precedence over `[build]` for `build-std`?*][rationale-build-std-precedence]
148148
- [*Why does "always" rebuild unconditionally?*][rationale-unconditional]
149149
- [*Why does "always" rebuild in release profile?*][rationale-release-profile]
150-
- [*Why add `build-std-crate`?*][rationale-build-std-crate]
150+
- [*Why add `build-std-crates`?*][rationale-build-std-crate]
151151
- [*Why use the lockfile of the `rust-src` component?*][rationale-lockfile]
152152
- [*Why not build the standard library in incremental?*][rationale-incremental]
153153
- [*Why not produce a `dylib` for the standard library?*][rationale-no-dylib]
@@ -159,7 +159,7 @@ target in the project.
159159

160160
- [*What should the `build-std` configuration in `.cargo/config` be named?*][unresolved-config-name]
161161
- [*What should the "always" and "never" values of `build-std` be named?*][unresolved-config-values]
162-
- [*What should `build-std-crate` be named?*][unresolved-build-std-crate-name]
162+
- [*What should `build-std-crates` be named?*][unresolved-build-std-crate-name]
163163
- [*Should the standard library inherit RUSTFLAGS?*][unresolved-inherit-rustflags]
164164

165165
*See the following sections for future possibilities:*
@@ -182,7 +182,7 @@ For example, `default_build_std_crate` will be set to "core, alloc and std" on
182182
on this target, and only "core" on "aarch64-unknown-none", as this is the only
183183
standard library crate that is supported on this target.
184184

185-
Cargo's `build-std-crate` field will default to the value of the
185+
Cargo's `build-std-crates` field will default to the value of the
186186
`default_build_std_crate` field (`std` for "core, alloc and std", `alloc` for
187187
"core and alloc", and `core` for "core"). This does not prevent users from
188188
building more crates than the default, it is only intended to be a sensible
@@ -719,15 +719,15 @@ profile.
719719

720720
[*Proposal*][proposal]
721721

722-
## Why add `build-std-crate`?
723-
[rationale-build-std-crate]: #why-add-build-std-crate
722+
## Why add `build-std-crates`?
723+
[rationale-build-std-crate]: #why-add-build-std-crates
724724

725725
Not all standard library crates will build on all targets. In a `no_std` project
726-
for a tier three target, `build-std-crate` gives the user the ability to limit
726+
for a tier three target, `build-std-crates` gives the user the ability to limit
727727
which crates are built to those they know they need and will build successfully.
728728

729729
*See [Standard library dependencies*][deps] for an alternative to
730-
`build-std-crate`.*
730+
`build-std-crates`.*
731731

732732
[*Proposal*][proposal]
733733

@@ -1083,8 +1083,8 @@ What is the most intuitive name for the values of the `build-std` setting?
10831083

10841084
[*Proposal*][proposal]
10851085

1086-
## What should `build-std-crate` be named?
1087-
[unresolved-build-std-crate-name]: #what-should-build-std-crate-be-named
1086+
## What should `build-std-crates` be named?
1087+
[unresolved-build-std-crate-name]: #what-should-build-std-crates-be-named
10881088

10891089
What should this configuration option be named?
10901090

text/0000-build-std/6-appendix-summary-of-changes.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ The following are all of the unresolved questions from all stages of the RFC:
7272

7373
- [*What should the `build-std` configuration in `.cargo/config` be named?*][unresolved-config-name]
7474
- [*What should the "always" and "never" values of `build-std` be named?*][unresolved-config-values]
75-
- [*What should `build-std-crate` be named?*][unresolved-build-std-crate-name]
75+
- [*What should `build-std-crates` be named?*][unresolved-build-std-crate-name]
7676

7777
## Future possibilities
7878
[future-possibilities]: #future-possibilities

text/0000a-build-std-compatible.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ Yes | `release` | Changed | Yes, std's `
7777
> table for "target modifiers changed, profile unchanged".
7878
7979
As with the "always" option, the exact crates from the standard library to be
80-
built are determined by the `build-std-crate` option or explicit dependencies on
80+
built are determined by the `build-std-crates` option or explicit dependencies on
8181
the standard library if [*Standard library dependencies*][deps] are implemented.
8282

8383
Multi-target projects (resulting from multiple `--target` flags, the "target"
@@ -121,7 +121,7 @@ immediately face a compilation error and need to go learn about
121121
Rebuilds of the standard library happening transparently reduce the requirement
122122
that users learn about build-std as something to enable and configure. Combined
123123
with explicit dependencies on the standard library crates from
124-
[*Standard library dependencies*][deps] or `build-std-crate` from
124+
[*Standard library dependencies*][deps] or `build-std-crates` from
125125
[`build-std="always"`][always], build-std can avoid any cost on users that do
126126
not require it (by triggering automatically when a target modifier is changed,
127127
and having no unnecessary rebuilds otherwise).

text/0000b-build-std-match-profile.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ options are primarily useful for users wanting to use the same codegen flags
9494
with the standard library or have a more debuggable standard library.
9595

9696
As with the "always" option, the exact crates from the standard library to be
97-
built are determined by the `build-std-crate` option or explicit dependencies on
97+
built are determined by the `build-std-crates` option or explicit dependencies on
9898
the standard library if [*Standard library dependencies*][deps] were implemented.
9999

100100
# Rationale and alternatives

0 commit comments

Comments
 (0)