Delete emit breaks from R2R helper node (dotnet#114920)

am11 · web-flow · commit e49f3588c823 · 2025-04-23T14:25:30.000-07:00
* Delete emit breaks from R2R helper node

* Update RiscV64ReadyToRunHelperNode.cs
diff --git a/src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/Target_ARM64/ARM64ReadyToRunHelperNode.cs b/src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/Target_ARM64/ARM64ReadyToRunHelperNode.cs
@@ -143,9 +143,6 @@ protected override void EmitCode(NodeFactory factory, ref ARM64Emitter encoder,
                         MethodDesc targetMethod = (MethodDesc)Target;
                         if (targetMethod.OwningType.IsInterface)
                         {
-                            // Not tested
-                            encoder.EmitINT3();
-
                             encoder.EmitMOV(encoder.TargetRegister.Arg1, factory.InterfaceDispatchCell(targetMethod));
                             encoder.EmitJMP(factory.ExternSymbol("RhpResolveInterfaceMethod"));
                         }
diff --git a/src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/Target_RiscV64/RiscV64ReadyToRunHelperNode.cs b/src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/Target_RiscV64/RiscV64ReadyToRunHelperNode.cs
@@ -133,9 +133,6 @@ protected override void EmitCode(NodeFactory factory, ref RiscV64Emitter encoder
                         MethodDesc targetMethod = (MethodDesc)Target;
                         if (targetMethod.OwningType.IsInterface)
                         {
-                            // Not tested
-                            encoder.EmitBreak();
-
                             encoder.EmitMOV(encoder.TargetRegister.Arg1, factory.InterfaceDispatchCell(targetMethod));
                             encoder.EmitJMP(factory.ExternSymbol("RhpResolveInterfaceMethod"));
                         }

Original file line number	Diff line number	Diff line change
`@@ -143,9 +143,6 @@ protected override void EmitCode(NodeFactory factory, ref ARM64Emitter encoder,`
`143`	`143`	`MethodDesc targetMethod = (MethodDesc)Target;`
`144`	`144`	`if (targetMethod.OwningType.IsInterface)`
`145`	`145`	`{`
`146`		`- // Not tested`
`147`		`- encoder.EmitINT3();`
`148`		`-`
`149`	`146`	`encoder.EmitMOV(encoder.TargetRegister.Arg1, factory.InterfaceDispatchCell(targetMethod));`
`150`	`147`	`encoder.EmitJMP(factory.ExternSymbol("RhpResolveInterfaceMethod"));`
`151`	`148`	`}`
Original file line number	Diff line number	Diff line change
`@@ -133,9 +133,6 @@ protected override void EmitCode(NodeFactory factory, ref RiscV64Emitter encoder`
`133`	`133`	`MethodDesc targetMethod = (MethodDesc)Target;`
`134`	`134`	`if (targetMethod.OwningType.IsInterface)`
`135`	`135`	`{`
`136`		`- // Not tested`
`137`		`- encoder.EmitBreak();`
`138`		`-`
`139`	`136`	`encoder.EmitMOV(encoder.TargetRegister.Arg1, factory.InterfaceDispatchCell(targetMethod));`
`140`	`137`	`encoder.EmitJMP(factory.ExternSymbol("RhpResolveInterfaceMethod"));`
`141`	`138`	`}`