fix(unsubscribe): only punsubscribe when a pattern matcher actually has been used #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as been used Instead of both unsubscribing and punsubcsribing towards redis, we select the method based on the configuration when the subscribe-method was issued. This is important for clients wanting to use a serverless redis or valkey with AWS, as they do not support the PUNSUBSCRIBE command at all.
|
@davidyaha Do you have time to look at this PR? Would love for it to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of both unsubscribing and punsubcsribing towards redis, we select the method based on the configuration when the subscribe-method was issued.
This is important for clients wanting to use a serverless redis or valkey with AWS, as they do not support the PUNSUBSCRIBE command at all.