Better log message for enable/disable

[iacore]

dinitctl enable X says X is enabled without telling me if the service is started or not.

If dinitctl disable X cannot stop X, it says something vague like X may have dependencies that prevents it from stopping

Could the error/log messages be more clear?

[davmac314]

I'm not sure if it's a change since the last release, but dinitctl enable X tells me if the service started:

~/.config/dinit.d$ ~/workspace/dinit/src/dinitctl enable A
Service 'A' has been enabled.
Service 'A' started.
~/.config/dinit.d$ 

If dinitctl disable X cannot stop X, it says something vague like X may have dependencies that prevents it from stopping
Could the error/log messages be more clear?

Dinitctl checks whether the service target state is "stopped" and if not issues the above message. There's a race between issuing the disable and checking the status so it's always possible that it's not stopped because it has been started again. Actually detecting that would be possible but seems like more work than it's worth (at least at the moment, there are other priorities).

[davmac314]

I'm not sure if it's a change since the last release

The responsible commit was in 2022 so I think it's been that way for a while. Are you sure it doesn't say anything? And you are running the latest release?

[davmac314]

dinitctl enable X tells me if the service started:

I had a though after writing this, and just checked to confirm. It won't tell you that the service has started if the service has already started - in that case it just completes immediately. I'll grant that's not completely consistent.

[davmac314]

I created issue #507 for this.

[iacore]

It was 0.19.3-r0. https://pkgs.chimera-linux.org/packages?name=dinit

Not as old as 2022.