Skip to content

[Bug]: unreachable code warning advanced-compilation in re-frame v1.4.4 #827

@ghaskins

Description

@ghaskins

What happened?

I started seeing this warning after upgrading all my deps

------ WARNING #1 -  -----------------------------------------------------------
 File: ~/.m2/repository/re-frame/re-frame/1.4.4/re-frame-1.4.4.jar!/re_frame/flow/alpha.cljc:63:2
--------------------------------------------------------------------------------
  60 |              flows))
  61 |
  62 | (defn validate-inputs [{:keys [inputs]}]
  63 |   (doseq [[_ input] inputs
--------^-----------------------------------------------------------------------
 unreachable code
--------------------------------------------------------------------------------
  64 |           :when (not ((some-fn db-path? flow<-?) input))]
  65 |     (throw (#?(:clj Exception. :cljs js/Error.) "bad input"))))
  66 |
  67 | (defn warn-stale-dependencies [flows new-flow]
--------------------------------------------------------------------------------
------ WARNING #2 -  -----------------------------------------------------------
 File: ~/.m2/repository/re-frame/re-frame/1.4.4/re-frame-1.4.4.jar!/re_frame/flow/alpha.cljc:63:2
--------------------------------------------------------------------------------
  60 |              flows))
  61 |
  62 | (defn validate-inputs [{:keys [inputs]}]
  63 |   (doseq [[_ input] inputs
--------^-----------------------------------------------------------------------
 unreachable code
--------------------------------------------------------------------------------
  64 |           :when (not ((some-fn db-path? flow<-?) input))]
  65 |     (throw (#?(:clj Exception. :cljs js/Error.) "bad input"))))
  66 |
  67 | (defn warn-stale-dependencies [flows new-flow]
--------------------------------------------------------------------------------

relevant deps:

             [org.clojure/clojure "1.12.4"]
             [org.clojure/clojurescript "1.12.134"
              :exclusions [com.google.javascript/closure-compiler-unshaded
                           org.clojure/google-closure-library
                           org.clojure/google-closure-library-third-party]]
             [thheller/shadow-cljs "3.3.5"]
             [re-frame "1.4.4"]

Version

v1.4.4

What runtimes are you seeing the problem on?

JVM (CLJC)

Relevant console output

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions