Skip to content

Commit 6de9429

Browse files
authored
Merge pull request #30 from dayitv89/androidUpgrade33
Android Firebase SDK Upgrade 33
2 parents a2c92b5 + 4ddee42 commit 6de9429

File tree

3 files changed

+23
-25
lines changed

3 files changed

+23
-25
lines changed

android/build.gradle

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,32 +7,32 @@ buildscript {
77
}
88

99
dependencies {
10-
classpath 'com.android.tools.build:gradle:3.1.2'
10+
classpath 'com.android.tools.build:gradle:3.5.4'
1111
}
1212
}
1313

1414
apply plugin: 'com.android.library'
1515

16-
def DEFAULT_COMPILE_SDK_VERSION = 27
17-
def DEFAULT_BUILD_TOOLS_VERSION = "27.0.3"
18-
def DEFAULT_TARGET_SDK_VERSION = 27
19-
def DEFAULT_FIREBASE_BOM_VERSION = "28.4.1"
20-
def DEFAULT_SUPPORT_LIB_VERSION = "27.0.0"
16+
def DEFAULT_TARGET_SDK_VERSION = 33
17+
def DEFAULT_FIREBASE_BOM_VERSION = "32.7.2"
18+
def DEFAULT_SUPPORT_LIB_VERSION = "34.0.0"
2119

2220

2321

2422
android {
25-
compileSdkVersion rootProject.hasProperty('compileSdkVersion') ? rootProject.compileSdkVersion : DEFAULT_COMPILE_SDK_VERSION
26-
buildToolsVersion rootProject.hasProperty('buildToolsVersion') ? rootProject.buildToolsVersion : DEFAULT_BUILD_TOOLS_VERSION
2723
defaultConfig {
28-
minSdkVersion 16
24+
minSdkVersion 23
2925
targetSdkVersion rootProject.hasProperty('targetSdkVersion') ? rootProject.targetSdkVersion : DEFAULT_TARGET_SDK_VERSION
3026
versionCode 1
3127
versionName "1.0"
3228
}
3329
lintOptions {
3430
abortOnError false
3531
}
32+
def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION
33+
if (agpVersion.tokenize('.')[0].toInteger() >= 7) {
34+
namespace "com.gds.quickfirebase"
35+
}
3636
}
3737

3838
repositories {
Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
3-
package="com.gds.quickfirebase">
2+
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
43

5-
</manifest>
4+
</manifest>

android/src/main/java/com/gds/quickfirebase/RNQuickFirebase.java

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
package com.gds.quickfirebase;
22

33
import android.annotation.SuppressLint;
4-
import android.app.Activity;
5-
import android.support.annotation.NonNull;
4+
import androidx.annotation.NonNull;
65
import android.os.Bundle;
76
import android.text.TextUtils;
87
import com.facebook.react.bridge.Arguments;
@@ -20,6 +19,7 @@
2019
import com.google.firebase.auth.FirebaseAuth;
2120
import com.google.firebase.auth.FirebaseUser;
2221
import com.google.firebase.auth.PhoneAuthCredential;
22+
import com.google.firebase.auth.PhoneAuthOptions;
2323
import com.google.firebase.auth.PhoneAuthProvider;
2424

2525
import java.util.concurrent.TimeUnit;
@@ -52,28 +52,27 @@ public String getName() {
5252

5353
@ReactMethod
5454
public void sendOTP(String phone, final Promise promise) {
55-
PhoneAuthProvider.getInstance().verifyPhoneNumber(
56-
phone, // Phone number to verify
57-
60, // Timeout duration
58-
TimeUnit.SECONDS, // Unit of timeout
59-
reactContext.getCurrentActivity(), // Activity (for callback binding)
60-
new PhoneAuthProvider.OnVerificationStateChangedCallbacks() {
55+
PhoneAuthOptions phoneAuthOptions = new PhoneAuthOptions.Builder(mAuth).setPhoneNumber(phone)
56+
.setTimeout(60L, TimeUnit.SECONDS).setActivity(reactContext.getCurrentActivity())
57+
.setCallbacks(new PhoneAuthProvider.OnVerificationStateChangedCallbacks() {
6158
@Override
62-
public void onVerificationCompleted(PhoneAuthCredential credential) {
59+
public void onVerificationCompleted(@NonNull PhoneAuthCredential phoneAuthCredential) {
60+
6361
}
6462

6563
@Override
66-
public void onVerificationFailed(FirebaseException e) {
64+
public void onVerificationFailed(@NonNull FirebaseException e) {
6765
promise.reject(e);
6866
}
6967

7068
@Override
71-
public void onCodeSent(String verificationId, PhoneAuthProvider.ForceResendingToken token) {
69+
public void onCodeSent(@NonNull String verificationId, @NonNull PhoneAuthProvider.ForceResendingToken forceResendingToken) {
7270
promise.resolve(verificationId);
7371
mVerificationId = verificationId;
74-
mResendToken = token;
72+
mResendToken = forceResendingToken;
7573
}
76-
});
74+
}).build();
75+
PhoneAuthProvider.verifyPhoneNumber(phoneAuthOptions);
7776
}
7877

7978
@ReactMethod

0 commit comments

Comments
 (0)