Skip to content

Commit d3713d2

Browse files
remove setScreen deprecated method (#20)
* remove setScreen deprecated method * Update RNQuickFirebase.java * Update RNQuickFirebase.m * Update index.js * Update README.md * Update package.json Co-authored-by: Gaurav D. Sharma <[email protected]>
1 parent eb0f9da commit d3713d2

File tree

6 files changed

+1
-25
lines changed

6 files changed

+1
-25
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ import RNQuickFirebase from 'react-native-quick-firebase';
6868
class App extends Component {
6969
componentDidMount() {
7070
RNQuickFirebase.setAnalyticsEnabled(true);
71-
RNQuickFirebase.setScreenName('Base OTP Scene');
7271
}
7372

7473
onSendOTP = async () => {

android/src/main/java/com/gds/quickfirebase/RNQuickFirebase.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -122,19 +122,6 @@ public void logEvent(String name, ReadableMap parameters) {
122122
firebaseAnalytics.logEvent(name,parmas);
123123
}
124124

125-
@ReactMethod
126-
public void setScreenName(final String name) {
127-
final Activity currentActivity = reactContext.getCurrentActivity();
128-
if(currentActivity != null){
129-
currentActivity.runOnUiThread(new Runnable() {
130-
@Override
131-
public void run() {
132-
firebaseAnalytics.setCurrentScreen(currentActivity, name, null);
133-
}
134-
});
135-
}
136-
}
137-
138125
@ReactMethod
139126
public void setAnalyticsEnabled(boolean enabled) {
140127
firebaseAnalytics.setAnalyticsCollectionEnabled(enabled);

index.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,6 @@ const setUserProperty = (name, property) => {
3939
return bridge.setUserProperty(name, property)
4040
};
4141

42-
const setScreenName = (screenName) => {
43-
return bridge.setScreenName(screenName)
44-
};
45-
4642
const logEvent = (name, params) =>{
4743
return bridge.logEvent(name, params)
4844
};
@@ -54,6 +50,5 @@ module.exports = {
5450
setAnalyticsEnabled,
5551
setUserId,
5652
setUserProperty,
57-
setScreenName,
5853
logEvent
5954
};

ios/RNQuickFirebase.m

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,6 @@ @implementation RNQuickFirebase
7777
property:(NSDictionary*) data) {
7878
[FIRAnalytics logEventWithName:eventName parameters:data];
7979
}
80-
81-
RCT_EXPORT_METHOD(setScreenName:(NSString*) screenName){
82-
[FIRAnalytics setScreenName:screenName screenClass:screenName];
83-
}
8480

8581
RCT_EXPORT_METHOD(setAnalyticsEnabled:(BOOL) enable) {
8682
[FIRAnalytics setAnalyticsCollectionEnabled:enable];

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-native-quick-firebase",
3-
"version": "1.1.0",
3+
"version": "1.1.1",
44
"author": "Gaurav D. Sharma <[email protected]>",
55
"description": "Quick firebase integration with phone auth and analytics",
66
"homepage": "https://github.com/dayitv89/react-native-quick-firebase",

sample/index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ class App extends Component {
1212

1313
componentDidMount() {
1414
RNQuickFirebase.setAnalyticsEnabled(true);
15-
RNQuickFirebase.setScreenName("Base OTP Scene");
1615
}
1716

1817
onSendOTP = async () => {

0 commit comments

Comments
 (0)