Merge branch '1.8' into fix/symfony4_structure

Author: jwong-dayspring

Command/BuildCommand.php

@@ -41,6 +41,8 @@ protected function configure()
     /**
      * @see Command
      *
+     * @return int 0 if everything went fine, or an exit code
+     *
      * @throws \InvalidArgumentException When the target directory does not exist
      */
     protected function execute(InputInterface $input, OutputInterface $output)

Command/DatabaseCreateCommand.php

@@ -35,6 +35,8 @@ protected function configure()
     /**
      * @see Command
      *
+     * @return int 0 if everything went fine, or an exit code
+     *
      * @throws \InvalidArgumentException When the target directory does not exist
      */
     protected function execute(InputInterface $input, OutputInterface $output)

Command/DatabaseDropCommand.php

@@ -46,6 +46,8 @@ protected function configure()
     /**
      * @see Command
      *
+     * @return int 0 if everything went fine, or an exit code
+     *
      * @throws \InvalidArgumentException When the target directory does not exist
      */
     protected function execute(InputInterface $input, OutputInterface $output)

Command/FixturesDumpCommand.php

@@ -54,6 +54,8 @@ protected function configure()
     /**
      * @see Command
      *
+     * @return int 0 if everything went fine, or an exit code
+     *
      * @throws \InvalidArgumentException When the target directory does not exist
      */
     protected function execute(InputInterface $input, OutputInterface $output)

Command/FixturesLoadCommand.php

@@ -111,6 +111,8 @@ protected function configure()
     /**
      * @see Command
      *
+     * @return int 0 if everything went fine, or an exit code
+     *
      * @throws \InvalidArgumentException When the target directory does not exist
      */
     protected function execute(InputInterface $input, OutputInterface $output)
@@ -156,12 +158,12 @@ protected function execute(InputInterface $input, OutputInterface $output)
      *
      * @param  \Symfony\Component\Console\Input\InputInterface   $input
      * @param  \Symfony\Component\Console\Output\OutputInterface $output
-     * @return void
+     * @return int
      */
     protected function loadFixtures(InputInterface $input, OutputInterface $output, $type = null)
     {
         if (null === $type) {
-            return;
+            return -2;
         }
 
         $datas = $this->getFixtureFiles($type);
@@ -177,7 +179,7 @@ protected function loadFixtures(InputInterface $input, OutputInterface $output,
         } elseif ('xml' === $type) {
             $loader = new XmlDataLoader($this->getApplication()->getKernel()->getProjectDir() . '/app');
         } else {
-            return;
+            return -3;
         }
 
         try {
@@ -188,20 +190,20 @@ protected function loadFixtures(InputInterface $input, OutputInterface $output,
                 '',
                 $e->getMessage()), 'fg=white;bg=red');
 
-            return false;
+            return -4;
         }
 
         $output->writeln(sprintf('<comment>%s</comment> %s fixtures file%s loaded.', $nb, strtoupper($type), $nb > 1 ? 's' : ''));
 
-        return true;
+        return 0;
     }
 
     /**
      * Load SQL fixtures
      *
      * @param  \Symfony\Component\Console\Input\InputInterface   $input
      * @param  \Symfony\Component\Console\Output\OutputInterface $output
-     * @return void
+     * @return int
      */
     protected function loadSqlFixtures(InputInterface $input, OutputInterface $output)
     {

Command/FormGenerateCommand.php

@@ -47,6 +47,8 @@ protected function configure()
     /**
      * @see Command
      *
+     * @return int 0 if everything went fine, or an exit code
+     *
      * @throws \InvalidArgumentException When the target directory does not exist
      */
     protected function execute(InputInterface $input, OutputInterface $output)

Command/GraphvizGenerateCommand.php

@@ -39,6 +39,8 @@ protected function configure()
     /**
      * @see Command
      *
+     * @return int 0 if everything went fine, or an exit code
+     *
      * @throws \InvalidArgumentException When the target directory does not exist
      */
     protected function execute(InputInterface $input, OutputInterface $output)

Command/MigrationGenerateDiffCommand.php

@@ -41,12 +41,15 @@ protected function configure()
     /**
      * @see Command
      *
+     * @return int 0 if everything went fine, or an exit code
+     *
      * @throws \InvalidArgumentException When the target directory does not exist
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
         if (true === $this->callPhing('diff')) {
             $this->writeSummary($output, 'propel-sql-diff');
+            return 0;
         } elseif ( strpos( $this->buffer, 'Uncommitted migrations have been found' ) ) {
             $this->writeSection($output, array(
                 '[Propel] Error',

Command/MigrationMigrateCommand.php

@@ -50,6 +50,8 @@ protected function configure()
     /**
      * @see Command
      *
+     * @return int 0 if everything went fine, or an exit code
+     *
      * @throws \InvalidArgumentException When the target directory does not exist
      */
     protected function execute(InputInterface $input, OutputInterface $output)

Command/MigrationStatusCommand.php

@@ -39,6 +39,8 @@ protected function configure()
     /**
      * @see Command
      *
+     * @return int 0 if everything went fine, or an exit code
+     *
      * @throws \InvalidArgumentException When the target directory does not exist
      */
     protected function execute(InputInterface $input, OutputInterface $output)