KRF-266 #resolve Renamed methods Loop::{beforeTick, afterTick} to Loop::{onBeforeTick, Loop::onAfterTick}

Author: khelle

Bridge/React/ReactLoop.php

@@ -123,7 +123,7 @@ public function isTimerActive(\React\EventLoop\Timer\TimerInterface $timer)
      */
     public function nextTick(callable $listener)
     {
-        $this->loop->beforeTick($listener);
+        $this->loop->onBeforeTick($listener);
     }
 
     /**
@@ -132,7 +132,7 @@ public function nextTick(callable $listener)
      */
     public function futureTick(callable $listener)
     {
-        $this->loop->afterTick($listener);
+        $this->loop->onAfterTick($listener);
     }
 
     /**

Loop.php

@@ -175,36 +175,45 @@ public function isTimerActive(TimerInterface $timer)
      * @override
      * @inheritDoc
      */
-    public function startTick(callable $listener)
+    public function onStart(callable $listener)
     {
-        $this->loop->startTick($listener);
+        $this->loop->onStart($listener);
     }
 
     /**
      * @override
      * @inheritDoc
      */
-    public function stopTick(callable $listener)
+    public function onStop(callable $listener)
     {
-        $this->loop->stopTick($listener);
+        $this->loop->onStop($listener);
     }
 
     /**
      * @override
      * @inheritDoc
      */
-    public function beforeTick(callable $listener)
+    public function onTick(callable $listener)
     {
-        $this->loop->beforeTick($listener);
+        $this->loop->onAfterTick($listener);
     }
 
     /**
      * @override
      * @inheritDoc
      */
-    public function afterTick(callable $listener)
+    public function onBeforeTick(callable $listener)
     {
-        $this->loop->afterTick($listener);
+        $this->loop->onBeforeTick($listener);
+    }
+
+    /**
+     * @override
+     * @inheritDoc
+     */
+    public function onAfterTick(callable $listener)
+    {
+        $this->loop->onAfterTick($listener);
     }
 
     /**

LoopInterface.php

@@ -94,7 +94,7 @@ public function isTimerActive(TimerInterface $timer);
      *
      * @param callable $listener
      */
-    public function startTick(callable $listener);
+    public function onStart(callable $listener);
 
     /**
      * Schedule a callback to be invoked on the stop tick of event loop.
@@ -103,7 +103,17 @@ public function startTick(callable $listener);
      *
      * @param callable $listener
      */
-    public function stopTick(callable $listener);
+    public function onStop(callable $listener);
+
+    /**
+     * Schedule a callback to be invoked on a future tick of the event loop.
+     *
+     * Callbacks are guaranteed to be executed in the order they are enqueued. This method is an alias for onAfterTick()
+     * method.
+     *
+     * @param callable $listener
+     */
+    public function onTick(callable $listener);
 
     /**
      * Schedule a callback to be invoked on the next tick of the event loop.
@@ -112,7 +122,7 @@ public function stopTick(callable $listener);
      *
      * @param callable $listener
      */
-    public function beforeTick(callable $listener);
+    public function onBeforeTick(callable $listener);
 
     /**
      * Schedule a callback to be invoked on a future tick of the event loop.
@@ -121,5 +131,5 @@ public function beforeTick(callable $listener);
      *
      * @param callable $listener
      */
-    public function afterTick(callable $listener);
+    public function onAfterTick(callable $listener);
 }

LoopModelInterface.php

@@ -95,7 +95,7 @@ public function isTimerActive(TimerInterface $timer);
      *
      * @param callable $listener
      */
-    public function startTick(callable $listener);
+    public function onStart(callable $listener);
 
     /**
      * Schedule a callback to be invoked on the stop tick of event loop.
@@ -104,7 +104,7 @@ public function startTick(callable $listener);
      *
      * @param callable $listener
      */
-    public function stopTick(callable $listener);
+    public function onStop(callable $listener);
 
     /**
      * Schedule a callback to be invoked on the next tick of the event loop.
@@ -113,7 +113,7 @@ public function stopTick(callable $listener);
      *
      * @param callable $listener
      */
-    public function beforeTick(callable $listener);
+    public function onBeforeTick(callable $listener);
 
     /**
      * Schedule a callback to be invoked on a future tick of the event loop.
@@ -122,7 +122,7 @@ public function beforeTick(callable $listener);
      *
      * @param callable $listener
      */
-    public function afterTick(callable $listener);
+    public function onAfterTick(callable $listener);
 
     /**
      * Perform a single iteration of the event loop.

Model/SelectLoop.php

@@ -225,7 +225,7 @@ public function isTimerActive(TimerInterface $timer)
      * @override
      * @inheritDoc
      */
-    public function startTick(callable $listener)
+    public function onStart(callable $listener)
     {
         $this->startTickQueue->add($listener);
     }
@@ -234,7 +234,7 @@ public function startTick(callable $listener)
      * @override
      * @inheritDoc
      */
-    public function stopTick(callable $listener)
+    public function onStop(callable $listener)
     {
         $this->stopTickQueue->add($listener);
     }
@@ -243,7 +243,7 @@ public function stopTick(callable $listener)
      * @override
      * @inheritDoc
      */
-    public function beforeTick(callable $listener)
+    public function onBeforeTick(callable $listener)
     {
         $this->nextTickQueue->add($listener);
     }
@@ -252,7 +252,7 @@ public function beforeTick(callable $listener)
      * @override
      * @inheritDoc
      */
-    public function afterTick(callable $listener)
+    public function onAfterTick(callable $listener)
     {
         $this->futureTickQueue->add($listener);
     }