Skip to content

Commit 92ab39a

Browse files
committed
KRF-298 #fix Fixed Ghost Error being thrown on each failure introduced in KRF-234
1 parent ecac890 commit 92ab39a

File tree

3 files changed

+18
-11
lines changed

3 files changed

+18
-11
lines changed

Error/UndefinedError.php

Lines changed: 0 additions & 8 deletions
This file was deleted.

ErrorHandler.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ abstract class ErrorHandler
5151
* @throws FatalError
5252
* @throws NoticeError
5353
* @throws WarningError
54-
* @throws UndefinedError
5554
*/
5655
public static function handleError($code, $message, $file, $line)
5756
{
@@ -66,7 +65,7 @@ public static function handleError($code, $message, $file, $line)
6665
case static::E_NOTICE: throw new NoticeError($message);
6766
case static::E_WARNING: throw new WarningError($message);
6867
case static::E_ERROR: throw new FatalError($message);
69-
default: throw new UndefinedError($message);
68+
default: return;
7069
}
7170
}
7271

Throwable.php

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,22 @@ abstract class Throwable
1212
*/
1313
public static function parseThrowableMessage($ex)
1414
{
15-
return '[' . static::getBasename($ex['class']) . '] ' . '"' . trim($ex['message'], '"') . '"';
15+
$message = $ex['message'];
16+
17+
if ($ex['isError'] && strpos($message, ' in ') !== false)
18+
{
19+
$message = preg_replace('#([a-zA-Z0-9-_]+?)/#siU', '', $message);
20+
$message = preg_replace('#/#si', '', $message, 1);
21+
}
22+
else
23+
{
24+
$message = trim($message, '"');
25+
$file = str_replace('.php', '', basename($ex['file']));
26+
$line = $ex['line'];
27+
$message = '"' . $message . '" in ' . $file . ':' . $line;
28+
}
29+
30+
return '[' . static::getBasename($ex['class']) . '] ' . $message;
1631
}
1732

1833
/**
@@ -51,6 +66,7 @@ public static function getThrowableData($ex, $offset = 0)
5166
'line' => $ex->getLine(),
5267
'code' => $ex->getCode(),
5368
'trace' => static::getTraceElements($ex, $offset),
69+
'isError' => $ex instanceof \Error,
5470
'prev' => null
5571
];
5672
}

0 commit comments

Comments
 (0)