Skip to content

Commit 36dd0c5

Browse files
authored
fix: checks-done step must succeed (#329)
1 parent d22ea64 commit 36dd0c5

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

.github/workflows/default.yml

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,21 @@ jobs:
2828
needs: [init]
2929

3030
checks-done:
31+
if: ${{ always() }}
3132
runs-on: ubuntu-latest
3233
steps:
3334
- name: 🎉 Checks done
34-
run: echo "🎉 All tests & build were successful."
35+
run: |
36+
resultBuild="${{ needs.build.result }}"
37+
resultTest="${{ needs.test.result }}"
38+
resultLint="${{ needs.lint.result }}"
39+
if [[ $resultBuild == "success" && $resultTest == "success" && $resultLint == "success" ]]; then
40+
echo "🎉 All tests & build were successful."
41+
exit 0
42+
else
43+
echo "Some tests were failing."
44+
exit 1
45+
fi
3546
needs: [build, test, lint]
3647

3748
deploy:

0 commit comments

Comments
 (0)