Skip to content

Commit 71fb84e

Browse files
authored
fix: added missing select disabled styles (#360)
1 parent 06b5e1d commit 71fb84e

File tree

3 files changed

+36
-1
lines changed

3 files changed

+36
-1
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<dl>
22
{{#each variations}}
33
<dt>{{variant}}:</dt>
4-
<dd>{{> elements-select }}</dd>
4+
<dd>{{> elements-select disabled=../disabled }}</dd>
55
{{/each }}
66
</dl>
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
{
2+
"variations": [
3+
{
4+
"variant": "semitransparent",
5+
"id": "select05",
6+
"label": "Devices"
7+
},
8+
{
9+
"variant": "white",
10+
"id": "select06",
11+
"label": "Devices"
12+
},
13+
{
14+
"variant": "solid",
15+
"id": "select07",
16+
"label": "Devices"
17+
},
18+
{
19+
"variant": "outline",
20+
"id": "select08",
21+
"label": "Devices"
22+
}
23+
],
24+
"disabled": true
25+
}

source/_patterns/01-elements/select/select.scss

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,16 @@
4949
}
5050
}
5151

52+
// TODO: Evaluate whether those could get moved to ../_form-elements.scss
53+
&:disabled,
54+
fieldset:disabled & {
55+
&,
56+
& + .elm-label {
57+
// Decided against cursor: not-allowed, compare to e.g. https://phabricator.wikimedia.org/T121960
58+
opacity: 0.4;
59+
}
60+
}
61+
5262
// ### Style variations
5363
&[data-variant="semitransparent"] {
5464
@extend %form-element-semitransparent;

0 commit comments

Comments
 (0)