Skip to content

Commit a04b9ae

Browse files
committed
refactor: remove headline element – is replaced by base/typography styles
1 parent dbb45e5 commit a04b9ae

File tree

15 files changed

+18
-127
lines changed

15 files changed

+18
-127
lines changed

source/_patterns/01-elements/headline/_headline.hbs

Lines changed: 0 additions & 1 deletion
This file was deleted.

source/_patterns/01-elements/headline/_headline.json

Lines changed: 0 additions & 4 deletions
This file was deleted.

source/_patterns/01-elements/headline/_headline.variables.scss

Lines changed: 0 additions & 11 deletions
This file was deleted.

source/_patterns/01-elements/headline/enterprise/_headline.variables.scss

Lines changed: 0 additions & 1 deletion
This file was deleted.

source/_patterns/01-elements/headline/enterprise/headline.scss

Lines changed: 0 additions & 2 deletions
This file was deleted.

source/_patterns/01-elements/headline/headline.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

source/_patterns/01-elements/headline/headline.scss

Lines changed: 0 additions & 79 deletions
This file was deleted.

source/_patterns/02-components/dialog/dialog.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
{{/if }}
44
<dialog id="{{ id }}" class="cmp-dialog">
55
<header>
6-
{{> elements-headline type='2' text='Modal' id='' }}
6+
<h2>Modal</h2>
77
{{> elements-link styleModifier='is-close' href='#' value='Close' title='Close the dialog' }}
88
</header>
99
<main>

source/_patterns/02-components/dialog/dialog.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747

4848
transform: translateY(-#{to-rem($pxValue: 9)});
4949

50+
// TODO use base typography placeholder for headlines
5051
.elm-headline {
5152
font-size: to-rem($pxValue: 18);
5253
font-weight: 700;

source/_patterns/02-components/pagination/pagination.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{{! TODO: evaluate on the correct role and aria-label in here - there's a duplicate currently with both label and labelledby (prefered) }}
22
<nav class="cmp-pagination" aria-label="pagination" aria-labelledby="headline01">
3-
{{> elements-headline type='2' text='Pagination' id='headline01' }}
3+
<h2 id="headline01">Pagination</h2>
44
<ol>
55
<li>{{> elements-link value='Previous' title='Goto previous page' rel='prev' disabled='true' }}</li>
66
<li>{{> elements-link value='1' current='page' }}</li>

0 commit comments

Comments
 (0)