Skip to content

Commit d931daf

Browse files
committed
refactor: removed legacy implementation for the progress element
of the output element, that you should replace by label
1 parent 67d27bd commit d931daf

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

docs/migrationGuide.adoc

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,18 @@ As with every release you're recommended to do a visual regression testing for y
44

55
Especially the following aspects have changed through the various different releases and would need your review and probably adaptions within your code base.
66

7+
== DB UI Core 3.0.0 Migration Guide
8+
9+
=== progress
10+
11+
We've remove the deprecated previous HTML implementation of the label by an `output` element and replaced it by an actual `label` element. Necessary changes:
12+
13+
- replaced `output` element by `label` element
14+
- especially for screenreader optimization added the following two attributes to this `label` element:
15+
`id="{{ id }}-label" aria-hidden="true"`
16+
- The `id`-attributes value on that `label` element needs to match the following attributes values that needs to get added onto the `progress` HTML tag itself:
17+
`aria-describedby="{{ id }}-label"`
18+
719
== DB UI Core 2.0.0 Migration Guide
820

921
=== Using SCSS/SASS sources

source/_patterns/01-elements/progress/progress.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@
9696
background: none;
9797
}
9898

99-
& + output, // legacy; TODO: remove with the next major release
10099
& + label {
101100
align-items: center;
102101
background: $progress-conic-inner-backgroundColor; // * TODO: possibly rework variable naming

0 commit comments

Comments
 (0)