refactor: optimizations

Author: mfranzke

helpers/test.js

@@ -1,3 +1,4 @@
+/* eslint-disable-next-line unicorn/prefer-module, unicorn/no-anonymous-default-export */
 module.exports = function (Handlebars) {
 	Handlebars.registerHelper('test', function () {
 		return 'This is a test helper';

scripts/check-commit-mail.mjs

@@ -6,8 +6,10 @@ import * as dotenv from 'dotenv';
 dotenv.config();
 
 const checkCommitMail = () => {
+	// eslint-disable-next-line no-console
 	console.log(`Check COMMIT_MAIL`);
 	if (!process.env.COMMIT_MAIL) {
+		// eslint-disable-next-line no-console
 		console.error(
 			`No COMMIT_MAIL set in .env, please look at the file '.env.template'`
 		);
@@ -20,9 +22,11 @@ const checkCommitMail = () => {
 		.toLowerCase();
 	const commitMail = process.env.COMMIT_MAIL.trim().toLowerCase();
 	if (currentMail !== commitMail) {
+		// eslint-disable-next-line no-console
 		console.error(
 			`currentMail: ${currentMail} !== initialMail: ${commitMail}`
 		);
+		// eslint-disable-next-line no-console
 		console.error(
 			`Please set your commit user mail for this project like: 'git config user.email "${commitMail}"'`
 		);

tests/backstop_data/engine_scripts/puppet/clickAndHoverHelper.js

@@ -1,14 +1,17 @@
+// eslint-disable-next-line unicorn/prefer-module, unicorn/no-anonymous-default-export
 module.exports = async (page, scenario) => {
 	const hoverSelector = scenario.hoverSelectors || scenario.hoverSelector;
 	const clickSelector = scenario.clickSelectors || scenario.clickSelector;
 	const keyPressSelector =
 		scenario.keyPressSelectors || scenario.keyPressSelector;
-	const scrollToSelector = scenario.scrollToSelector;
-	const postInteractionWait = scenario.postInteractionWait; // selector [str] | ms [int]
+	const {scrollToSelector} = scenario;
+	const {postInteractionWait} = scenario; // Selector [str] | ms [int]
 
 	if (keyPressSelector) {
-		for (const keyPressSelectorItem of [].concat(keyPressSelector)) {
+		for (const keyPressSelectorItem of [keyPressSelector].flat()) {
+			// eslint-disable-next-line no-await-in-loop
 			await page.waitForSelector(keyPressSelectorItem.selector);
+			// eslint-disable-next-line no-await-in-loop
 			await page.type(
 				keyPressSelectorItem.selector,
 				keyPressSelectorItem.keyPress
@@ -17,15 +20,19 @@ module.exports = async (page, scenario) => {
 	}
 
 	if (hoverSelector) {
-		for (const hoverSelectorIndex of [].concat(hoverSelector)) {
+		for (const hoverSelectorIndex of [hoverSelector].flat()) {
+			// eslint-disable-next-line no-await-in-loop
 			await page.waitForSelector(hoverSelectorIndex);
+			// eslint-disable-next-line no-await-in-loop
 			await page.hover(hoverSelectorIndex);
 		}
 	}
 
 	if (clickSelector) {
-		for (const clickSelectorIndex of [].concat(clickSelector)) {
+		for (const clickSelectorIndex of [clickSelector].flat()) {
+			// eslint-disable-next-line no-await-in-loop
 			await page.waitForSelector(clickSelectorIndex);
+			// eslint-disable-next-line no-await-in-loop
 			await page.click(clickSelectorIndex);
 		}
 	}
@@ -37,7 +44,7 @@ module.exports = async (page, scenario) => {
 	if (scrollToSelector) {
 		await page.waitForSelector(scrollToSelector);
 		await page.evaluate((scrollToSelector) => {
-			document.querySelector(scrollToSelector).scrollIntoView();
+			globalThis.querySelector(scrollToSelector).scrollIntoView();
 		}, scrollToSelector);
 	}
 };

xo.config.mjs

@@ -8,7 +8,8 @@ const xoConfig = [
 			'tests/backstop_data/engine_scripts/',
 			'out/**/*',
 			'dist/**/*',
-			'**/*.min.js'
+			'**/*.min.js',
+			'source/_patterns/02-components/dialog/focus-restore.dialog.plugin.js'
 		],
 		prettier: true,
 		rules: {