Skip to content

Commit f9b5199

Browse files
authored
refactor(progress): made those necessary leftover changes (#183)
1 parent 654b475 commit f9b5199

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

docs/migrationGuide.adoc

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,18 @@ As with every release you're recommended to do a visual regression testing for y
44

55
Especially the following aspects have changed through the various different releases and would need your review and probably adaptions within your code base.
66

7+
== DB UI Core 2.2.0 Migration Guide
8+
9+
=== progress element
10+
11+
We've replaced the previous HTML implementation of the label / an actual `label` element by an `output` element. Necessary changes:
12+
13+
- replaced `output` element by `label` element
14+
- especially for screenreader optimization added the following two attributes to this `label` element:
15+
`id="{{ id }}-label" aria-hidden="true"`
16+
- The `id`-attributes value on that `label` element needs to match the following attributes values that needs to get added onto the `progress` HTML tag itself:
17+
`aria-describedby="{{ id }}-label"`
18+
719
== DB UI Core 2.0.0 Migration Guide
820

921
=== Using SCSS/SASS sources

source/_patterns/01-elements/progress/enterprise/_progress.demonstration.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
progress {
3636
--progress-value--backgroundColor: #{$progress-onDarkBackground-value-backgroundColor};
3737

38-
& + output {
38+
& + label {
3939
background-color: $progress-onDarkBackground-conic-inner-backgroundColor; // * TODO: possibly rework variable naming
4040
}
4141
}

0 commit comments

Comments
 (0)