Skip to content

Refactor guidelines 3.0 button style #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 38 commits into from
Closed

Refactor guidelines 3.0 button style #12

wants to merge 38 commits into from

Conversation

@mfranzke
Copy link
Member

@mfranzke mfranzke commented Sep 9, 2022 •
edited
Loading

Closes #11

Backlog

@mfranzke
chore: label correction
3e4e674
@mfranzke
refactor: primary becomes secondary inverted
c91e9ed
@mfranzke
refactor: tertiary plain becomes ghost
36d270c
@mfranzke
refactor: secondary solid becomes tertiary
7728cf4
@mfranzke
refactor: secondary outline becomes secondary
f7b0144
@mfranzke
refactor: brand primary becomes the regular primary button
0c4f69d
@mfranzke
refactor: corrected the order
d89637e
@mfranzke
refactor: the button are all supposed to be styled in bold font-weight
aff7fcb
@mfranzke
chore: we've removed this in total
baf9e15 
mainly because of unsatisfying browser support
@mfranzke
refactor: enabling dark backgrounds for the styleguide
5a6ff02
@mfranzke
chore: adding missing default additions
d0516f5 
for others to be able to overwrite these values
@mfranzke
chore: adapted the correct styles
2d2275e
@mfranzke
refactor: adapted styles
bfb737c
@mfranzke
refactor: adapted the disabled state
7021f79
@mfranzke
refactor: removed those obsolete variants
79b1ee3
@mfranzke
refactor: renaming regular size to medium
85429b1
@mfranzke
refactor: added xsmall size and other size related aspects out of the…
7b6709a 
… new stylings
@mfranzke
docs: reordered
01ea42c
@mfranzke
docs: reordered
5ac4b1a
@mfranzke
refactor: added button width
9202b21
@mfranzke
Merge branch 'main' into refactor-guidelines-3.0-button-style
3382b33
@mfranzke
Merge branch 'main' into refactor-guidelines-3.0-button-style
a6c1514
@mfranzke
docs: added missing SCSS placeholders
cf6288f
@mfranzke
refactor: checked all of the hover and active background-colors again
cd269e1
@mfranzke
refactor: background-color should change on hover hover with a transi…
35c752f 
…tion
@mfranzke mfranzke requested a review from annsch September 9, 2022 08:08
@mfranzke mfranzke requested a review from nmerget as a code owner September 9, 2022 08:08
@mfranzke mfranzke self-assigned this Sep 9, 2022
@mfranzke mfranzke marked this pull request as draft September 9, 2022 08:08
annsch
annsch reviewed Sep 15, 2022
View reviewed changes
@mfranzke mfranzke added this to the Guidelines 3.0 milestone Sep 26, 2022
@mfranzke mfranzke mentioned this pull request Sep 30, 2022
Closed
@mfranzke mfranzke closed this Oct 21, 2022
@mfranzke mfranzke deleted the refactor-guidelines-3.0-button-style branch October 21, 2022 06:57
@mfranzke mfranzke restored the refactor-guidelines-3.0-button-style branch October 21, 2022 07:02
@mfranzke mfranzke deleted the refactor-guidelines-3.0-button-style branch October 21, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annsch annsch annsch left review comments

@nmerget nmerget Awaiting requested review from nmerget nmerget is a code owner

@dkolba dkolba Awaiting requested review from dkolba dkolba will be requested when the pull request is marked ready for review dkolba is a code owner

Assignees

@mfranzke mfranzke

Labels

None yet

Projects

None yet

Milestone

Guidelines v3

Development

Successfully merging this pull request may close these issues.

3 participants

@mfranzke @annsch