Skip to content

Commit 25b25c3

Browse files
nmergetmfranzke
nmerget
and
mfranzke
authored
feat: add improvements for custom-select (#4200)
* feat: add improvements for custom-select; - searchFilter: FN for custom filtering - transformSelectedLabels: FN for custom labels - selectedLabels: fixed custom labels - searchValue: search filter value * chore: update snapshots * Update custom-select.lite.tsx * Update custom-select.lite.tsx --------- Co-authored-by: Maximilian Franzke <[email protected]>
1 parent 5dc2fda commit 25b25c3

File tree

20 files changed

+593
-16
lines changed

20 files changed

+593
-16
lines changed

‎__snapshots__/custom-select/patternhub/custom-select-properties-should-match-screenshot.png

-1.58 KB
Loading

‎__snapshots__/custom-select/showcase/chromium-highContrast/DBCustomSelect-should-match-screenshot-1/DBCustomSelect-should-match-screenshot.png

20.9 KB
Loading

‎__snapshots__/custom-select/showcase/chromium-highContrast/should-have-same-aria-snapshot/DBCustomSelect-should-have-same-aria-snapshot.yaml

Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -920,4 +920,60 @@
920920
- checkbox "Option 4"
921921
- text: Option 4
922922
- status
923+
- text: chevron_down" / "
924+
- 'link "Example: Other configuration arrow_up_right\" / \""'
925+
- text: Search Value
926+
- group:
927+
- article:
928+
- text: magnifying_glass" / " Search
929+
- searchbox "Search": "1"
930+
- status
931+
- text: cross" / "
932+
- group "id-10as4-Search Value":
933+
- list:
934+
- listitem:
935+
- checkbox "Option 1"
936+
- text: Option 1
937+
- status
938+
- text: chevron_down" / " Custom Selected Label
939+
- group:
940+
- text: Label controlled
941+
- article:
942+
- radiogroup "id-10aasds4-Custom Selected Label":
943+
- list:
944+
- listitem:
945+
- radio "Option 1 none\" / \""
946+
- text: Option 1 none" / "
947+
- listitem:
948+
- radio "Option 2 none\" / \""
949+
- text: Option 2 none" / "
950+
- status
951+
- text: chevron_down" / " Transform Selected Label
952+
- group:
953+
- article:
954+
- radiogroup "id-10aasds4-Transform Selected Label":
955+
- list:
956+
- listitem:
957+
- radio "Option 1 none\" / \""
958+
- text: Option 1 none" / "
959+
- listitem:
960+
- radio "Option 2 none\" / \""
961+
- text: Option 2 none" / "
962+
- status
963+
- text: chevron_down" / " Custom Search Filter
964+
- group:
965+
- article:
966+
- text: magnifying_glass" / " Search
967+
- searchbox "Search"
968+
- status
969+
- text: cross" / "
970+
- radiogroup "id-10aasds4-Custom Search Filter":
971+
- list:
972+
- listitem:
973+
- radio "Option 1 none\" / \""
974+
- text: Option 1 none" / "
975+
- listitem:
976+
- radio "Option 2 none\" / \""
977+
- text: Option 2 none" / "
978+
- status
923979
- text: chevron_down" / "

‎__snapshots__/custom-select/showcase/chromium/DBCustomSelect-should-match-screenshot-1/DBCustomSelect-should-match-screenshot.png

26.2 KB
Loading

‎__snapshots__/custom-select/showcase/chromium/should-have-same-aria-snapshot/DBCustomSelect-should-have-same-aria-snapshot.yaml

Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -920,4 +920,60 @@
920920
- checkbox "Option 4"
921921
- text: Option 4
922922
- status
923+
- text: chevron_down" / "
924+
- 'link "Example: Other configuration arrow_up_right\" / \""'
925+
- text: Search Value
926+
- group:
927+
- article:
928+
- text: magnifying_glass" / " Search
929+
- searchbox "Search": "1"
930+
- status
931+
- text: cross" / "
932+
- group "id-10as4-Search Value":
933+
- list:
934+
- listitem:
935+
- checkbox "Option 1"
936+
- text: Option 1
937+
- status
938+
- text: chevron_down" / " Custom Selected Label
939+
- group:
940+
- text: Label controlled
941+
- article:
942+
- radiogroup "id-10aasds4-Custom Selected Label":
943+
- list:
944+
- listitem:
945+
- radio "Option 1 none\" / \""
946+
- text: Option 1 none" / "
947+
- listitem:
948+
- radio "Option 2 none\" / \""
949+
- text: Option 2 none" / "
950+
- status
951+
- text: chevron_down" / " Transform Selected Label
952+
- group:
953+
- article:
954+
- radiogroup "id-10aasds4-Transform Selected Label":
955+
- list:
956+
- listitem:
957+
- radio "Option 1 none\" / \""
958+
- text: Option 1 none" / "
959+
- listitem:
960+
- radio "Option 2 none\" / \""
961+
- text: Option 2 none" / "
962+
- status
963+
- text: chevron_down" / " Custom Search Filter
964+
- group:
965+
- article:
966+
- text: magnifying_glass" / " Search
967+
- searchbox "Search"
968+
- status
969+
- text: cross" / "
970+
- radiogroup "id-10aasds4-Custom Search Filter":
971+
- list:
972+
- listitem:
973+
- radio "Option 1 none\" / \""
974+
- text: Option 1 none" / "
975+
- listitem:
976+
- radio "Option 2 none\" / \""
977+
- text: Option 2 none" / "
978+
- status
923979
- text: chevron_down" / "

‎__snapshots__/custom-select/showcase/firefox/DBCustomSelect-should-match-screenshot-1/DBCustomSelect-should-match-screenshot.png

44.3 KB
Loading

‎__snapshots__/custom-select/showcase/firefox/should-have-same-aria-snapshot/DBCustomSelect-should-have-same-aria-snapshot.yaml

Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -918,4 +918,60 @@
918918
- checkbox "Option 4"
919919
- text: Option 4
920920
- status
921+
- text: chevron_down" / "
922+
- 'link "Example: Other configuration arrow_up_right\" / \""'
923+
- text: Search Value
924+
- group:
925+
- article:
926+
- text: magnifying_glass" / " Search
927+
- searchbox "Search": "1"
928+
- status
929+
- text: cross" / "
930+
- group "id-10as4-Search Value":
931+
- list:
932+
- listitem:
933+
- checkbox "Option 1"
934+
- text: Option 1
935+
- status
936+
- text: chevron_down" / " Custom Selected Label
937+
- group:
938+
- text: Label controlled
939+
- article:
940+
- radiogroup "id-10aasds4-Custom Selected Label":
941+
- list:
942+
- listitem:
943+
- radio "Option 1 none\" / \""
944+
- text: Option 1 none" / "
945+
- listitem:
946+
- radio "Option 2 none\" / \""
947+
- text: Option 2 none" / "
948+
- status
949+
- text: chevron_down" / " Transform Selected Label
950+
- group:
951+
- article:
952+
- radiogroup "id-10aasds4-Transform Selected Label":
953+
- list:
954+
- listitem:
955+
- radio "Option 1 none\" / \""
956+
- text: Option 1 none" / "
957+
- listitem:
958+
- radio "Option 2 none\" / \""
959+
- text: Option 2 none" / "
960+
- status
961+
- text: chevron_down" / " Custom Search Filter
962+
- group:
963+
- article:
964+
- text: magnifying_glass" / " Search
965+
- searchbox "Search"
966+
- status
967+
- text: cross" / "
968+
- radiogroup "id-10aasds4-Custom Search Filter":
969+
- list:
970+
- listitem:
971+
- radio "Option 1 none\" / \""
972+
- text: Option 1 none" / "
973+
- listitem:
974+
- radio "Option 2 none\" / \""
975+
- text: Option 2 none" / "
976+
- status
921977
- text: chevron_down" / "

‎__snapshots__/custom-select/showcase/mobile-chrome/DBCustomSelect-should-match-screenshot-1/DBCustomSelect-should-match-screenshot.png

8.12 KB
Loading

‎__snapshots__/custom-select/showcase/mobile-chrome/should-have-same-aria-snapshot/DBCustomSelect-should-have-same-aria-snapshot.yaml

Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -979,4 +979,64 @@
979979
- text: Option 4
980980
- button "cross\" / \" Close"
981981
- status
982+
- text: chevron_down" / "
983+
- 'link "Example: Other configuration arrow_up_right\" / \""'
984+
- text: Search Value
985+
- group:
986+
- article:
987+
- text: magnifying_glass" / " Search
988+
- searchbox "Search": "1"
989+
- status
990+
- text: cross" / "
991+
- group "id-10as4-Search Value":
992+
- list:
993+
- listitem:
994+
- checkbox "Option 1"
995+
- text: Option 1
996+
- button "cross\" / \" Close"
997+
- status
998+
- text: chevron_down" / " Custom Selected Label
999+
- group:
1000+
- text: Label controlled
1001+
- article:
1002+
- radiogroup "id-10aasds4-Custom Selected Label":
1003+
- list:
1004+
- listitem:
1005+
- radio "Option 1 none\" / \""
1006+
- text: Option 1 none" / "
1007+
- listitem:
1008+
- radio "Option 2 none\" / \""
1009+
- text: Option 2 none" / "
1010+
- button "cross\" / \" Close"
1011+
- status
1012+
- text: chevron_down" / " Transform Selected Label
1013+
- group:
1014+
- article:
1015+
- radiogroup "id-10aasds4-Transform Selected Label":
1016+
- list:
1017+
- listitem:
1018+
- radio "Option 1 none\" / \""
1019+
- text: Option 1 none" / "
1020+
- listitem:
1021+
- radio "Option 2 none\" / \""
1022+
- text: Option 2 none" / "
1023+
- button "cross\" / \" Close"
1024+
- status
1025+
- text: chevron_down" / " Custom Search Filter
1026+
- group:
1027+
- article:
1028+
- text: magnifying_glass" / " Search
1029+
- searchbox "Search"
1030+
- status
1031+
- text: cross" / "
1032+
- radiogroup "id-10aasds4-Custom Search Filter":
1033+
- list:
1034+
- listitem:
1035+
- radio "Option 1 none\" / \""
1036+
- text: Option 1 none" / "
1037+
- listitem:
1038+
- radio "Option 2 none\" / \""
1039+
- text: Option 2 none" / "
1040+
- button "cross\" / \" Close"
1041+
- status
9821042
- text: chevron_down" / "

‎__snapshots__/custom-select/showcase/mobile-safari/DBCustomSelect-should-match-screenshot-1/DBCustomSelect-should-match-screenshot.png

2.13 KB
Loading

0 commit comments

Comments
 (0)