Skip to content

Commit 54839ee

Browse files
michaelmkrausnmergetmfranzke
authored
chore: update configurations (#3993)
* chore(eslint): update parser for eslint-config * chore(prettier): add print- and tabWidth to configuration * chore(yamllint): enhance config with indentation, trailing space, newline EOF, ignore node_modules * chore(np-config): add branch to config * chore(xo-config): ignore stylelint folder, remove override for svelte-showcase * docs(readme): improve README grammar, consistency, and formatting * docs(contributing): improve CONTRIBUTING grammar and clarity * docs(contributing): readd direct link to opan an issue * docs(readme): set copyright year to 2024 * chore(lint-staged): add prettier for JSON and markdown files * chore(lint-staged): remove prettier - this is done in separated file * docs(pr-template): update wording * docs(bug-template): improve grammar and wording * chore(adr): move icons adr to adr-folder * docs: improve docs wording for clarity and consistency * chore(labeler): add configuration label for .config folder changes * Update package.json Co-authored-by: Maximilian Franzke <[email protected]> * chore: update from main * chore: run fmt * chore: run fmt --------- Co-authored-by: Nicolas Merget <[email protected]> Co-authored-by: Maximilian Franzke <[email protected]> Co-authored-by: Nicolas Merget <[email protected]>
1 parent fc62793 commit 54839ee

File tree

31 files changed

+153
-131
lines changed

31 files changed

+153
-131
lines changed

.github/ISSUE_TEMPLATE/bug_report.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ body:
77
- type: markdown
88
attributes:
99
value: |
10-
Thanks for taking the time to fill out this bug report! Feedback by the community has a very high value for us, to improve our work and to have every other user benefit from it as well. 🙂
10+
Thank you for taking the time to fill out this bug report! Feedback from the community is highly valuable to us, as it helps improve our work and benefits all users. 🙂
1111
1212
- type: checkboxes
1313
id: component
1414
attributes:
15-
label: Which generators are impacted?
15+
label: Which generators are affected?
1616
description: Select all the ones that apply, to the best of your knowledge.
1717
options:
1818
- label: All
@@ -51,7 +51,7 @@ body:
5151
required: false
5252
attributes:
5353
label: Browser version
54-
description: Does this bug affect specific browser?
54+
description: Does this bug affect a specific browser?
5555
options:
5656
- Chrome
5757
- Safari

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
<!-- What types of changes does your code introduce?
88
_Put an `x` in the boxes that apply_ -->
99

10-
- [ ] Bugfix (non-breaking change which fixes an issue)
10+
- [ ] Bugfix (non-breaking change that fixes an issue)
1111
- [ ] New feature (non-breaking change which adds functionality)
12-
- [ ] Refactoring (fix on existing components or architectural decisions)
12+
- [ ] Refactoring (improvements to existing components or architectural decisions)
1313
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
1414
- [ ] Documentation Update (if none of the other choices apply)
1515

.github/labeler.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,8 @@
2323
📺showcases:
2424
- changed-files:
2525
- any-glob-to-any-file: "showcases/**"
26+
27+
# Add 'configuration' label to any file changes for configuration files
28+
🛠️configuration:
29+
- changed-files:
30+
- any-glob-to-any-file: ".config/**"

.np-config.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
22
"yarn": false,
3-
"publish": false
3+
"publish": false,
4+
"branch": "main"
45
}

.yamllint.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,16 @@ rules:
1010
allow-non-breakable-inline-mappings: true
1111
document-start:
1212
present: false
13+
document-end:
14+
present: false
1315
comments:
1416
min-spaces-from-content: 1
17+
indentation:
18+
spaces: 2
19+
trailing-spaces:
20+
level: error
21+
new-line-at-end-of-file:
22+
present: true
1523
ignore: |
1624
.git/
25+
node_modules/

CONTRIBUTING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# Contributing
22

3-
Thanks for your interest in our project. Contributions are welcome. Feel free to [open an issue](https://github.com/db-ux-design-system/core-web/issues/new) with questions or reporting ideas and bugs, or [open pull requests](https://github.com/db-ux-design-system/core-web/compare) to contribute code.
3+
**Thank you for your interest in our project.** Contributions are always welcome. **Feel free to [open an issue](https://github.com/db-ux-design-system/core-web/issues/new) if you have any questions, ideas, or bugs to report, or submit pull requests to contribute code.**
44

5-
We are committed to fostering a welcoming, respectful, and harassment-free environment. Be kind!
5+
We are committed to fostering a welcoming, respectful, and harassment-free environment, **so please be kind! 💖**
66

77
## Prepare
88

@@ -28,12 +28,12 @@ npm run dev
2828

2929
## Make changes / Before you commit
3030

31-
Please make sure that husky is installed correctly to validate your changes.
31+
Please ensure that **Husky** is installed correctly to validate your changes.
3232

3333
Please verify you are using a valid branch name as described by the pattern in your [`package.json`](./package.json) in the section `validate-branch-name`.
3434

3535
Moreover, you need to duplicate [`.env.template`](./.env.template) as [`.env`](./.env) and type your own email address. This ensures that you have the correct email set for this project.
3636

3737
### Conventions
3838

39-
Please be aware that we have some [code and git commit (message and branch naming) conventions](docs/conventions.md), that we ensure with some linting tools.
39+
Please note that we have established [code and git commit (message and branch naming) conventions](docs/conventions.md), which are enforced using various linting tools.

README.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
[![Contributor Covenant](https://img.shields.io/badge/Contributor%20Covenant-2.0-4baaaa.svg)](CODE-OF-CONDUCT.md)
1515

1616
DB UX Design System v3 provides robust HTML UI components, reusable visual styles, and powerful tooling to help developers,
17-
designers, and content authors build, maintain, and scale best of class digital experiences.
17+
designers, and content authors build, maintain, and scale best-of-class digital experiences.
1818

1919
<figure>
2020
<cite>We’re not designing pages anymore. We’re designing systems of components.</cite>
@@ -36,8 +36,8 @@ designers, and content authors build, maintain, and scale best of class digital
3636

3737
Install your preferred package via npm or yarn e.g. `npm i @db-ux/react-core-components`.
3838

39-
Afterwards you need to add the specific CSS or SCSS files to provide the styles of DB UX Design System (Version 3), as described in the "Styling Dependencies" of each packages `README`.
40-
We even also provide some [examples of integrations](https://github.com/db-ux-design-system/examples).
39+
Afterwards, you need to include the specific CSS or SCSS files to apply the styles of DB UX Design System (Version 3), as described in the "Styling Dependencies" section of each package's `README`.
40+
We even provide some [examples of integrations](https://github.com/db-ux-design-system/examples).
4141

4242
### DB Theme
4343

@@ -47,7 +47,7 @@ In case that you're building a website or application for Deutsche Bahn, you'll
4747

4848
We maintain a [status overview](https://github.com/orgs/db-ux-design-system/projects/4/views/1) for all components.
4949

50-
## Core principals
50+
## Core principles
5151

5252
<details>
5353
<summary><strong>
@@ -117,7 +117,7 @@ This is mainly a platform providing the space and technology for a common basis
117117
is mainly driven by the community and adapted out of the work done in projects and through the huge amount of feedback
118118
that we're gaining out of the community. So please support us in any way possible, this is greatly appreciated!
119119

120-
## How to start develop / contribute
120+
## How to start developing / contributing
121121

122122
If you're working as a developer on the DB UX Design System or would like to contribute (many kudos for that !), please have a look at the relevant [development documentation](docs/development.md). We even also tag issues that might be a good starter for code contributions by the [tag "good first issue"](https://github.com/db-ux-design-system/core-web/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22good%20first%20issue%22).
123123

@@ -137,12 +137,12 @@ We're particularly keen to add as many examples to the behaviours as possible, t
137137

138138
## Deutsche Bahn brand
139139

140-
As we'd like to perfectly support our users and customers on their digital journey, the usage of Deutsche Bahn brand and
141-
trademarks are bound to clear guidelines and restrictions even when being used with the code that we're providing with
142-
this product; Deutsche Bahn fully reserves all rights and ownership regarding the Deutsche Bahn brand, even though that
143-
we're providing the code of DB UX Design System products free to use and release it under the Apache 2.0 license.
144-
Please have a look at our brand portal at <https://marketingportal.extranet.deutschebahn.com/> for any further questions
145-
and whom to contact on any brand issues. As these assets and visual guidelines are retrieved from our Deutsche Bahn
140+
To perfectly support our users and customers on their digital journey, the use of the Deutsche Bahn brand and trademarks is subject
141+
to clear guidelines and restrictions even when used with the code provided by this product. Deutsche Bahn fully reserves all
142+
rights and ownership regarding the Deutsche Bahn brand, even though we provide the code for DB UX Design System products free of
143+
charge under the Apache 2.0 license.
144+
Please refer to our brand portal at <https://marketingportal.extranet.deutschebahn.com/> for further questions
145+
contact details regarding brand issues. As these assets and visual guidelines are retrieved from our Deutsche Bahn
146146
Marketingportal, you'll agree with
147147
the ["Allgemeine Nutzungsbedingungen für das DB-Marketingportal" (german)](https://marketingportal.extranet.deutschebahn.com/marketingportal/Nutzungsbedingungen-9702684#)
148148
in case of using them.
@@ -162,4 +162,4 @@ our [Contributor Covenant Code of Conduct](https://github.com/db-ux-design-syste
162162

163163
## License
164164

165-
This project is licensed under [Apache-2.0](LICENSE), Copyright 2024 by DB Systel GmbH.
165+
This project is licensed under the [Apache-2.0](LICENSE) license. © 2024 DB Systel GmbH.
File renamed without changes.

docs/conventions.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ The [xo](https://github.com/db-ui/core/blob/main/docs/adr/linting-xo.adoc) tool
5050

5151
- [yamllint.readthedocs.io](https://yamllint.readthedocs.io/)
5252

53+
The [prettier](https://github.com/db-ui/core/blob/main/docs/adr/code_style_formatter-prettier.adoc) tool provides a general code prettifying.
54+
5355
### markdown files via markdownlint
5456

5557
- [github.com/markdownlint/markdownlint](https://github.com/markdownlint/markdownlint/)

docs/definition-of-done-pr.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22

33
## General
44

5-
- Depending on necessary code changes for consuming packages you'll probably need to add a new file or add entries to the next release within [`/docs/migration`](https://github.com/db-ux-design-system/core-web/tree/main/docs/migration) folder.
6-
- Please have a final lookup of all of your changes e.g. within the "Files changed" tab of the PR within GitHub. This final check could lead to some findings on outstanding work, missing TODOs, `console.log` leftovers or whatever.
5+
- Depending on the necessary code changes for consuming packages, you may need to add a new file or include entries for the next release in the [`/docs/migration`](https://github.com/db-ux-design-system/core-web/tree/main/docs/migration) folder.
6+
- Please perform a final lookup of all of your changes, for example by checking the "Files changed" tab of your pull request on GitHub. This final review might lead to some findings on outstanding work, missing TODOs, `console.log` leftovers or other issues.

0 commit comments

Comments
 (0)