You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* chore(eslint): update parser for eslint-config
* chore(prettier): add print- and tabWidth to configuration
* chore(yamllint): enhance config with indentation, trailing space, newline EOF, ignore node_modules
* chore(np-config): add branch to config
* chore(xo-config): ignore stylelint folder, remove override for svelte-showcase
* docs(readme): improve README grammar, consistency, and formatting
* docs(contributing): improve CONTRIBUTING grammar and clarity
* docs(contributing): readd direct link to opan an issue
* docs(readme): set copyright year to 2024
* chore(lint-staged): add prettier for JSON and markdown files
* chore(lint-staged): remove prettier - this is done in separated file
* docs(pr-template): update wording
* docs(bug-template): improve grammar and wording
* chore(adr): move icons adr to adr-folder
* docs: improve docs wording for clarity and consistency
* chore(labeler): add configuration label for .config folder changes
* Update package.json
Co-authored-by: Maximilian Franzke <[email protected]>
* chore: update from main
* chore: run fmt
* chore: run fmt
---------
Co-authored-by: Nicolas Merget <[email protected]>
Co-authored-by: Maximilian Franzke <[email protected]>
Co-authored-by: Nicolas Merget <[email protected]>
Copy file name to clipboardExpand all lines: .github/ISSUE_TEMPLATE/bug_report.yaml
+3-3Lines changed: 3 additions & 3 deletions
Original file line number
Diff line number
Diff line change
@@ -7,12 +7,12 @@ body:
7
7
- type: markdown
8
8
attributes:
9
9
value: |
10
-
Thanks for taking the time to fill out this bug report! Feedback by the community has a very high value for us, to improve our work and to have every other user benefit from it as well. 🙂
10
+
Thank you for taking the time to fill out this bug report! Feedback from the community is highly valuable to us, as it helps improve our work and benefits all users. 🙂
11
11
12
12
- type: checkboxes
13
13
id: component
14
14
attributes:
15
-
label: Which generators are impacted?
15
+
label: Which generators are affected?
16
16
description: Select all the ones that apply, to the best of your knowledge.
17
17
options:
18
18
- label: All
@@ -51,7 +51,7 @@ body:
51
51
required: false
52
52
attributes:
53
53
label: Browser version
54
-
description: Does this bug affect specific browser?
54
+
description: Does this bug affect a specific browser?
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+4-4Lines changed: 4 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,8 +1,8 @@
1
1
# Contributing
2
2
3
-
Thanks for your interest in our project. Contributions are welcome. Feel free to [open an issue](https://github.com/db-ux-design-system/core-web/issues/new)with questions or reporting ideas and bugs, or [open pull requests](https://github.com/db-ux-design-system/core-web/compare) to contribute code.
3
+
**Thank you for your interest in our project.** Contributions are always welcome. **Feel free to [open an issue](https://github.com/db-ux-design-system/core-web/issues/new)if you have any questions, ideas, or bugs to report, or submit pull requests to contribute code.**
4
4
5
-
We are committed to fostering a welcoming, respectful, and harassment-free environment. Be kind!
5
+
We are committed to fostering a welcoming, respectful, and harassment-free environment, **so please be kind! 💖**
6
6
7
7
## Prepare
8
8
@@ -28,12 +28,12 @@ npm run dev
28
28
29
29
## Make changes / Before you commit
30
30
31
-
Please make sure that husky is installed correctly to validate your changes.
31
+
Please ensure that **Husky** is installed correctly to validate your changes.
32
32
33
33
Please verify you are using a valid branch name as described by the pattern in your [`package.json`](./package.json) in the section `validate-branch-name`.
34
34
35
35
Moreover, you need to duplicate [`.env.template`](./.env.template) as [`.env`](./.env) and type your own email address. This ensures that you have the correct email set for this project.
36
36
37
37
### Conventions
38
38
39
-
Please be aware that we have some[code and git commit (message and branch naming) conventions](docs/conventions.md), that we ensure with some linting tools.
39
+
Please note that we have established[code and git commit (message and branch naming) conventions](docs/conventions.md), which are enforced using various linting tools.
DB UX Design System v3 provides robust HTML UI components, reusable visual styles, and powerful tooling to help developers,
17
-
designers, and content authors build, maintain, and scale best of class digital experiences.
17
+
designers, and content authors build, maintain, and scale best-of-class digital experiences.
18
18
19
19
<figure>
20
20
<cite>We’re not designing pages anymore. We’re designing systems of components.</cite>
@@ -36,8 +36,8 @@ designers, and content authors build, maintain, and scale best of class digital
36
36
37
37
Install your preferred package via npm or yarn e.g. `npm i @db-ux/react-core-components`.
38
38
39
-
Afterwards you need to add the specific CSS or SCSS files to provide the styles of DB UX Design System (Version 3), as described in the "Styling Dependencies" of each packages`README`.
40
-
We even also provide some [examples of integrations](https://github.com/db-ux-design-system/examples).
39
+
Afterwards, you need to include the specific CSS or SCSS files to apply the styles of DB UX Design System (Version 3), as described in the "Styling Dependencies" section of each package's`README`.
40
+
We even provide some [examples of integrations](https://github.com/db-ux-design-system/examples).
41
41
42
42
### DB Theme
43
43
@@ -47,7 +47,7 @@ In case that you're building a website or application for Deutsche Bahn, you'll
47
47
48
48
We maintain a [status overview](https://github.com/orgs/db-ux-design-system/projects/4/views/1) for all components.
49
49
50
-
## Core principals
50
+
## Core principles
51
51
52
52
<details>
53
53
<summary><strong>
@@ -117,7 +117,7 @@ This is mainly a platform providing the space and technology for a common basis
117
117
is mainly driven by the community and adapted out of the work done in projects and through the huge amount of feedback
118
118
that we're gaining out of the community. So please support us in any way possible, this is greatly appreciated!
119
119
120
-
## How to start develop / contribute
120
+
## How to start developing / contributing
121
121
122
122
If you're working as a developer on the DB UX Design System or would like to contribute (many kudos for that !), please have a look at the relevant [development documentation](docs/development.md). We even also tag issues that might be a good starter for code contributions by the [tag "good first issue"](https://github.com/db-ux-design-system/core-web/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22good%20first%20issue%22).
123
123
@@ -137,12 +137,12 @@ We're particularly keen to add as many examples to the behaviours as possible, t
137
137
138
138
## Deutsche Bahn brand
139
139
140
-
As we'd like to perfectly support our users and customers on their digital journey, the usage of Deutsche Bahn brand and
141
-
trademarks are bound to clear guidelines and restrictions even when being used with the code that we're providing with
142
-
this product; Deutsche Bahn fully reserves all rights and ownership regarding the Deutsche Bahn brand, even though that
143
-
we're providing the code of DB UX Design System products free to use and release it under the Apache 2.0 license.
144
-
Please have a look at our brand portal at <https://marketingportal.extranet.deutschebahn.com/> for any further questions
145
-
and whom to contact on any brand issues. As these assets and visual guidelines are retrieved from our Deutsche Bahn
140
+
To perfectly support our users and customers on their digital journey, the use of the Deutsche Bahn brand and trademarks is subject
141
+
to clear guidelines and restrictions even when used with the code provided by this product. Deutsche Bahn fully reserves all
142
+
rights and ownership regarding the Deutsche Bahn brand, even though we provide the code for DB UX Design System products free of
143
+
charge under the Apache 2.0 license.
144
+
Please refer to our brand portal at <https://marketingportal.extranet.deutschebahn.com/> for further questions
145
+
contact details regarding brand issues. As these assets and visual guidelines are retrieved from our Deutsche Bahn
146
146
Marketingportal, you'll agree with
147
147
the ["Allgemeine Nutzungsbedingungen für das DB-Marketingportal" (german)](https://marketingportal.extranet.deutschebahn.com/marketingportal/Nutzungsbedingungen-9702684#)
148
148
in case of using them.
@@ -162,4 +162,4 @@ our [Contributor Covenant Code of Conduct](https://github.com/db-ux-design-syste
162
162
163
163
## License
164
164
165
-
This project is licensed under [Apache-2.0](LICENSE), Copyright 2024 by DB Systel GmbH.
Copy file name to clipboardExpand all lines: docs/definition-of-done-pr.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -2,5 +2,5 @@
2
2
3
3
## General
4
4
5
-
- Depending on necessary code changes for consuming packages you'll probably need to add a new file or add entries to the next release within[`/docs/migration`](https://github.com/db-ux-design-system/core-web/tree/main/docs/migration) folder.
6
-
- Please have a final lookup of all of your changes e.g. within the "Files changed" tab of the PR within GitHub. This final check could lead to some findings on outstanding work, missing TODOs, `console.log` leftovers or whatever.
5
+
- Depending on the necessary code changes for consuming packages, you may need to add a new file or include entries for the next release in the[`/docs/migration`](https://github.com/db-ux-design-system/core-web/tree/main/docs/migration) folder.
6
+
- Please perform a final lookup of all of your changes, for example by checking the "Files changed" tab of your pull request on GitHub. This final review might lead to some findings on outstanding work, missing TODOs, `console.log` leftovers or other issues.
0 commit comments