Skip to content

Commit 888e2b3

Browse files
authored
fix: auto close for sub-navigation click (#4522)
1 parent 851b490 commit 888e2b3

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

packages/components/src/components/navigation-item/navigation-item.lite.tsx

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,7 @@ import {
1818
getHideProp,
1919
uuid
2020
} from '../../utils';
21-
import {
22-
isEventTargetNavigationItem,
23-
NavigationItemSafeTriangle
24-
} from '../../utils/navigation';
21+
import { NavigationItemSafeTriangle } from '../../utils/navigation';
2522
import DBButton from '../button/button.lite';
2623
import { DBNavigationItemProps, DBNavigationItemState } from './model';
2724

@@ -41,12 +38,12 @@ export default function DBNavigationItem(props: DBNavigationItemProps) {
4138
autoClose: false,
4239
subNavigationId: 'sub-navigation-' + uuid(),
4340
navigationItemSafeTriangle: undefined,
44-
handleNavigationItemClick: (event: unknown) => {
45-
if (isEventTargetNavigationItem(event)) {
41+
handleNavigationItemClick: (event: any) => {
42+
if (event?.target?.nodeName === 'A') {
4643
state.autoClose = true;
47-
delay(() => {
44+
void delay(() => {
4845
state.autoClose = false;
49-
}, 300);
46+
}, 1000);
5047
}
5148
},
5249
handleClick: (event: ClickEvent<HTMLButtonElement> | any) => {
@@ -142,7 +139,7 @@ export default function DBNavigationItem(props: DBNavigationItemProps) {
142139
{/* TODO: Consider using popover here */}
143140
<menu
144141
class="db-sub-navigation"
145-
data-auto-close={state.autoClose}
142+
data-force-close={state.autoClose}
146143
id={state.subNavigationId}
147144
onClick={(event) => state.handleNavigationItemClick(event)}>
148145
<Show when={state.hasAreaPopup}>

packages/components/src/shared/model.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ export type PlacementProps = {
130130
};
131131

132132
export type NavigationBehaviorState = {
133-
handleNavigationItemClick: (event: unknown) => void;
133+
handleNavigationItemClick: (event: any) => void;
134134
};
135135

136136
export type GapProps = {

0 commit comments

Comments
 (0)