Skip to content

Commit 93fe541

Browse files
fix: enable multiline for navigation-items links but not buttons (#4065)
* fix: enable multiline for navigation-items that are links and not buttons * fix: adapted angular and vue showcases * test: updated snapshots * test: updated snapshots * fix: adapted react showcases * test: updated snapshots * test: updated snapshots * chore: update snapshots --------- Co-authored-by: Nicolas Merget <[email protected]> Co-authored-by: Nicolas Merget <[email protected]>
1 parent 0903682 commit 93fe541

File tree

6 files changed

+24
-20
lines changed

6 files changed

+24
-20
lines changed
-302 Bytes
Loading

__snapshots__/header/showcase/mobile-chrome/should-have-same-aria-snapshot/DBHeader-should-have-same-aria-snapshot.yaml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@
3030
- link "Examples arrow_up_right\" / \""
3131
- text: brand" / " DBHeader
3232
- button "menu\" / \" BurgerMenu"
33-
- text: brand" / " DBHeader
34-
- button "menu\" / \" BurgerMenu"
35-
- text: brand" / "
33+
- text: brand" / " DBHeader brand" / "
3634
- button "menu\" / \" BurgerMenu"
37-
- text: brand" / "
38-
- button "menu\" / \" BurgerMenu"
35+
- text: brand" / "

__snapshots__/header/showcase/mobile-safari/should-have-same-aria-snapshot/DBHeader-should-have-same-aria-snapshot.yaml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@
3030
- link "Examples arrow_up_right\" / \""
3131
- text: brand" / " DBHeader
3232
- button "menu\" / \" BurgerMenu"
33-
- text: brand" / " DBHeader
34-
- button "menu\" / \" BurgerMenu"
35-
- text: brand" / "
33+
- text: brand" / " DBHeader brand" / "
3634
- button "menu\" / \" BurgerMenu"
37-
- text: brand" / "
38-
- button "menu\" / \" BurgerMenu"
35+
- text: brand" / "

packages/components/src/components/header/header.scss

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,19 @@
5252
display: none;
5353
}
5454
}
55+
56+
// Hide the burger menu if there is no navigation
57+
&:has(.db-header-navigation:empty) {
58+
.db-header-burger-menu-container {
59+
display: none;
60+
}
61+
62+
&:has(.db-header-secondary-action:empty) {
63+
.db-header-action-container::before {
64+
display: none;
65+
}
66+
}
67+
}
5568
}
5669

5770
.db-header-navigation-bar {

packages/foundations/docs/BrowserSupport.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ We're [testing our components with playwright](../../foundations/test-table) on
44

55
This may leave some older browser versions behind. If you need to take care of these older browsers, you may not want to migrate to DB UX Design System v3 right now, but stay with DB UI Core or Elements for a little longer. In particular, the following features we use may be related to an evaluation of your browser strategy:
66

7-
| Web Feature | Google Chrome | Mozilla Firefox | Apple Safari |
8-
| ------------------------------------------------------------------------------------------------------------------------------- | ---------------- | ---------------- | ----------------- |
9-
| [`@property` / typed CSS Custom Properties](https://developer.mozilla.org/en-US/docs/Web/CSS/@property) | 85 (25.08.2022) | 128 (09.07.2024) | 16.4 (27.03.2023) |
10-
| [`light-dark()`](https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/light-dark) | 123 (19.03.2024) | 120 (21.11.2023) | 17.5 (13.05.2024) |
7+
| Web Feature | Google Chrome | Mozilla Firefox | Apple Safari |
8+
| ------------------------------------------------------------------------------------------------------- | ---------------- | ---------------- | ----------------- |
9+
| [`@property` / typed CSS Custom Properties](https://developer.mozilla.org/en-US/docs/Web/CSS/@property) | 85 (25.08.2022) | 128 (09.07.2024) | 16.4 (27.03.2023) |
10+
| [`light-dark()`](https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/light-dark) | 123 (19.03.2024) | 120 (21.11.2023) | 17.5 (13.05.2024) |

packages/foundations/scss/defaults/_default-variables.scss

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -347,14 +347,11 @@
347347
--db-border-radius-3xl: 2rem;
348348
--db-border-radius-full: 500rem;
349349
--db-elevation-sm:
350-
0 0 1px -1px #0003, 0 0 4px 1px #0000001f,
351-
0 0 2px #00000024;
350+
0 0 1px -1px #0003, 0 0 4px 1px #0000001f, 0 0 2px #00000024;
352351
--db-elevation-md:
353-
0 0 2px -1px #0003, 0 0 8px 1px #0000001f,
354-
0 0 4px #00000024;
352+
0 0 2px -1px #0003, 0 0 8px 1px #0000001f, 0 0 4px #00000024;
355353
--db-elevation-lg:
356-
0 0 4px -3px #0003, 0 0 16px 3px #0000001f,
357-
0 0 8px 1px #00000024;
354+
0 0 4px -3px #0003, 0 0 16px 3px #0000001f, 0 0 8px 1px #00000024;
358355
--db-font-family-sans: "OpenSans", helvetica, arial, sans-serif;
359356
--db-font-family-head: "OpenSans Head", helvetica, arial, sans-serif;
360357
--db-sizing-fixed-mobile-header: 3.5rem;

0 commit comments

Comments
 (0)