fix CommonJs modules no longer affecting the global scope (microsoft#43090)

sokra · web-flow · commit 8a5939fdae6c · 2021-03-19T16:24:17.000-07:00
diff --git a/src/compiler/builderState.ts b/src/compiler/builderState.ts
@@ -472,7 +472,7 @@ namespace ts {
          */
         function isFileAffectingGlobalScope(sourceFile: SourceFile) {
             return containsGlobalScopeAugmentation(sourceFile) ||
-                !isExternalModule(sourceFile) && !containsOnlyAmbientModules(sourceFile);
+                !isExternalOrCommonJsModule(sourceFile) && !containsOnlyAmbientModules(sourceFile);
         }
 
         /**
diff --git a/tests/baselines/reference/tsbuild/javascriptProjectEmit/initial-build/loads-js-based-projects-and-emits-them-correctly.js b/tests/baselines/reference/tsbuild/javascriptProjectEmit/initial-build/loads-js-based-projects-and-emits-them-correctly.js
@@ -151,7 +151,7 @@ module.exports = {};
       "../../src/common/nominal.js": {
         "version": "-9003723607-/**\n * @template T, Name\n * @typedef {T & {[Symbol.species]: Name}} Nominal\n */\nmodule.exports = {};\n",
         "signature": "-15964609857-export type Nominal<T, Name> = T & {\r\n    [Symbol.species]: Name;\r\n};\r\n",
-        "affectsGlobalScope": true
+        "affectsGlobalScope": false
       }
     },
     "options": {

Original file line number	Diff line number	Diff line change
`@@ -472,7 +472,7 @@ namespace ts {`
`472`	`472`	`*/`
`473`	`473`	`function isFileAffectingGlobalScope(sourceFile: SourceFile) {`
`474`	`474`	`return containsGlobalScopeAugmentation(sourceFile) \|\|`
`475`		`- !isExternalModule(sourceFile) && !containsOnlyAmbientModules(sourceFile);`
	`475`	`+ !isExternalOrCommonJsModule(sourceFile) && !containsOnlyAmbientModules(sourceFile);`
`476`	`476`	`}`
`477`	`477`
`478`	`478`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ module.exports = {};`
`151`	`151`	`"../../src/common/nominal.js": {`
`152`	`152`	`"version": "-9003723607-/*\n @template T, Name\n * @typedef {T & {[Symbol.species]: Name}} Nominal\n */\nmodule.exports = {};\n",`
`153`	`153`	`"signature": "-15964609857-export type Nominal<T, Name> = T & {\r\n [Symbol.species]: Name;\r\n};\r\n",`
`154`		`- "affectsGlobalScope": true`
	`154`	`+ "affectsGlobalScope": false`
`155`	`155`	`}`
`156`	`156`	`},`
`157`	`157`	`"options": {`