set cmake minimum version to 3.14. Fix issues found in tested with the min version

Author: dbarker

CMakeLists.txt

@@ -1,23 +1,7 @@
 # Copyright The OpenTelemetry Authors
 # SPDX-License-Identifier: Apache-2.0
 
-cmake_minimum_required(VERSION 3.10)
-
-# See https://cmake.org/cmake/help/latest/policy/CMP0074.html required by
-# certain version of zlib which CURL depends on.
-if(${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.12")
-  cmake_policy(SET CMP0074 NEW)
-endif()
-
-# Allow to use normal variable for option()
-if(${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.13")
-  cmake_policy(SET CMP0077 NEW)
-endif()
-
-# Prefer CMAKE_MSVC_RUNTIME_LIBRARY if possible
-if(POLICY CMP0091)
-  cmake_policy(SET CMP0091 NEW)
-endif()
+cmake_minimum_required(VERSION 3.14)
 
 if(POLICY CMP0092)
   # https://cmake.org/cmake/help/latest/policy/CMP0092.html#policy:CMP0092 Make
@@ -36,8 +20,10 @@ project(opentelemetry-cpp)
 # Mark variables as used so cmake doesn't complain about them
 mark_as_advanced(CMAKE_TOOLCHAIN_FILE)
 
-# Prefer cmake CONFIG to auto resolve dependencies. This is important to
-# properly find protobuf versions 3.22.0 and above
+# Note: CMAKE_FIND_PACKAGE_PREFER_CONFIG requires cmake 3.15 
+#   Prefer cmake CONFIG to auto resolve dependencies. 
+#   This is important to properly find protobuf versions
+#   3.22.0 and above due to the abseil-cpp dependency.
 set(CMAKE_FIND_PACKAGE_PREFER_CONFIG TRUE)
 
 # Don't use customized cmake modules if vcpkg is used to resolve dependence.
@@ -420,9 +406,18 @@ if(WITH_OTLP_GRPC
    OR WITH_OTLP_HTTP
    OR WITH_OTLP_FILE)
 
-  find_package(Protobuf)
-  # Protobuf 3.22 or upper require abseil-cpp, we can find it in
-  # opentelemetry-cpp-config.cmake
+  # Note: remove once cmake 3.14 is no longer supported
+  #  including the CMakeFindDependencyMacro is required with cmake 3.14 
+  #  due to an issue with the gRPCConfig.cmake file. 
+  include(CMakeFindDependencyMacro)
+
+  # Protobuf 3.22 and up requires abseil-cpp. This is found using the 
+  #   CONFIG search mode. In cmake 3.14 we must manually 
+  #   try config mode first then fall back to MODULE mode
+  find_package(Protobuf CONFIG)
+  if(NOT Protobuf_FOUND AND NOT PROTOBUF_FOUND)
+    find_package(Protobuf MODULE)
+  endif() 
 
   if(WITH_OTLP_GRPC)
     find_package(gRPC CONFIG)
@@ -441,7 +436,7 @@ if(WITH_OTLP_GRPC
     endif()
 
     if(NOT Protobuf_FOUND AND NOT PROTOBUF_FOUND)
-      find_package(Protobuf REQUIRED)
+      find_package(Protobuf CONFIG REQUIRED)
     endif()
     if(NOT gRPC_FOUND AND WITH_OTLP_GRPC)
       find_package(gRPC CONFIG)
@@ -800,10 +795,10 @@ if(gRPC_FOUND)
   message(STATUS "gRPC: ${gRPC_VERSION}")
 endif()
 if(CURL_FOUND)
-  message(STATUS "CURL: ${CURL_VERSION}")
+  message(STATUS "CURL: ${CURL_VERSION_STRING}")
 endif()
 if(ZLIB_FOUND)
-  message(STATUS "ZLIB: ${ZLIB_VERSION}")
+  message(STATUS "ZLIB: ${ZLIB_VERSION_STRING}")
 endif()
 if(USE_NLOHMANN_JSON)
   message(STATUS "nlohmann-json: ${nlohmann_json_VERSION}")

ci/do_ci.ps1

@@ -388,6 +388,8 @@ switch ($action) {
       -DWITH_ELASTICSEARCH=ON `
       -DWITH_ETW=ON `
       -DWITH_EXAMPLES=ON `
+      -DWITH_EXAMPLES_HTTP=ON `
+      -DBUILD_W3CTRACECONTEXT_TEST=ON `
       -DOPENTELEMETRY_INSTALL=ON
 
     $exit = $LASTEXITCODE
@@ -435,19 +437,21 @@ switch ($action) {
     )
     $EXPECTED_COMPONENTS_STRING = $EXPECTED_COMPONENTS -join ";"
 
-    cmake -S "$SRC_DIR\install\test\cmake" `
-          -B "$BUILD_DIR\install_test" `
-          $CMAKE_OPTIONS `
+    mkdir "$BUILD_DIR\install_test"
+    cd "$BUILD_DIR\install_test"
+
+    cmake $CMAKE_OPTIONS `
           "-DCMAKE_PREFIX_PATH=$INSTALL_TEST_DIR" `
           "-DINSTALL_TEST_CMAKE_OPTIONS=$CMAKE_OPTIONS_STRING" `
-          "-DINSTALL_TEST_COMPONENTS=$EXPECTED_COMPONENTS_STRING" 
+          "-DINSTALL_TEST_COMPONENTS=$EXPECTED_COMPONENTS_STRING" `
+          -S "$SRC_DIR\install\test\cmake"
 
     $exit = $LASTEXITCODE
     if ($exit -ne 0) {
       exit $exit
     }
 
-    ctest -C Debug --test-dir "$BUILD_DIR\install_test" --output-on-failure
+    ctest -C Debug --output-on-failure
     $exit = $LASTEXITCODE
     if ($exit -ne 0) {
       exit $exit
@@ -528,20 +532,22 @@ switch ($action) {
       "ext_dll" 
     )
     $EXPECTED_COMPONENTS_STRING = $EXPECTED_COMPONENTS -join ";"
-   
-    cmake -S "$SRC_DIR\install\test\cmake" `
-          -B "$BUILD_DIR\install_test" `
-          $CMAKE_OPTIONS `
+
+    mkdir "$BUILD_DIR\install_test"
+    cd "$BUILD_DIR\install_test"
+
+    cmake $CMAKE_OPTIONS `
           "-DCMAKE_PREFIX_PATH=$INSTALL_TEST_DIR" `
           "-DINSTALL_TEST_CMAKE_OPTIONS=$CMAKE_OPTIONS_STRING" `
-          "-DINSTALL_TEST_COMPONENTS=$EXPECTED_COMPONENTS_STRING"
+          "-DINSTALL_TEST_COMPONENTS=$EXPECTED_COMPONENTS_STRING" `
+          -S "$SRC_DIR\install\test\cmake"
 
     $exit = $LASTEXITCODE
     if ($exit -ne 0) {
       exit $exit
     }
 
-    ctest -C Debug --test-dir "$BUILD_DIR\install_test" --output-on-failure
+    ctest -C Debug --output-on-failure
     $exit = $LASTEXITCODE
     if ($exit -ne 0) {
       exit $exit

ci/do_ci.sh

@@ -265,13 +265,14 @@ elif [[ "$1" == "cmake.opentracing_shim.install.test" ]]; then
     "shims_opentracing"
   )
   EXPECTED_COMPONENTS_STRING=$(IFS=\;; echo "${EXPECTED_COMPONENTS[*]}")
-  cmake -S "${SRC_DIR}/install/test/cmake" \
-        -B "${BUILD_DIR}/install_test" \
-        "${CMAKE_OPTIONS[@]}" \
+  mkdir -p "${BUILD_DIR}/install_test"
+  cd "${BUILD_DIR}/install_test"
+  cmake "${CMAKE_OPTIONS[@]}" \
         "-DCMAKE_PREFIX_PATH=${INSTALL_TEST_DIR}" \
         "-DINSTALL_TEST_CMAKE_OPTIONS=${CMAKE_OPTIONS_STRING}" \
-        "-DINSTALL_TEST_COMPONENTS=${EXPECTED_COMPONENTS_STRING}"
-  ctest --test-dir "${BUILD_DIR}/install_test" --output-on-failure
+        "-DINSTALL_TEST_COMPONENTS=${EXPECTED_COMPONENTS_STRING}" \
+        -S "${SRC_DIR}/install/test/cmake"
+  ctest --output-on-failure
   exit 0
 elif [[ "$1" == "cmake.c++20.test" ]]; then
   cd "${BUILD_DIR}"
@@ -476,6 +477,8 @@ elif [[ "$1" == "cmake.install.test" ]]; then
         -DWITH_ZIPKIN=ON \
         -DWITH_ELASTICSEARCH=ON \
         -DWITH_EXAMPLES=ON \
+        -DWITH_EXAMPLES_HTTP=ON \
+        -DBUILD_W3CTRACECONTEXT_TEST=ON \
         -DOPENTELEMETRY_INSTALL=ON \
         "${SRC_DIR}"
 
@@ -502,14 +505,14 @@ elif [[ "$1" == "cmake.install.test" ]]; then
     "exporters_zipkin"
   )
   EXPECTED_COMPONENTS_STRING=$(IFS=\;; echo "${EXPECTED_COMPONENTS[*]}")
-
-  cmake -S "${SRC_DIR}/install/test/cmake" \
-        -B "${BUILD_DIR}/install_test" \
-         "${CMAKE_OPTIONS[@]}" \
+  mkdir -p "${BUILD_DIR}/install_test"
+  cd "${BUILD_DIR}/install_test"
+  cmake  "${CMAKE_OPTIONS[@]}" \
          "-DCMAKE_PREFIX_PATH=${INSTALL_TEST_DIR}" \
          "-DINSTALL_TEST_CMAKE_OPTIONS=${CMAKE_OPTIONS_STRING}" \
-         "-DINSTALL_TEST_COMPONENTS=${EXPECTED_COMPONENTS_STRING}"
-  ctest --test-dir "${BUILD_DIR}/install_test" --output-on-failure
+         "-DINSTALL_TEST_COMPONENTS=${EXPECTED_COMPONENTS_STRING}" \
+         -S "${SRC_DIR}/install/test/cmake"
+  ctest --output-on-failure
   exit 0
 elif [[ "$1" == "cmake.test_example_plugin" ]]; then
   # Build the plugin

ci/install_protobuf.sh

@@ -70,7 +70,7 @@ if [ -e "../CMakeLists.txt" ]; then
 else
   cmake ../cmake "${CPP_PROTOBUF_BUILD_OPTIONS[@]}"
 fi
-cmake --build . -j $(nproc)
-cmake --install .
+make -j $(nproc)
+make install
 popd
 ldconfig

ci/setup_grpc.sh

@@ -114,7 +114,9 @@ if [[ $build_internal_abseil_cpp -ne 0 ]]; then
         ABSEIL_CPP_BUILD_OPTIONS=(${ABSEIL_CPP_BUILD_OPTIONS[@]} "-DBUILD_SHARED_LIBS=$build_shared_libs")
     fi
     cmake  "${ABSEIL_CPP_BUILD_OPTIONS[@]}" ..
-    cmake --build . -j${nproc} --target install && popd
+    make -j $(nproc)
+    make install
+    popd
 fi
 mkdir -p build && pushd build
 
@@ -144,8 +146,8 @@ echo "Building gRPC ${install_grpc_version}"
 echo "CMake build options:" "${GRPC_BUILD_OPTIONS[@]}"
 
 cmake "${GRPC_BUILD_OPTIONS[@]}" ..
-cmake --build . -j$(nproc)
-cmake --install .
+make -j $(nproc)
+make install
 popd
 popd
 

cmake/tools.cmake

@@ -94,6 +94,15 @@ function(patch_protobuf_targets)
 endfunction()
 
 function(project_build_tools_get_imported_location OUTPUT_VAR_NAME TARGET_NAME)
+
+  # The following if statement was added to support cmake versions < 3.19
+  get_target_property(TARGET_TYPE ${TARGET_NAME} TYPE)
+  if(TARGET_TYPE STREQUAL "INTERFACE_LIBRARY")
+    # For interface libraries, do not attempt to retrieve imported location.
+    set(${OUTPUT_VAR_NAME} "" PARENT_SCOPE)
+    return()
+  endif()
+
   if(CMAKE_BUILD_TYPE)
     string(TOUPPER "IMPORTED_LOCATION_${CMAKE_BUILD_TYPE}"
                    TRY_SPECIFY_IMPORTED_LOCATION)

docker/grpc/CMakeLists.txt

@@ -1,7 +1,7 @@
 # Copyright The OpenTelemetry Authors
 # SPDX-License-Identifier: Apache-2.0
 
-cmake_minimum_required(VERSION 3.11 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.14 FATAL_ERROR)
 
 project(
   dependencies

install/test/cmake/CMakeLists.txt

@@ -1,7 +1,7 @@
 # Copyright The OpenTelemetry Authors
 # SPDX-License-Identifier: Apache-2.0
 
-cmake_minimum_required(VERSION 3.10)
+cmake_minimum_required(VERSION 3.14)
 project(opentelemetry-cpp-component-install-tests LANGUAGES CXX)
 
 if(NOT INSTALL_TEST_CMAKE_OPTIONS)

install/test/cmake/component_tests/api/CMakeLists.txt

@@ -1,7 +1,7 @@
 # Copyright The OpenTelemetry Authors
 # SPDX-License-Identifier: Apache-2.0
 
-cmake_minimum_required(VERSION 3.10)
+cmake_minimum_required(VERSION 3.14)
 
 project(opentelemetry-cpp-api-install-test LANGUAGES CXX)
 
@@ -11,7 +11,7 @@ find_package(GTest REQUIRED)
 include(GoogleTest)
 
 add_executable(api_test ${INSTALL_TEST_SRC_DIR}/test_api.cc)
-target_link_libraries(api_test PRIVATE opentelemetry-cpp::api GTest::gtest
-                                       GTest::gtest_main)
+target_link_libraries(api_test PRIVATE opentelemetry-cpp::api GTest::GTest
+                                       GTest::Main)
 
 gtest_discover_tests(api_test)

install/test/cmake/component_tests/exporters_elasticsearch/CMakeLists.txt

@@ -1,7 +1,7 @@
 # Copyright The OpenTelemetry Authors
 # SPDX-License-Identifier: Apache-2.0
 
-cmake_minimum_required(VERSION 3.10)
+cmake_minimum_required(VERSION 3.14)
 project(opentelemetry-cpp-exporters-elasticsearch-install-test LANGUAGES CXX)
 
 find_package(opentelemetry-cpp REQUIRED COMPONENTS exporters_elasticsearch)
@@ -17,7 +17,7 @@ add_executable(exporters_elasticsearch_test
                ${INSTALL_TEST_SRC_DIR}/test_exporters_elasticsearch.cc)
 target_link_libraries(
   exporters_elasticsearch_test
-  PRIVATE opentelemetry-cpp::elasticsearch_log_record_exporter GTest::gtest
-          GTest::gtest_main)
+  PRIVATE opentelemetry-cpp::elasticsearch_log_record_exporter GTest::GTest
+          GTest::Main)
 
 gtest_discover_tests(exporters_elasticsearch_test)