Skip to content

Commit f6c3623

Browse files
committed
set macos conan profile to arm64. fix opentracing shim test script
1 parent 4f8ec74 commit f6c3623

File tree

4 files changed

+65
-41
lines changed

4 files changed

+65
-41
lines changed

.github/workflows/cmake_install.yml

Lines changed: 38 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ on:
99

1010
jobs:
1111
windows_2022_vcpkg:
12-
name: Windows 2022 vcpkg (cxx17, static libs only)
12+
name: Windows 2022 vcpkg cxx17 (static libs - dll - opentracing shim)
1313
runs-on: windows-2022
1414
env:
1515
CXX_STANDARD: '17'
@@ -23,9 +23,11 @@ jobs:
2323
run: ./ci/do_ci.ps1 cmake.install.test
2424
- name: Run DLL Tests
2525
run: ./ci/do_ci.ps1 cmake.dll.install.test
26+
- name: Run OpenTracing Shim Test
27+
run: ./ci/do_ci.sh cmake.opentracing_shim.install.test
2628

2729
windows_2019_vcpkg:
28-
name: Windows 2019 vcpkg (cxx14, static libs only)
30+
name: Windows 2019 vcpkg cxx14 (static libs)
2931
runs-on: windows-2019
3032
env:
3133
CXX_STANDARD: '14'
@@ -37,68 +39,66 @@ jobs:
3739
run: ./ci/setup_windows_ci_environment.ps1
3840
- name: Run Tests
3941
run: ./ci/do_ci.ps1 cmake.install.test
40-
- name: Run DLL Tests
41-
run: ./ci/do_ci.ps1 cmake.dll.install.test
4242

43-
ubuntu_2404_src_grpc_1_71_0:
44-
name: Ubuntu 24.04 grpc 1.71.0 src (cxx17, static libs only)
43+
ubuntu_2404_system_packages:
44+
name: Ubuntu 24.04 apt packages cxx17 (static libs - shared libs)
4545
runs-on: ubuntu-24.04
4646
env:
4747
INSTALL_TEST_DIR: '/home/runner/install_test'
48-
CXX_STANDARD: '20'
48+
CXX_STANDARD: '17'
4949
BUILD_TYPE: 'Debug'
5050
steps:
5151
- uses: actions/checkout@v4
5252
with:
5353
submodules: 'recursive'
54-
- name: Install gtest, libcurl, zlib, nlohmann-json with apt
54+
- name: Install libcurl, zlib, nlohmann-json with apt
5555
run: |
5656
sudo -E ./ci/setup_googletest.sh
5757
sudo -E ./ci/setup_ci_environment.sh
58-
- name: Build abseil, protobuf, and grpc with ci scripts
59-
env:
60-
ABSEIL_CPP_VERSION: '20240722.1'
61-
PROTOBUF_VERSION: '29.0'
62-
GRPC_VERSION: 'v1.71.0'
58+
- name: Build abseil, protobuf, and grpc with apt
6359
run: |
64-
sudo -E ./ci/install_abseil.sh
65-
sudo -E ./ci/install_protobuf.sh
66-
sudo -E ./ci/setup_grpc.sh -r $GRPC_VERSION -s $CXX_STANDARD -p protobuf -p abseil-cpp
60+
sudo -E apt-get update
61+
sudo -E apt-get install -y libabsl-dev libprotobuf-dev libgrpc++-dev protobuf-compiler protobuf-compiler-grpc
6762
- name: Run Tests (static libs)
6863
env:
6964
BUILD_SHARED_LIBS: 'OFF'
7065
run: ./ci/do_ci.sh cmake.install.test
66+
- name: Run Tests (shared libs)
67+
env:
68+
BUILD_SHARED_LIBS: 'ON'
69+
run: ./ci/do_ci.sh cmake.install.test
7170

72-
ubuntu_2404_system_packages:
73-
name: Ubuntu 24.04 with apt packages (cxx17, static and shared libs)
71+
ubuntu_2404_script_build_grpc_1_71_0:
72+
name: Ubuntu 24.04 script build grpc 1.71.0 cxx17 (static libs)
7473
runs-on: ubuntu-24.04
7574
env:
7675
INSTALL_TEST_DIR: '/home/runner/install_test'
77-
CXX_STANDARD: '17'
76+
CXX_STANDARD: '20'
7877
BUILD_TYPE: 'Debug'
7978
steps:
8079
- uses: actions/checkout@v4
8180
with:
8281
submodules: 'recursive'
83-
- name: Install libcurl, zlib, nlohmann-json with apt
82+
- name: Install gtest, libcurl, zlib, nlohmann-json with apt
8483
run: |
8584
sudo -E ./ci/setup_googletest.sh
8685
sudo -E ./ci/setup_ci_environment.sh
87-
- name: Build abseil, protobuf, and grpc with apt
86+
- name: Build abseil, protobuf, and grpc with ci scripts
87+
env:
88+
ABSEIL_CPP_VERSION: '20240722.1'
89+
PROTOBUF_VERSION: '29.0'
90+
GRPC_VERSION: 'v1.71.0'
8891
run: |
89-
sudo -E apt-get update
90-
sudo -E apt-get install -y libabsl-dev libprotobuf-dev libgrpc++-dev protobuf-compiler protobuf-compiler-grpc
92+
sudo -E ./ci/install_abseil.sh
93+
sudo -E ./ci/install_protobuf.sh
94+
sudo -E ./ci/setup_grpc.sh -r $GRPC_VERSION -s $CXX_STANDARD -p protobuf -p abseil-cpp
9195
- name: Run Tests (static libs)
9296
env:
9397
BUILD_SHARED_LIBS: 'OFF'
9498
run: ./ci/do_ci.sh cmake.install.test
95-
- name: Run Tests (shared libs)
96-
env:
97-
BUILD_SHARED_LIBS: 'ON'
98-
run: ./ci/do_ci.sh cmake.install.test
9999

100-
ubuntu_2204_src_grpc_1_55_0:
101-
name: Ubuntu 22.04 grpc 1.55.0 src (cxx17, static and shared libs)
100+
ubuntu_2204_script_build_grpc_1_55_0:
101+
name: Ubuntu 22.04 script_build grpc 1.55.0 cxx17 (static libs - shared libs)
102102
runs-on: ubuntu-22.04
103103
env:
104104
INSTALL_TEST_DIR: '/home/runner/install_test'
@@ -130,8 +130,8 @@ jobs:
130130
BUILD_SHARED_LIBS: 'ON'
131131
run: ./ci/do_ci.sh cmake.install.test
132132

133-
ubuntu_2004_src_grpc_1_49_2:
134-
name: Ubuntu 20.04 grpc 1.49.2 src (cxx14, static and shared libs)
133+
ubuntu_2004_script_build_grpc_1_49_2:
134+
name: Ubuntu 20.04 script build grpc 1.49.2 cxx14 (static libs - shared libs)
135135
runs-on: ubuntu-20.04
136136
env:
137137
INSTALL_TEST_DIR: '/home/runner/install_test'
@@ -164,7 +164,7 @@ jobs:
164164
run: ./ci/do_ci.sh cmake.install.test
165165

166166
ubuntu_2404_conan_stable:
167-
name: Ubuntu 24.04 conanfile_stable (cxx17, static and shared libs)
167+
name: Ubuntu 24.04 conanfile_stable cxx17 (static libs - shared libs - opentracing shim)
168168
runs-on: ubuntu-24.04
169169
env:
170170
INSTALL_TEST_DIR: '/home/runner/install_test'
@@ -194,9 +194,11 @@ jobs:
194194
run: |
195195
export PKG_CONFIG_PATH=$INSTALL_TEST_DIR/lib/pkgconfig:$PKG_CONFIG_PATH
196196
./ci/verify_packages.sh
197+
- name: Run OpenTracing Shim Test
198+
run: ./ci/do_ci.sh cmake.opentracing_shim.install.test
197199

198200
ubuntu_2404_conan_latest:
199-
name: Ubuntu 24.04 conanfile_latest (cxx17, static libs only)
201+
name: Ubuntu 24.04 conanfile_latest cxx17 (static libs)
200202
runs-on: ubuntu-24.04
201203
env:
202204
INSTALL_TEST_DIR: '/home/runner/install_test'
@@ -224,7 +226,7 @@ jobs:
224226
./ci/verify_packages.sh
225227
226228
macos_14_conan_stable:
227-
name: macOS 14 conanfile_stable (cxx17, static and shared libs)
229+
name: macOS 14 conanfile_stable cxx17 (static libs - shared libs)
228230
runs-on: macos-14
229231
env:
230232
INSTALL_TEST_DIR: '/Users/runner/install_test'
@@ -240,7 +242,7 @@ jobs:
240242
brew install conan autoconf automake libtool coreutils
241243
conan profile detect --force
242244
- name: Install or build all dependencies with Conan
243-
run: conan install install/conan/conanfile_stable.txt --build=missing -of /Users/runner/conan -s build_type=Debug
245+
run: conan install install/conan/conanfile_stable.txt --build=missing -of /Users/runner/conan -s build_type=Debug -s arch=arm64
244246
- name: Run Tests (static libs)
245247
env:
246248
BUILD_SHARED_LIBS: 'OFF'
@@ -251,7 +253,7 @@ jobs:
251253
run: ./ci/do_ci.sh cmake.install.test
252254

253255
macos_14_brew_packages:
254-
name: macOS 14 with brew packages (cxx17, static libs only)
256+
name: macOS 14 with brew packages cxx17 (static libs)
255257
runs-on: macos-14
256258
env:
257259
CXX_STANDARD: '17'

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -733,7 +733,7 @@ if(CMAKE_TOOLCHAIN_FILE)
733733
message(STATUS "CMAKE_TOOLCHAIN_FILE: ${CMAKE_TOOLCHAIN_FILE}")
734734
endif()
735735
message(STATUS "BUILD_SHARED_LIBS: ${BUILD_SHARED_LIBS}")
736-
message(STATUS "Architecture: ${ARCH}")
736+
message(STATUS "ARCH: ${ARCH}")
737737
message(STATUS "---------------------------------------------")
738738
message(STATUS "Build Options")
739739
message(STATUS "---------------------------------------------")

ci/do_ci.ps1

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -458,7 +458,8 @@ switch ($action) {
458458
}
459459
"cmake.dll.install.test" {
460460
cd "$BUILD_DIR"
461-
rm -Recurse -Force "$INSTALL_TEST_DIR\*"
461+
Remove-Item -Recurse -Force "$BUILD_DIR\*"
462+
Remove-Item -Recurse -Force "$INSTALL_TEST_DIR\*"
462463

463464
$CMAKE_OPTIONS = @(
464465
"-DCMAKE_CXX_STANDARD=17",
@@ -475,8 +476,20 @@ switch ($action) {
475476
-DWITH_ABSEIL=OFF `
476477
-DWITH_THREAD_INSTRUMENTATION_PREVIEW=ON `
477478
-DWITH_METRICS_EXEMPLAR_PREVIEW=ON `
479+
-DWITH_ASYNC_EXPORT_PREVIEW=ON `
478480
-DWITH_ETW=ON `
479-
-DOPENTELEMETRY_INSTALL=ON
481+
-DOPENTELEMETRY_INSTALL=ON `
482+
-DWITH_OTLP_GRPC_SSL_MTLS_PREVIEW=OFF `
483+
-DWITH_OTLP_RETRY_PREVIEW=OFF `
484+
-DWITH_OTLP_GRPC=OFF `
485+
-DWITH_OTLP_HTTP=OFF `
486+
-DWITH_OTLP_FILE=OFF `
487+
-DWITH_OTLP_HTTP_COMPRESSION=OFF `
488+
-DWITH_HTTP_CLIENT_CURL=OFF `
489+
-DWITH_PROMETHEUS=OFF `
490+
-DWITH_ZIPKIN=OFF `
491+
-DWITH_ELASTICSEARCH=OFF `
492+
-DWITH_EXAMPLES=OFF `
480493

481494
$exit = $LASTEXITCODE
482495
if ($exit -ne 0) {

ci/do_ci.sh

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,16 @@ elif [[ "$1" == "cmake.abseil.test" ]]; then
245245
make test
246246
exit 0
247247
elif [[ "$1" == "cmake.opentracing_shim.test" ]]; then
248+
cd "${BUILD_DIR}"
249+
rm -rf *
250+
cmake "${CMAKE_OPTIONS[@]}" \
251+
-DCMAKE_CXX_FLAGS="-Werror -Wno-error=redundant-move $CXXFLAGS" \
252+
-DWITH_OPENTRACING=ON \
253+
"${SRC_DIR}"
254+
make -j $(nproc)
255+
make test
256+
exit 0
257+
elif [[ "$1" == "cmake.opentracing_shim.install.test" ]]; then
248258
cd "${BUILD_DIR}"
249259
rm -rf *
250260
rm -rf ${INSTALL_TEST_DIR}/*
@@ -262,7 +272,6 @@ elif [[ "$1" == "cmake.opentracing_shim.test" ]]; then
262272
"api"
263273
"sdk"
264274
"ext_common"
265-
"ext_http_curl"
266275
"exporters_in_memory"
267276
"exporters_ostream"
268277
"shims_opentracing"
@@ -273,7 +282,7 @@ elif [[ "$1" == "cmake.opentracing_shim.test" ]]; then
273282
"${CMAKE_OPTIONS[@]}" \
274283
"-DCMAKE_PREFIX_PATH=${INSTALL_TEST_DIR}" \
275284
"-DINSTALL_TEST_CMAKE_OPTIONS=${CMAKE_OPTIONS_STRING}" \
276-
"-DINSTALL_TEST_COMPONENTS=${EXPECTED_COMPONENTS}"
285+
"-DINSTALL_TEST_COMPONENTS=${EXPECTED_COMPONENTS_STRING}"
277286
ctest --test-dir "${BUILD_DIR}/install_test" --output-on-failure
278287
exit 0
279288
elif [[ "$1" == "cmake.c++20.test" ]]; then

0 commit comments

Comments
 (0)