Confirm dialog provider fix (#1111)

* Add test

* Fix regression

Author: tcbegley

src/components/button/Button.js

@@ -30,6 +30,9 @@ function Button({
   className,
   rel,
   setProps,
+  // onClick prop needs to be overridable for dcc.ConfirmDialog
+  // eslint-disable-next-line react/prop-types
+  onClick,
   ...otherProps
 }) {
   const incrementClicks = () => {
@@ -38,7 +41,7 @@ function Button({
     }
   };
   const useLink = href && !disabled;
-  otherProps[useLink ? 'preOnClick' : 'onClick'] = incrementClicks;
+  otherProps[useLink ? 'preOnClick' : 'onClick'] = onClick || incrementClicks;
 
   if (useLink) {
     // react-bootstrap strips out target prop if tag isn't an anchor element,

src/components/button/__tests__/Button.test.js

@@ -135,4 +135,18 @@ describe('Button', () => {
     await user.click(button.getByText('Clickable'));
     expect(mockEventListener.mock.calls).toHaveLength(0);
   });
+
+  test('onClick can be overridden', async () => {
+    const user = userEvent.setup();
+    const mockOnClick = jest.fn();
+    const button = render(
+      <Button href="/relative" onClick={mockOnClick}>
+        Clickable
+      </Button>
+    );
+
+    expect(mockOnClick.mock.calls).toHaveLength(0);
+    await user.click(button.getByText('Clickable'));
+    expect(mockOnClick.mock.calls).toHaveLength(1);
+  });
 });