Allow internal links to be used with carousel items (#973)

Author: tcbegley

src/components/carousel/Carousel.js

@@ -4,6 +4,8 @@ import {omit} from 'ramda';
 
 import RBCarousel from 'react-bootstrap/Carousel';
 
+import Link from '../../private/Link';
+
 /**
  * Component for creating Bootstrap carousel.  This component is a slideshow
  * for cycling through a series of content.
@@ -28,12 +30,15 @@ const Carousel = props => {
         ? item.imgClassName
         : 'd-block w-100';
 
-    const additionalProps = item.href ? {href: item.href} : {};
+    const useLink = item.href && true;
+    const additionalProps = useLink
+      ? {href: item.href, external_link: item.external_link}
+      : {};
 
     return (
       <RBCarousel.Item
         key={item.key}
-        as={item.href ? 'a' : 'div'}
+        as={item.href ? Link : 'div'}
         {...additionalProps}
       >
         <img
@@ -156,9 +161,21 @@ Carousel.propTypes = {
        */
       captionClassName: PropTypes.string,
       /**
-       * Optional hyperlink to add to the item.
+       * Optional hyperlink to add to the item. Item will be rendered as a
+       * HTML <a> or as a Dash-style link depending on whether the link is
+       * deemed to be internal or external. Override this automatic detection
+       * with the external_link argument.
+       */
+      href: PropTypes.string,
+      /**
+       * If true, the browser will treat this as an external link,
+       * forcing a page refresh at the new location. If false,
+       * this just changes the location without triggering a page
+       * refresh. Use this if you are observing dcc.Location, for
+       * instance. Defaults to true for absolute URLs and false
+       * otherwise.
        */
-      href: PropTypes.string
+      external_link: PropTypes.bool
     })
   ).isRequired,
 

src/components/dropdownmenu/DropdownMenuItem.js

@@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
 import {omit} from 'ramda';
 import RBDropdown from 'react-bootstrap/Dropdown';
 
-import Link, {isExternalLink} from '../../private/Link';
+import Link from '../../private/Link';
 import {DropdownMenuContext} from '../../private/DropdownMenuContext';
 
 /**