Allow target to be set on Button with href (#781)

Author: tcbegley

src/components/button/Button.js

@@ -44,17 +44,22 @@ const Button = props => {
   const useLink = href && !disabled;
   otherProps[useLink ? 'preOnClick' : 'onClick'] = onClick || incrementClicks;
 
+  if (useLink) {
+    // react-bootstrap strips out target prop if tag isn't an anchor element,
+    // so we pass it through under a different name
+    otherProps['linkTarget'] = target;
+  }
+
   return (
     <RBButton
       as={useLink ? Link : 'button'}
       variant={outline ? `outline-${color}` : color}
-      type={useLink ? null : type}
-      target={useLink ? target : null}
-      href={disabled ? null : href}
+      type={useLink ? undefined : type}
+      href={disabled ? undefined : href}
       disabled={disabled}
-      download={useLink ? download : null}
-      name={useLink ? null : name}
-      value={useLink ? null : value}
+      download={useLink ? download : undefined}
+      name={useLink ? undefined : name}
+      value={useLink ? undefined : value}
       className={class_name || className}
       {...omit(['n_clicks_timestamp'], otherProps)}
       data-dash-is-loading={

src/private/Link.js

@@ -67,6 +67,7 @@ class Link extends Component {
       external_link,
       preOnClick,
       target,
+      linkTarget,
       href,
       download,
       ...otherProps
@@ -80,8 +81,8 @@ class Link extends Component {
     return (
       <a
         href={href}
-        target={linkIsExternal ? target : null}
-        download={download && linkIsExternal ? download : null}
+        target={linkIsExternal ? target || linkTarget : undefined}
+        download={download && linkIsExternal ? download : undefined}
         {...otherProps}
         onClick={e => this.updateLocation(e)}
       >