Merge pull request #1215 from dbcli/RW/enable-ruff-rules-A001-A002

Enable `ruff check` rules A001 and A002

Author: rolandwalker

mycli/packages/completion_engine.py

@@ -289,5 +289,5 @@ def suggest_based_on_last_token(token, text_before_cursor, full_text, identifier
         return [{"type": "keyword"}]
 
 
-def identifies(id, schema, table, alias):
-    return id == alias or id == table or (schema and (id == schema + "." + table))
+def identifies(identifier, schema, table, alias):
+    return identifier == alias or identifier == table or (schema and (identifier == schema + "." + table))

mycli/packages/special/delimitercommand.py

@@ -26,10 +26,10 @@ def _split(self, sql):
 
         return [stmt.replace(";", self._delimiter).replace(placeholder, ";") for stmt in split]
 
-    def queries_iter(self, input):
+    def queries_iter(self, input_str):
         """Iterate over queries in the input string."""
 
-        queries = self._split(input)
+        queries = self._split(input_str)
         while queries:
             for sql in queries:
                 delimiter = self._delimiter

mycli/packages/special/iocommands.py

@@ -547,6 +547,6 @@ def get_current_delimiter():
 
 
 @export
-def split_queries(input):
-    for query in delimiter_command.queries_iter(input):
+def split_queries(input_str):
+    for query in delimiter_command.queries_iter(input_str):
         yield query

mycli/packages/special/main.py

@@ -108,7 +108,7 @@ def show_keyword_help(cur, arg):
 
 @special_command("exit", "\\q", "Exit.", arg_type=NO_QUERY, aliases=("\\q",))
 @special_command("quit", "\\q", "Quit.", arg_type=NO_QUERY)
-def quit(*_args):
+def quit_(*_args):
     raise EOFError
 
 

pyproject.toml

@@ -80,8 +80,6 @@ ignore = [
     'E117',   # over-indented
     'W191',   # tab-indentation
     # TODO
-    'A001',   # todo enableme variable shadowing builtin
-    'A002',   # todo enableme function argument shadowing builtin
     'A004',   # todo enableme import shadowing builtin
     'PIE796', # todo enableme Enum contains duplicate value
 ]