Skip to content

Commit 9652520

Browse files
devnaumovEvgeniaBzzzmr-anton-t
authored
dbeaver/pro#7090 move auth island, show desc as placeholder (#4012)
Co-authored-by: Evgenia <[email protected]> Co-authored-by: mr-anton-t <[email protected]>
1 parent 7e7d663 commit 9652520

File tree

3 files changed

+33
-30
lines changed

3 files changed

+33
-30
lines changed

webapp/packages/core-blocks/src/ObjectPropertyInfo/ObjectPropertyInfoForm/RenderField.tsx

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,10 @@ export const RenderField = observer<RenderFieldProps>(function RenderField({
142142
);
143143
}
144144

145+
const passwordSaved = showRememberTip && ((isPassword && !!property.value) || saved);
146+
const passwordSavedMessage = passwordSaved ? translate('core_blocks_object_property_info_password_saved') : undefined;
147+
const placeholder = passwordSavedMessage || property.description;
148+
145149
if (controlType === 'selector') {
146150
if (state !== undefined) {
147151
return (
@@ -154,6 +158,7 @@ export const RenderField = observer<RenderFieldProps>(function RenderField({
154158
valueSelector={value => value}
155159
titleSelector={value => value}
156160
defaultValue={defaultValue}
161+
placeholder={placeholder}
157162
title={property.description}
158163
disabled={disabled}
159164
readOnly={readonly}
@@ -174,6 +179,7 @@ export const RenderField = observer<RenderFieldProps>(function RenderField({
174179
valueSelector={value => value}
175180
titleSelector={value => value}
176181
defaultValue={defaultValue}
182+
placeholder={placeholder}
177183
title={property.description}
178184
disabled={disabled}
179185
readOnly={readonly}
@@ -185,9 +191,6 @@ export const RenderField = observer<RenderFieldProps>(function RenderField({
185191
);
186192
}
187193

188-
const passwordSaved = showRememberTip && ((isPassword && !!property.value) || saved);
189-
const passwordSavedMessage = passwordSaved ? translate('core_blocks_object_property_info_password_saved') : undefined;
190-
191194
if (controlType === 'file' && state) {
192195
return (
193196
<InputFileTextContent
@@ -213,7 +216,7 @@ export const RenderField = observer<RenderFieldProps>(function RenderField({
213216
required={required}
214217
title={state[property.id!]}
215218
labelTooltip={property.description || property.displayName}
216-
placeholder={passwordSavedMessage}
219+
placeholder={placeholder}
217220
name={property.id!}
218221
state={state}
219222
disabled={disabled}
@@ -230,7 +233,7 @@ export const RenderField = observer<RenderFieldProps>(function RenderField({
230233
required={required}
231234
title={value}
232235
labelTooltip={property.description || property.displayName}
233-
placeholder={passwordSavedMessage}
236+
placeholder={placeholder}
234237
name={property.id!}
235238
value={value}
236239
readOnly={readonly || disabled}
@@ -253,7 +256,7 @@ export const RenderField = observer<RenderFieldProps>(function RenderField({
253256
defaultState={defaultState || { [property.id!]: defaultValue }}
254257
autoHide={autoHide}
255258
description={hint}
256-
placeholder={passwordSavedMessage}
259+
placeholder={placeholder}
257260
readOnly={readonly || disabled}
258261
autoComplete={autocomplete}
259262
className={className}
@@ -275,7 +278,7 @@ export const RenderField = observer<RenderFieldProps>(function RenderField({
275278
value={value}
276279
defaultValue={defaultValue}
277280
description={hint}
278-
placeholder={passwordSavedMessage}
281+
placeholder={placeholder}
279282
readOnly={readonly || disabled}
280283
autoComplete={autocomplete}
281284
className={className}

webapp/packages/plugin-connections/src/ConnectionForm/ConnectionAuthModelCredentials/ConnectionAuthModelCredentialsForm.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export const ConnectionAuthModelCredentialsForm = observer<Props>(function Conne
3333
}
3434

3535
return {
36-
tiny: true,
36+
fill: true,
3737
};
3838
}
3939

webapp/packages/plugin-connections/src/ConnectionForm/Options/Options.tsx

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -244,28 +244,6 @@ export const Options: TabContainerPanelComponent<IConnectionFormProps> = observe
244244
))}
245245
</Group>
246246
</Group>
247-
<Group form gap>
248-
<Container wrap gap>
249-
<InputField type="text" name="name" minLength={1} state={optionsPart.state} readOnly={readonly || formState.isDisabled} required fill>
250-
{translate('connections_connection_name')}
251-
</InputField>
252-
<ProjectSelect
253-
value={formState.state.projectId}
254-
readOnly={readonly || edit}
255-
disabled={formState.isDisabled}
256-
autoHide
257-
onChange={setProject}
258-
/>
259-
<InputField type="text" name="folder" state={optionsPart.state} autoHide readOnly tiny fill>
260-
{translate('plugin_connections_connection_form_part_main_folder')}
261-
</InputField>
262-
</Container>
263-
<Textarea name="description" rows={3} state={optionsPart.state} readOnly={readonly || formState.isDisabled}>
264-
{translate('connections_connection_description')}
265-
</Textarea>
266-
</Group>
267-
</Container>
268-
<Container medium gap>
269247
{!driver?.anonymousAccess && (authentication.authorized || !edit) && (
270248
<Group form gap>
271249
<GroupTitle>{translate('connections_connection_edit_authentication')}</GroupTitle>
@@ -330,10 +308,32 @@ export const Options: TabContainerPanelComponent<IConnectionFormProps> = observe
330308
)}
331309
</Group>
332310
)}
311+
</Container>
312+
<Container medium gap>
333313
<Placeholder container={connectionFormService.providerPropertiesContainer} formState={formState} />
334314
{driver?.providerProperties && <ProviderPropertiesForm formState={formState} properties={driver.providerProperties} readonly={readonly} />}
335315

336316
<AdvancedPropertiesForm config={optionsPart.state} disabled={formState.isDisabled} readonly={readonly} />
317+
<Group form gap>
318+
<Container wrap gap>
319+
<InputField type="text" name="name" minLength={1} state={optionsPart.state} readOnly={readonly || formState.isDisabled} required fill>
320+
{translate('connections_connection_name')}
321+
</InputField>
322+
<ProjectSelect
323+
value={formState.state.projectId}
324+
readOnly={readonly || edit}
325+
disabled={formState.isDisabled}
326+
autoHide
327+
onChange={setProject}
328+
/>
329+
<InputField type="text" name="folder" state={optionsPart.state} autoHide readOnly tiny fill>
330+
{translate('plugin_connections_connection_form_part_main_folder')}
331+
</InputField>
332+
</Container>
333+
<Textarea name="description" rows={3} state={optionsPart.state} readOnly={readonly || formState.isDisabled}>
334+
{translate('connections_connection_description')}
335+
</Textarea>
336+
</Group>
337337
</Container>
338338
</ColoredContainer>
339339
</Form>

0 commit comments

Comments
 (0)