Skip to content

Commit a3da9e7

Browse files
authored
Merge branch 'devel' into dbeaver/pro#7080/refactor-grid-api
2 parents df0d44a + 5d83098 commit a3da9e7

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

webapp/packages/plugin-connections/src/ConnectionForm/Options/Options.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ import {
3636
useAuthenticationAction,
3737
useAutoLoad,
3838
Text,
39+
Placeholder,
3940
} from '@cloudbeaver/core-blocks';
4041
import {
4142
ConnectionInfoAuthPropertiesResource,
@@ -62,6 +63,7 @@ import { ParametersForm } from './ParametersForm.js';
6263
import { ProviderPropertiesForm } from './ProviderPropertiesForm.js';
6364
import { getConnectionFormOptionsPart } from './getConnectionFormOptionsPart.js';
6465
import type { IConnectionFormProps } from '../IConnectionFormState.js';
66+
import { ConnectionFormService } from '../ConnectionFormService.js';
6567

6668
const PROFILE_AUTH_MODEL_ID = 'profile';
6769

@@ -100,6 +102,7 @@ export const Options: TabContainerPanelComponent<IConnectionFormProps> = observe
100102
const connectionInfoOriginResource = useResource(Options, ConnectionInfoOriginResource, optionsPart.connectionKey);
101103
const connectionInfoAuthPropertiesResource = useResource(Options, ConnectionInfoAuthPropertiesResource, optionsPart.connectionKey);
102104
const configurationTypeLabel = translate('connections_connection_configuration');
105+
const connectionFormService = useService(ConnectionFormService);
103106

104107
//@TODO it's here until the profile implementation in the CloudBeaver
105108
const readonly = formState.isDisabled || formState.isReadOnly || connectionInfoAuthResource.data?.authModel === PROFILE_AUTH_MODEL_ID;
@@ -342,6 +345,7 @@ export const Options: TabContainerPanelComponent<IConnectionFormProps> = observe
342345
)}
343346
</Group>
344347
)}
348+
<Placeholder container={connectionFormService.providerPropertiesContainer} formState={formState} />
345349
{driver?.providerProperties && <ProviderPropertiesForm formState={formState} properties={driver.providerProperties} readonly={readonly} />}
346350

347351
<AdvancedPropertiesForm config={optionsPart.state} disabled={formState.isDisabled} readonly={readonly} />

webapp/packages/plugin-connections/src/ConnectionForm/Options/ProviderPropertiesForm.tsx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,13 @@ import {
1313
Group,
1414
GroupTitle,
1515
ObjectPropertyInfoForm,
16-
Placeholder,
1716
useObjectPropertyCategories,
1817
useTranslate,
1918
} from '@cloudbeaver/core-blocks';
2019
import { type DriverPropertyInfoFragment, getObjectPropertyType } from '@cloudbeaver/core-sdk';
2120
import type { IFormState } from '@cloudbeaver/core-ui';
2221
import type { IConnectionFormState } from '../IConnectionFormState.js';
2322
import { getConnectionFormOptionsPart } from './getConnectionFormOptionsPart.js';
24-
import { useService } from '@cloudbeaver/core-di';
25-
import { ConnectionFormService } from '../ConnectionFormService.js';
2623

2724
type DriverPropertyInfo = DriverPropertyInfoFragment;
2825

@@ -37,7 +34,6 @@ export const ProviderPropertiesForm = observer<Props>(function ProviderPropertie
3734
const config = getConnectionFormOptionsPart(formState).state;
3835
const disabled = formState.isDisabled;
3936
const supportedProperties = properties.filter(property => property.supportedConfigurationTypes?.some(type => type === config.configurationType));
40-
const connectionFormService = useService(ConnectionFormService);
4137

4238
const { categories, isUncategorizedExists } = useObjectPropertyCategories(supportedProperties);
4339

@@ -50,7 +46,6 @@ export const ProviderPropertiesForm = observer<Props>(function ProviderPropertie
5046

5147
return (
5248
<Group form gap>
53-
<Placeholder container={connectionFormService.providerPropertiesContainer} formState={formState} />
5449
{isUncategorizedExists && (
5550
<>
5651
<GroupTitle>{translate('ui_settings')}</GroupTitle>

0 commit comments

Comments
 (0)