dbeaver/dbeaver-devops#2017 add podman to user's PATH

Author: flambchap

app/app.go

@@ -208,7 +208,7 @@ func (a *App) tryInstallingViaInstaller(d Dependency) bool {
 		return false
 	}
 	if installerInfo.defaultExecutableDir.IsPresent {
-		if err := ensureDirInPath(installerInfo.defaultExecutableDir.Value); err != nil {
+		if err := ensureDirInRuntimePath(installerInfo.defaultExecutableDir.Value); err != nil {
 			slog.Warn("error while adding a newly installed (via installer) dependency to PATH", "error", err, "dependency", d)
 		}
 	}
@@ -261,16 +261,17 @@ func (a *App) tryInstallingFromArchive(d Dependency) bool {
 		return false
 	}
 	unzipPath := a.findUnzipPath(archiveInfo.url)
+	a.printer.Println("Extracting...")
 	if err := unzipFile(archive, unzipPath); err != nil {
 		slog.Warn("unable to unzip the archive", "dependency", d, "error", err, "archive path", archive, "unzip path", unzipPath)
 		return false
 	}
 	// Updating PATH
 	pathElements := make([]string, 0, len(archiveInfo.executableSubpath)+1)
 	pathElements = append(pathElements, unzipPath)
-	copy(pathElements[1:], archiveInfo.executableSubpath)
+	pathElements = append(pathElements, archiveInfo.executableSubpath...)
 	pathToDirWithDependency := filepath.Join(pathElements...)
-	if err := ensureDirInPath(pathToDirWithDependency); err != nil {
+	if err := ensureDirInUserPath(pathToDirWithDependency); err != nil {
 		slog.Warn("unable to add dependency to PATH", "dependency", d, "error", err)
 		a.printer.PrintErrf("unable to add %s (%s) to PATH; consider adding it manually"+lib.NewLine(), d, pathToDirWithDependency)
 	}

app/utils.go

@@ -13,6 +13,7 @@ import (
 	"os"
 	"os/exec"
 	"path/filepath"
+	"runtime"
 	"slices"
 	"strings"
 )
@@ -84,7 +85,29 @@ func unzipElement(file *zip.File, destDir string) error {
 	return nil
 }
 
-func ensureDirInPath(dir string) error {
+func ensureDirInUserPath(dir string) error {
+	if runtime.GOOS != "windows" {
+		return errors.New("setting PATH is not implemented for this OS")
+	}
+	cmd := exec.Command("powershell", "-Command", "[Environment]::GetEnvironmentVariable('Path','User')")
+	output, err := cmd.Output()
+	if err != nil {
+		return lib.WrapError("unable to get user PATH from powershell", err)
+	}
+	userPath := strings.TrimSpace(string(output))
+	pathMembers := strings.Split(userPath, string(os.PathListSeparator))
+	if slices.Contains(pathMembers, dir) {
+		return nil
+	}
+	newPath := dir + string(os.PathListSeparator) + userPath
+	setCmd := exec.Command("powershell", "-Command", fmt.Sprintf("[Environment]::SetEnvironmentVariable('Path','%s','User')", newPath))
+	if err := setCmd.Run(); err != nil {
+		return lib.WrapError("unable to set user PATH from powershell", err)
+	}
+	return nil
+}
+
+func ensureDirInRuntimePath(dir string) error {
 	currentPath := os.Getenv("PATH")
 	currentPathMembers := strings.Split(currentPath, string(os.PathListSeparator))
 	if slices.Contains(currentPathMembers, dir) {