closes #72 (#74)

next step towards v2.x 🎉

Author: simonneutert

CHANGELOG.md

@@ -3,6 +3,7 @@
 * [#62](https://github.com/dblock/strava-ruby-client/pull/68): Drops `Activity#type` attribute as it is being deprecated by Strava, dropping `Activity#type_emoji` with it - [@simonneutert](https://github.com/simonneutert).
 * [#23](https://github.com/dblock/strava-ruby-client/pull/23): Failed uploads raise Strava::Errors::UploadError - [@ylecuyer](https://github.com/ylecuyer), [@simonneutert](https://github.com/simonneutert).
 * [#69](https://github.com/dblock/strava-ruby-client/pull/69): Raises `Strava::Api::RatelimitError`, when API ratelimit exceeded - [@simonneutert](https://github.com/simonneutert).
+* [#74](https://github.com/dblock/strava-ruby-client/pull/74): Fixes serialization causing `stack level too deep` - [@simonneutert](https://github.com/simonneutert).
 * Your contribution here.
 
 ### 1.0.0 (2022/12/29)

lib/strava/models/mixins/http_response.rb

@@ -7,7 +7,16 @@ module HttpResponse
         extend ActiveSupport::Concern
 
         included do
-          property 'http_response', transform_with: ->(v) { Strava::Web::ApiResponse.new(v) }
+          attr_reader :input
+
+          def initialize(obj)
+            @input = obj
+            super
+          end
+
+          def http_response
+            @http_response ||= Strava::Web::ApiResponse.new(input['http_response'])
+          end
         end
       end
     end

lib/strava/models/upload.rb

@@ -25,7 +25,7 @@ def validate!
       end
 
       def raise_when_background_job_failed!
-        response = self['http_response'].response
+        response = http_response.response
         return unless response_contains_error_message?(response)
 
         raise Strava::Errors::UploadError, response_values(response)

lib/strava/web/api_response.rb

@@ -10,7 +10,7 @@ class ApiResponse
       #
       def initialize(http_response)
         @response = http_response
-        @ratelimit = Strava::Api::Ratelimit.new(@response)
+        @ratelimit = Strava::Api::Ratelimit.new(http_response)
       end
     end
   end

spec/strava/api/client/endpoints/activities/activity_spec.rb

@@ -278,11 +278,99 @@
 
     expect(activity.available_zones).to eq %w[heartrate pace]
   end
+
   it 'returns activity by id' do
     activity = client.activity(1_946_417_534)
     expect(activity).to be_a Strava::Models::Activity
     expect(activity.id).to eq 1_946_417_534
   end
+
+  context 'when serialized to JSON' do
+    it 'is serialized without errors' do
+      activity = client.activity(1_946_417_534)
+      expect(activity.to_json).to be_present
+    end
+
+    it 'contains all properties' do
+      activity = client.activity(1_946_417_534)
+      activity_json = JSON.parse(activity.to_json)
+      expect(activity_json.keys).to match_array(
+        %w[moving_time
+           elapsed_time
+           average_speed
+           distance
+           total_elevation_gain
+           start_date_local
+           id
+           resource_state
+           athlete
+           name
+           description
+           sport_type
+           workout_type
+           external_id
+           upload_id
+           start_date
+           timezone
+           utc_offset
+           start_latlng
+           end_latlng
+           location_city
+           location_state
+           location_country
+           start_latitude
+           start_longitude
+           achievement_count
+           kudos_count
+           comment_count
+           athlete_count
+           photo_count
+           map
+           trainer
+           commute
+           manual
+           private
+           visibility
+           flagged
+           gear_id
+           from_accepted_tag
+           max_speed
+           has_heartrate
+           average_heartrate
+           max_heartrate
+           heartrate_opt_out
+           display_hide_heartrate_option
+           elev_high
+           elev_low
+           pr_count
+           total_photo_count
+           has_kudoed
+           suffer_score
+           calories
+           segment_efforts
+           best_efforts
+           photos
+           similar_activities
+           embed_token
+           available_zones
+           splits_metric
+           splits_standard
+           laps
+           gear
+           device_name
+           average_cadence
+           average_temp
+           average_watts
+           weighted_average_watts
+           kilojoules
+           device_watts
+           max_watts
+           highlighted_kudosers
+           segment_leaderboard_opt_out
+           leaderboard_opt_out]
+      )
+    end
+  end
 end
 
 # uses the cassette: 'client/activity' but with status changed to 429 and ratelimit exceeded