Housekeeping for the gem: require Ruby3, updates to newest Rubocop with rubocop-rake and rubocop-rspec plugins (#85)

* implements rubocop-rake and rubocop-rspec

* most recent rubocop

* minimum ruby version >= 3.0

* rebase on upstream/master

* adds entry to UPGRADING.md

* settle version on v2.2.0

* add the missing `bundle install` step to the RELEASING doc

Author: simonneutert

.github/workflows/rubocop.yml

@@ -8,6 +8,6 @@ jobs:
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 2.7
+          ruby-version: 3.0
           bundler-cache: true
       - run: bundle exec rubocop

.github/workflows/test.yml

@@ -6,9 +6,11 @@ jobs:
     strategy:
       matrix:
         ruby-version:
-          - "2.7"
           - "3.0"
           - "3.1"
+          - "3.2"
+          - "3.3"
+          - "jruby-9.4"
     steps:
       - uses: actions/checkout@v2
       - name: Set up Ruby

.rubocop.yml

@@ -1,5 +1,11 @@
+inherit_from: .rubocop_todo.yml
+
+require:
+  - rubocop-rake
+  - rubocop-rspec
+
 AllCops:
-  TargetRubyVersion: 2.7
+  TargetRubyVersion: 3.0
   NewCops: enable
   Exclude:
     - vendor/**/*
@@ -25,4 +31,22 @@ Layout/LineLength:
 
 Style/MultilineBlockChain:
   Exclude:
-    - spec/**/*
+    - spec/**/*
+
+RSpec/MultipleExpectations:
+  Enabled: false
+
+RSpec/SpecFilePathFormat:
+  Exclude:
+    - "spec/strava/version_spec.rb"
+    - "spec/strava/oauth/client_spec.rb"
+    - "spec/strava/oauth/config_spec.rb"
+    - "spec/strava/models/activities/ride_spec.rb"
+    - "spec/strava/models/activities/swim_spec.rb"
+    - "spec/strava/models/activities/run_spec.rb"
+
+RSpec/ExampleLength:
+  Enabled: false
+
+RSpec/DescribeClass:
+  Enabled: false

.rubocop_todo.yml

@@ -0,0 +1,27 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2024-03-30 08:58:43 UTC using RuboCop version 1.56.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 13
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: SkipBlocks, EnforcedStyle.
+# SupportedStyles: described_class, explicit
+RSpec/DescribedClass:
+  Exclude:
+    - 'spec/strava/models/athlete_spec.rb'
+    - 'spec/strava/oauth/client_spec.rb'
+    - 'spec/strava/webhooks/client_spec.rb'
+
+# Offense count: 1
+RSpec/MultipleDescribes:
+  Exclude:
+    - 'spec/strava/api/client/endpoints/activities/activity_spec.rb'
+
+# Offense count: 5
+# Configuration parameters: AllowedGroups.
+RSpec/NestedGroups:
+  Max: 4

CHANGELOG.md

@@ -1,7 +1,8 @@
-### 2.1.1 (Next)
+### 2.2.0 (Next)
 
-* [#84](https://github.com/dblock/strava-ruby-client/pull/84): Adds back activity photos (finished PR #83) - [@simonneutert](https://github.com/simonneutert).
 * [#83](https://github.com/dblock/strava-ruby-client/pull/83): Adds back activity photos - [@dillon-co](https://github.com/dillon-co).
+* [#84](https://github.com/dblock/strava-ruby-client/pull/84): Adds back activity photos (finished PR #83) - [@simonneutert](https://github.com/simonneutert).
+* [#85](https://github.com/dblock/strava-ruby-client/pull/85): Lays groundwork to v3.0.0 of the gem (ruby3, newest rubocop, rubocop-rake and rubocop-rspec) - [@simonneutert](https://github.com/simonneutert).
 * Your contribution here.
 
 ### 2.1.0 (2024/3/20)

Gemfile

@@ -13,7 +13,7 @@ group :development, :test do
   gem 'pry'
   gem 'rake'
   gem 'rspec'
-  gem 'rubocop', '1.30.0' # Lock to specific version to avoid breaking cops/changes
+  gem 'rubocop', '1.66.1'
   gem 'rubocop-rake'
   gem 'rubocop-rspec'
   gem 'vcr'

RELEASING.md

@@ -52,6 +52,8 @@ Add the next release to [CHANGELOG.md](CHANGELOG.md).
 
 Increment the third version number in [lib/strava/version.rb](lib/strava/version.rb).
 
+Run `bundle install` to update the Gemfile.lock.
+
 Commit your changes.
 
 ```

UPGRADING.md

@@ -1,5 +1,9 @@
 # Upgrading Strava-Ruby-Client
 
+### Upgrading to >= 2.2.0
+
+Support for Ruby 2.x has been dropped. The minimum required Ruby version is now 3.0.0.
+
 ### Upgrading to >= 2.1.0
 
 The change in [#80](https://github.com/dblock/strava-ruby-client/pull/80) removes default values for Faraday's SSL settings `ca_file` and `ca_path`.

bin/strava-webhooks

@@ -5,7 +5,7 @@ require 'dotenv/load'
 require 'webrick'
 require 'strava-ruby-client'
 
-logger = ::Logger.new($stdout)
+logger = Logger.new($stdout)
 logger.level = Logger::INFO
 
 client = Strava::Webhooks::Client.new(

lib/strava/api/pagination.rb

@@ -48,8 +48,8 @@ def each
 
       private
 
-      def method_missing(method_symbol, *args, &block)
-        @collection.send(method_symbol, *args, &block)
+      def method_missing(method_symbol, ...)
+        @collection.send(method_symbol, ...)
       end
 
       def respond_to_missing?(method_name, include_private = false)