Drops supported endpoint/method to retrieve photos explicitly (#77)

* drops method for getting photos explicitly

* adds documentation for upgrading

* fix up changelog wording

* fixes wording

Author: simonneutert

CHANGELOG.md

@@ -1,5 +1,6 @@
 ### 2.0.0 (Next)
 
+* [#77](https://github.com/dblock/strava-ruby-client/pull/77): Drops unsupported endpoint/method `activity_photos` - [@simonneutert](https://github.com/simonneutert).
 * [#62](https://github.com/dblock/strava-ruby-client/pull/68): Drops `Activity#type` attribute as it is being deprecated by Strava, dropping `Activity#type_emoji` with it - [@simonneutert](https://github.com/simonneutert).
 * [#23](https://github.com/dblock/strava-ruby-client/pull/23): Failed uploads raise Strava::Errors::UploadError - [@ylecuyer](https://github.com/ylecuyer), [@simonneutert](https://github.com/simonneutert).
 * [#69](https://github.com/dblock/strava-ruby-client/pull/69): Raises `Strava::Api::RatelimitError`, when API ratelimit exceeded - [@simonneutert](https://github.com/simonneutert).

README.md

@@ -14,7 +14,6 @@ Unlike other clients, including [strava-api-v3](https://github.com/jaredholdcrof
   - [Activities](#activities)
     - [Create an Activity](#create-an-activity)
     - [Get Activity](#get-activity)
-    - [List Activity Photos](#list-activity-photos)
     - [List Activity Comments](#list-activity-comments)
     - [List Activity Kudoers](#list-activity-kudoers)
     - [List Activity Laps](#list-activity-laps)
@@ -150,29 +149,6 @@ google_image_url = "https://maps.googleapis.com/maps/api/staticmap?maptype=roadm
 
 See [Strava::Models::Map](lib/strava/models/map.rb) for all available properties.
 
-#### List Activity Photos
-
-Returns the photos on the given activity. This API is undocumented.
-
-```ruby
-photos = client.activity_photos(1982980795) # => Array[Strava::Models::Photo]
-
-photo = photos.first # => Strava::Models::Photo
-
-photo.id # => nil
-photo.unique_id # => '65889142-538D-4EE5-96F5-3DC3B773B1E3'
-photo.urls # => { '0' => 'https://dgtzuqphqg23d.cloudfront.net/eb4DMJ2hJW3k_g9URZEMfaJ8rZfHagrNlZRuEZz0osU-29x64.jpg' }
-photo.athlete_id # => 26_462_176
-photo.activity_id # => 1_946_417_534
-photo.activity_name # => 'TCS NYC Marathon 2018'
-photo.created_at # => Time
-photo.uploaded_at # => Time
-photo.sizes # => { '0' => [29, 64] }
-photo.default_photo # => false
-```
-
-See [Strava::Models::Photo](lib/strava/models/photo.rb) for all available properties.
-
 #### List Activity Comments
 
 Returns the comments on the given activity.

UPGRADING.md

@@ -5,6 +5,7 @@
 - Dropping `Activity` attribute `type` and `type_emoji` in favor of `sport_type` and `sport_type_emoji`. Creating or updating an `Activity` requires you to use `sport_type` instead of `type`, as refered in the [README](README.md#create-an-activity). For details visit the official [Strava docs: Create Activity](https://developers.strava.com/docs/reference/#api-Activities-createActivity) and the entry from June 15, 2022 in [Strava's V3 API Changelog](https://developers.strava.com/docs/changelog/).
 - Uploading a file using `create_upload` requires you to check its process, using `client.updload('your-unique-upload-id')`. A successful upload does just mean, that the file was accepted. The Processing of the file is an independent process on Strava's side. From now on, `client.updload('your-unique-upload-id')` will raise `Strava::Errors::UploadError`, if Strava failed processing the file, e.g. it being a duplicate.
 - Exceeded Ratelimits (HTTP Status: 429) do now raise a customized Error `Strava::Errors::RatelimitError`. You can use the `Strava::Api::Ratelimit` object coming with the error, for further inspection of your current ratelimits.
+- The method `Client#activity_photos` to retrieve an activity's photos has been removed. The Strava API offers no official support for this. See [#76](https://github.com/dblock/strava-ruby-client/issues/76) for details.
 
 ### Upgrading to >= 1.0.0
 

lib/strava/api/endpoints/activities.rb

@@ -37,21 +37,6 @@ def activity_comments(id_or_options, options = {}, &block)
           paginate "activities/#{id}/comments", options, Strava::Models::Comment, &block
         end
 
-        #
-        # List activity photos.
-        #
-        # @option options [String] :id
-        #   Activity id.
-        # @option options [Integer] :page
-        #   Page number.
-        # @option options [Integer] :per_page
-        #   Number of items per page. Defaults to 30.
-        #
-        def activity_photos(id_or_options, options = {}, &block)
-          id, options = parse_args(id_or_options, options)
-          paginate "activities/#{id}/photos", options, Strava::Models::Photo, &block
-        end
-
         #
         # List activity kudoers.
         #