Fixed strava_url methods.

Author: dblock

lib/strava/models/club_activity.rb

@@ -17,10 +17,6 @@ class ClubActivity < Strava::Models::Response
       property 'workout_type'
       # undocumented
       property 'resource_state'
-
-      def strava_url
-        "https://www.strava.com/activities/#{id}"
-      end
     end
   end
 end

lib/strava/models/club_athlete.rb

@@ -16,10 +16,6 @@ class ClubAthlete < Strava::Models::Response
       def name
         [firstname, lastname].compact.join(' ') if firstname || lastname
       end
-
-      def strava_url
-        "https://www.strava.com/athletes/#{username || id}"
-      end
     end
   end
 end

lib/strava/models/summary_athlete.rb

@@ -24,7 +24,7 @@ def name
       end
 
       def strava_url
-        "https://www.strava.com/athletes/#{username || id}"
+        "https://www.strava.com/athletes/#{id}"
       end
     end
   end

spec/strava/api/client/endpoints/activities/activity_spec.rb

@@ -27,6 +27,7 @@
     expect(activity.athlete.resource_state).to eq 1
     expect(activity.name).to eq 'TCS NYC Marathon 2018'
     expect(activity.description).to eq "Official time 3:42:02. Race got impossibly hard at mile 21 but I never stopped except to pee on mile 9. \r\n\r\nI am so fucking happy that I did this!"
+    expect(activity.strava_url).to eq 'https://www.strava.com/activities/1946417534'
 
     expect(activity.distance).to eq 42_268.1
     expect(activity.distance_in_miles).to eq 26.264129297

spec/strava/api/client/endpoints/activities/athlete_activities_spec.rb

@@ -10,7 +10,9 @@
       expect(athlete_activities).to be_a Enumerable
       expect(athlete_activities.count).to eq 30
       activity = athlete_activities.first
+      expect(activity).to be_a(Strava::Models::SummaryActivity)
       expect(activity.id).to eq 16_181_809_559
+      expect(activity.strava_url).to eq 'https://www.strava.com/activities/16181809559'
       expect(activity.athlete).to be_a Strava::Models::MetaAthlete
       expect(activity.map).to be_a Strava::Models::Map
       expect(activity.start_date).to be_a Time

spec/strava/api/client/endpoints/athletes/update_athlete_spec.rb

@@ -14,6 +14,7 @@
     club = clubs.first
     expect(club).to be_a Strava::Models::SummaryClub
     expect(club.name).to eq 'New York Road Runners'
+    expect(club.strava_url).to eq 'https://www.strava.com/clubs/nyrr'
     shoes = athlete.shoes
     expect(shoes).to be_a Enumerable
     shoe = shoes.first

spec/strava/api/client/endpoints/clubs/club_activities_spec.rb

@@ -10,6 +10,7 @@
       expect(club_activities).to be_a Enumerable
       expect(club_activities.count).to eq 30
       activity = club_activities.first
+      expect(activity).to be_a Strava::Models::ClubActivity
       expect(activity.distance).to eq 10_399.9
       expect(activity.name).to eq 'Run for The Nature Conservancy'
     end

spec/strava/api/client/endpoints/clubs/club_events_spec.rb

@@ -18,6 +18,7 @@
 
       it 'returns a club event' do
         expect(event).to be_a Strava::Models::ClubEvent
+        expect(event.title).to eq 'Gran Fondo Challenge Juni'
         expect(event.id).to be_a Integer
         expect(event.id).to eq(340_487)
         expect(event.created_at).to be_nil
@@ -38,6 +39,7 @@
         expect(event.upcoming_occurrences.first).to be_a Time
         expect(event.upcoming_occurrences.first).to eq(Time.new(2018, 6, 23, 8, 30, 0, '+00:00'))
         expect(event.joined).to be false
+        expect(event.strava_url).to eq 'https://www.strava.com/clubs/456773/group_events/340487'
       end
     end
   end

spec/strava/api/client/endpoints/routes/athlete_routes_spec.rb

@@ -12,6 +12,7 @@
     expect(route).to be_a Strava::Models::Route
     expect(route.id).to eq 3_329_485_690_369_457_990
     expect(route.athlete).to be_a Strava::Models::SummaryAthlete
+    expect(route.athlete.strava_url).to eq 'https://www.strava.com/athletes/26462176'
     expect(route.name).to eq 'Little Island'
     expect(route.description).to be_nil
     expect(route.elevation_gain).to eq 19.770000000000003