Fixed RSpec/DescribedClass.

Author: dblock

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2025-10-16 14:00:36 UTC using RuboCop version 1.68.0.
+# on 2025-10-16 14:15:33 UTC using RuboCop version 1.68.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -11,16 +11,6 @@ RSpec/AnyInstance:
   Exclude:
     - 'spec/strava/api/client_spec.rb'
 
-# Offense count: 13
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: SkipBlocks, EnforcedStyle, OnlyStaticConstants.
-# SupportedStyles: described_class, explicit
-RSpec/DescribedClass:
-  Exclude:
-    - 'spec/strava/models/athlete_spec.rb'
-    - 'spec/strava/oauth/client_spec.rb'
-    - 'spec/strava/webhooks/client_spec.rb'
-
 # Offense count: 5
 # Configuration parameters: AllowedGroups.
 RSpec/NestedGroups:

spec/strava/models/athlete_spec.rb

@@ -5,7 +5,7 @@
 RSpec.describe Strava::Models::Athlete do
   let(:fixtures) { 'spec/fixtures/strava/models' }
   let(:json) { JSON.parse(File.read("#{fixtures}/athlete.json")) }
-  let(:activity) { Strava::Models::Athlete.new(json) }
+  let(:activity) { described_class.new(json) }
 
   describe 'ride' do
     it 'exposes custom properties' do

spec/strava/oauth/client_spec.rb

@@ -8,8 +8,9 @@
   end
 
   it_behaves_like 'web client'
+
   context 'with defaults' do
-    let(:client) { Strava::OAuth::Client.new }
+    let(:client) { described_class.new }
 
     describe '#initialize' do
       it 'sets endpoint' do
@@ -32,8 +33,8 @@
   context 'with custom settings' do
     describe '#initialize' do
       Strava::OAuth::Config::ATTRIBUTES.each do |key|
-        context key do
-          let(:client) { Strava::OAuth::Client.new(key => 'custom') }
+        context key.to_s do
+          let(:client) { described_class.new(key => 'custom') }
 
           it "sets #{key}" do
             expect(client.send(key)).not_to eq Strava::OAuth::Config.send(key)
@@ -46,14 +47,14 @@
 
   context 'with global config' do
     after do
-      Strava::OAuth::Client.config.reset
+      described_class.config.reset
     end
 
-    let(:client) { Strava::OAuth::Client.new }
+    let(:client) { described_class.new }
 
     context 'with client id and secret' do
       before do
-        Strava::OAuth::Client.configure do |config|
+        described_class.configure do |config|
           config.client_id = 'custom client id'
           config.client_secret = 'custom client secret'
         end
@@ -69,7 +70,7 @@
   end
 
   context 'with a client id and secret' do
-    let(:client) { Strava::OAuth::Client.new(client_id: '12345', client_secret: 'client-secret') }
+    let(:client) { described_class.new(client_id: '12345', client_secret: 'client-secret') }
 
     describe '#authorize_url' do
       it 'returns url' do

spec/strava/webhooks/client_spec.rb

@@ -9,7 +9,7 @@
 
   it_behaves_like 'web client'
   context 'with defaults' do
-    let(:client) { Strava::Webhooks::Client.new }
+    let(:client) { described_class.new }
 
     describe '#initialize' do
       it 'sets endpoint' do
@@ -27,8 +27,8 @@
   context 'with custom settings' do
     describe '#initialize' do
       Strava::Webhooks::Config::ATTRIBUTES.each do |key|
-        context key do
-          let(:client) { Strava::Webhooks::Client.new(key => 'custom') }
+        context key.to_s do
+          let(:client) { described_class.new(key => 'custom') }
 
           it "sets #{key}" do
             expect(client.send(key)).not_to eq Strava::Webhooks::Config.send(key)
@@ -41,14 +41,14 @@
 
   context 'with global config' do
     after do
-      Strava::Webhooks::Client.config.reset
+      described_class.config.reset
     end
 
-    let(:client) { Strava::Webhooks::Client.new }
+    let(:client) { described_class.new }
 
     context 'with client id and secret' do
       before do
-        Strava::Webhooks::Client.configure do |config|
+        described_class.configure do |config|
           config.client_id = 'custom client id'
           config.client_secret = 'custom client secret'
         end
@@ -64,7 +64,7 @@
   end
 
   context 'with a client id and secret' do
-    let(:client) { Strava::Webhooks::Client.new(client_id: ENV.fetch('STRAVA_CLIENT_ID', '24523'), client_secret: ENV.fetch('STRAVA_CLIENT_SECRET', 'client-secret')) }
+    let(:client) { described_class.new(client_id: ENV.fetch('STRAVA_CLIENT_ID', '24523'), client_secret: ENV.fetch('STRAVA_CLIENT_SECRET', 'client-secret')) }
 
     describe '#push_subscriptions' do
       it 'gets an empty set of push subscriptions', vcr: { cassette_name: 'webhooks/no_push_subscriptions' } do