Skip to content

Commit 08afef3

Browse files
committed
fix minimum value for outer diamter fields to nonzero values so input validation now works correctly; update CAI2R link & minor comments; update to v1.0.1
1 parent ef57938 commit 08afef3

File tree

1 file changed

+15
-10
lines changed

1 file changed

+15
-10
lines changed

index.html

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,14 @@
159159

160160
<!-- Release Notes -->
161161

162+
<!-- v1.0.1 -->
163+
<!-- Updated 1 May 2024 - Doug Brantner -->
164+
<!-- Change initial O.D. for tube legs/ER's to valid nonzero value -->
165+
<!-- Cleaning & updating unit tests & documentation -->
166+
167+
162168
<!-- v1.0.0 -->
163-
<!-- Updated 4/29/2024 - Doug Brantner -->
169+
<!-- Updated 29 April 2024 - Doug Brantner -->
164170
<!-- for ISMRM 2024 -->
165171
<!-- Clean up unit tests -->
166172
<!-- Fix unit tests - ALL TESTS PASSING -->
@@ -202,7 +208,6 @@ <h1 class="header-h1">Open BirdcageBuilder</h1>
202208

203209
<label for="num_legs">Number of Legs:</label>
204210
<select name="num_legs" id="num_legs" onChange="mark_results_stale()" required >
205-
<!-- NOTE: User can edit this list/add custom values if needed (must be multiples of 4) -->
206211
<option value="4">4</option>
207212
<option selected="selected" value="8">8</option>
208213
<option value="12">12</option>
@@ -235,10 +240,11 @@ <h1 class="header-h1">Open BirdcageBuilder</h1>
235240
<option value="120">120</option>
236241
<option value="124">124</option>
237242
<option value="128">128</option>
243+
<!-- NOTE: User can edit this list to add custom values if needed (must be multiples of 4) -->
238244
</select>
239245
<br>
240246

241-
<!-- NOTE: for input validation, using "a very small number" for inputs that have to be positive and nonzero, to take advantage of builtin validation without javascript -->
247+
<!-- NOTE: for input validation minimum values, using "a very small number" for inputs that have to be positive and nonzero, to take advantage of builtin validation without javascript -->
242248

243249
<input type="number" id="center_freq" step="any" value="128" min="0.000001" onChange="mark_results_stale()" required > Frequency (MHz)</input><br>
244250
<input type="number" id="coil_radius" step="any" value="10" min="0.000001" onChange="mark_results_stale()" required > Coil Radius (cm)</input><br>
@@ -285,10 +291,9 @@ <h1 class="header-h1">Open BirdcageBuilder</h1>
285291
<label for="leg_tube">Tubular</label>
286292
<br>
287293

288-
<!-- javascript validation that OD > ID and nonzero (ID can be zero if it's solid though) -->
294+
<!-- Note javascript validation that OD > ID and nonzero (ID can be zero if it's solid though) -->
289295
<input type="number" id="leg_ID" step="any" value="0" min="0" disabled="disabled" onChange="validate_tube_outer_diam('leg_ID', 'leg_OD')" required > Leg Inner Diam. (cm)</input><br>
290-
<!-- <input type="number" id="leg_OD" step="any" value="0" disabled="disabled" onChange="mark_results_stale()" required > Leg Outer Diam. (cm)</input><br> -->
291-
<input type="number" id="leg_OD" step="any" value="0" disabled="disabled" onChange="validate_tube_outer_diam('leg_ID', 'leg_OD')" required > Leg Outer Diam. (cm)</input><br>
296+
<input type="number" id="leg_OD" step="any" value="0.25" disabled="disabled" onChange="validate_tube_outer_diam('leg_ID', 'leg_OD')" required > Leg Outer Diam. (cm)</input><br>
292297

293298
<br>
294299

@@ -308,9 +313,9 @@ <h1 class="header-h1">Open BirdcageBuilder</h1>
308313
<label for="er_tube">Tubular</label>
309314
<br>
310315

311-
<!-- TODO- javascript validation that OD > ID and nonzero (ID can be zero if it's solid though?) -->
316+
<!-- Note - javascript validation that OD > ID and nonzero (ID can be zero if it's solid though?) -->
312317
<input type="number" id="er_ID" step="any" value="0" min="0" disabled="disabled" onChange="validate_tube_outer_diam('er_ID', 'er_OD')" required > ER Inner Diam. (cm)</input><br>
313-
<input type="number" id="er_OD" step="any" value="0" disabled="disabled" onChange="validate_tube_outer_diam('er_ID', 'er_OD')" required > ER Outer Diam. (cm)</input><br>
318+
<input type="number" id="er_OD" step="any" value="0.25" disabled="disabled" onChange="validate_tube_outer_diam('er_ID', 'er_OD')" required > ER Outer Diam. (cm)</input><br>
314319

315320
</fieldset>
316321
<br>
@@ -320,7 +325,7 @@ <h1 class="header-h1">Open BirdcageBuilder</h1>
320325

321326

322327

323-
<!-- needed to revert back to a 'submit' button for input validation to work -->
328+
<!-- reverted back to a 'submit' button for so that validation would work -->
324329
<!-- <button type="button" onclick="calculate(); return false">Calculate!</button> -->
325330
<button type="submit" onclick="calculate(); return false">Calculate!</button>
326331
<!-- 'return false' is necessary to avoid automatic page refresh (for type="submit") -->
@@ -393,7 +398,7 @@ <h1 class="header-h1">Open BirdcageBuilder</h1>
393398
</p>
394399

395400
<br>
396-
<a href="https://cai2r.net">NYU CAI<sup>2</sup>R</a><br>
401+
<a href="https://cai2r.net/resources/open-birdcagebuilder">NYU CAI<sup>2</sup>R</a><br>
397402

398403
<img src="img/NYUL-Health_logo_White_RGB_72ppi_25pct.png"><br>
399404
<img src="img/CAI2R_PURPLE_INVERT_RGB_288x94.png"><br>

0 commit comments

Comments
 (0)