WorkflowStatusMaxRecoveryAttemptsExceeded

Author: maxdml

dbos/admin_server_test.go

@@ -455,7 +455,6 @@ func TestAdminServer(t *testing.T) {
 			"start_time": timeBetween.Format(time.RFC3339Nano),
 			"limit":      10,
 		}
-		fmt.Println("Request body 2:", reqBody2, "timebetween", timeBetween.UnixMilli())
 		req2, err := http.NewRequest(http.MethodPost, endpoint, bytes.NewBuffer(mustMarshal(reqBody2)))
 		require.NoError(t, err, "Failed to create request 2")
 		req2.Header.Set("Content-Type", "application/json")
@@ -469,7 +468,6 @@ func TestAdminServer(t *testing.T) {
 		var workflows2 []map[string]any
 		err = json.NewDecoder(resp2.Body).Decode(&workflows2)
 		require.NoError(t, err, "Failed to decode workflows response 2")
-		fmt.Println(workflows2)
 
 		// Should have exactly 1 workflow (the second one)
 		assert.Equal(t, 1, len(workflows2), "Expected exactly 1 workflow with start_time after timeBetween")

dbos/queues_test.go

@@ -233,13 +233,13 @@ func TestWorkflowQueues(t *testing.T) {
 		for {
 			dlqStatus, err := dlqHandle[0].GetStatus()
 			require.NoError(t, err, "failed to get status of DLQ workflow handle")
-			if dlqStatus.Status != WorkflowStatusRetriesExceeded && retries < 10 {
+			if dlqStatus.Status != WorkflowStatusMaxRecoveryAttemptsExceeded && retries < 10 {
 				time.Sleep(1 * time.Second) // Wait a bit before checking again
 				retries++
 				continue
 			}
 			require.NoError(t, err, "failed to get status of DLQ workflow handle")
-			assert.Equal(t, WorkflowStatusRetriesExceeded, dlqStatus.Status, "expected workflow to be in DLQ after max retries exceeded")
+			assert.Equal(t, WorkflowStatusMaxRecoveryAttemptsExceeded, dlqStatus.Status, "expected workflow to be in DLQ after max retries exceeded")
 			handles = append(handles, dlqHandle[0])
 			break
 		}

dbos/system_database.go

@@ -431,17 +431,17 @@ func (s *sysDB) insertWorkflowStatus(ctx context.Context, input insertWorkflowSt
 					 WHERE workflow_uuid = $2 AND status = $3`
 
 		_, err = input.tx.Exec(ctx, dlqQuery,
-			WorkflowStatusRetriesExceeded,
+			WorkflowStatusMaxRecoveryAttemptsExceeded,
 			input.status.ID,
 			WorkflowStatusPending)
 
 		if err != nil {
-			return nil, fmt.Errorf("failed to update workflow to %s: %w", WorkflowStatusRetriesExceeded, err)
+			return nil, fmt.Errorf("failed to update workflow to %s: %w", WorkflowStatusMaxRecoveryAttemptsExceeded, err)
 		}
 
 		// Commit the transaction before throwing the error
 		if err := input.tx.Commit(ctx); err != nil {
-			return nil, fmt.Errorf("failed to commit transaction after marking workflow as %s: %w", WorkflowStatusRetriesExceeded, err)
+			return nil, fmt.Errorf("failed to commit transaction after marking workflow as %s: %w", WorkflowStatusMaxRecoveryAttemptsExceeded, err)
 		}
 
 		return nil, newDeadLetterQueueError(input.status.ID, input.maxRetries)

dbos/workflow.go

@@ -22,12 +22,12 @@ import (
 type WorkflowStatusType string
 
 const (
-	WorkflowStatusPending         WorkflowStatusType = "PENDING"                        // Workflow is running or ready to run
-	WorkflowStatusEnqueued        WorkflowStatusType = "ENQUEUED"                       // Workflow is queued and waiting for execution
-	WorkflowStatusSuccess         WorkflowStatusType = "SUCCESS"                        // Workflow completed successfully
-	WorkflowStatusError           WorkflowStatusType = "ERROR"                          // Workflow completed with an error
-	WorkflowStatusCancelled       WorkflowStatusType = "CANCELLED"                      // Workflow was cancelled (manually or due to timeout)
-	WorkflowStatusRetriesExceeded WorkflowStatusType = "MAX_RECOVERY_ATTEMPTS_EXCEEDED" // Workflow exceeded maximum retry attempts
+	WorkflowStatusPending                     WorkflowStatusType = "PENDING"                        // Workflow is running or ready to run
+	WorkflowStatusEnqueued                    WorkflowStatusType = "ENQUEUED"                       // Workflow is queued and waiting for execution
+	WorkflowStatusSuccess                     WorkflowStatusType = "SUCCESS"                        // Workflow completed successfully
+	WorkflowStatusError                       WorkflowStatusType = "ERROR"                          // Workflow completed with an error
+	WorkflowStatusCancelled                   WorkflowStatusType = "CANCELLED"                      // Workflow was cancelled (manually or due to timeout)
+	WorkflowStatusMaxRecoveryAttemptsExceeded WorkflowStatusType = "MAX_RECOVERY_ATTEMPTS_EXCEEDED" // Workflow exceeded maximum retry attempts
 )
 
 // WorkflowStatus contains comprehensive information about a workflow's current state and execution history.

dbos/workflows_test.go

@@ -1216,7 +1216,7 @@ func TestWorkflowDeadLetterQueue(t *testing.T) {
 		// Verify workflow status is MAX_RECOVERY_ATTEMPTS_EXCEEDED
 		status, err := handle.GetStatus()
 		require.NoError(t, err, "failed to get workflow status")
-		require.Equal(t, WorkflowStatusRetriesExceeded, status.Status)
+		require.Equal(t, WorkflowStatusMaxRecoveryAttemptsExceeded, status.Status)
 
 		// Verify that attempting to start a workflow with the same ID throws a DLQ error
 		_, err = RunAsWorkflow(dbosCtx, deadLetterQueueWorkflow, "test", WithWorkflowID(wfID))