404 test

Author: maxdml

dbos/admin_server.go

@@ -37,7 +37,7 @@ type listWorkflowsRequest struct {
 	AuthenticatedUser  *string    `json:"authenticated_user"`  // Filter by user who initiated the workflow
 	StartTime          *time.Time `json:"start_time"`          // Filter workflows created after this time (RFC3339 format)
 	EndTime            *time.Time `json:"end_time"`            // Filter workflows created before this time (RFC3339 format)
-	Status             string     `json:"status"`              // Filter by workflow status(es)
+	Status             string     `json:"status"`              // Filter by workflow status
 	ApplicationVersion *string    `json:"application_version"` // Filter by application version
 	WorkflowName       *string    `json:"workflow_name"`       // Filter by workflow function name
 	Limit              *int       `json:"limit"`               // Maximum number of results to return

dbos/admin_server_test.go

@@ -170,11 +170,17 @@ func TestAdminServer(t *testing.T) {
 					var workflows []map[string]any
 					err := json.NewDecoder(resp.Body).Decode(&workflows)
 					require.NoError(t, err, "Failed to decode workflows response")
-					// We expect an empty array since these filters likely won't match any workflows
+					// We expect an empty array -- there's no workflow in the db
 					assert.NotNil(t, workflows, "Expected non-nil workflows array")
-					// No error is success - the result can be empty
+					assert.Empty(t, workflows, "Expected empty workflows array")
 				},
 			},
+			{
+				name:           "Get single workflow returns 404 for non-existent workflow",
+				method:         "GET",
+				endpoint:       "http://localhost:3001/workflow/non-existent-workflow-id",
+				expectedStatus: http.StatusNotFound,
+			},
 		}
 
 		for _, tt := range tests {