hash the executable for standalone versioning

Author: maxdml

dbos/dbos.go

@@ -6,12 +6,10 @@ import (
 	"encoding/gob"
 	"encoding/hex"
 	"fmt"
+	"io"
 	"log/slog"
 	"net/url"
 	"os"
-	"reflect"
-	"runtime"
-	"sort"
 	"time"
 
 	"github.com/robfig/cron/v3"
@@ -24,36 +22,6 @@ var (
 	_DEFAULT_ADMIN_SERVER_PORT = 3001
 )
 
-func computeApplicationVersion() string {
-	if len(registry) == 0 {
-		fmt.Println("DBOS: No registered workflows found, cannot compute application version")
-		return ""
-	}
-
-	// Collect all function names and sort them for consistent hashing
-	var functionNames []string
-	for fqn := range registry {
-		functionNames = append(functionNames, fqn)
-	}
-	sort.Strings(functionNames)
-
-	hasher := sha256.New()
-
-	for _, fqn := range functionNames {
-		workflowEntry := registry[fqn]
-
-		// Try to get function source location and other identifying info
-		if pc := runtime.FuncForPC(reflect.ValueOf(workflowEntry.wrappedFunction).Pointer()); pc != nil {
-			// Get the function's entry point - this reflects the actual compiled code
-			entry := pc.Entry()
-			fmt.Fprintf(hasher, "%x", entry)
-		}
-	}
-
-	return hex.EncodeToString(hasher.Sum(nil))
-
-}
-
 var workflowScheduler *cron.Cron // Global because accessed during workflow registration before the dbos singleton is initialized
 
 var logger *slog.Logger // Global because accessed everywhere inside the library
@@ -278,3 +246,32 @@ func Shutdown() {
 	}
 	dbos = nil
 }
+
+func GetBinaryHash() (string, error) {
+	execPath, err := os.Executable()
+	if err != nil {
+		return "", err
+	}
+
+	file, err := os.Open(execPath)
+	if err != nil {
+		return "", err
+	}
+	defer file.Close()
+
+	hasher := sha256.New()
+	if _, err := io.Copy(hasher, file); err != nil {
+		return "", err
+	}
+
+	return hex.EncodeToString(hasher.Sum(nil)), nil
+}
+
+func computeApplicationVersion() string {
+	hash, err := GetBinaryHash()
+	if err != nil {
+		fmt.Printf("DBOS: Failed to compute binary hash: %v\n", err)
+		return ""
+	}
+	return hash
+}

dbos/dbos_test.go

@@ -1,9 +1,6 @@
 package dbos
 
 import (
-	"context"
-	"encoding/hex"
-	"maps"
 	"testing"
 )
 
@@ -60,28 +57,3 @@ func TestConfigValidationErrorTypes(t *testing.T) {
 		}
 	})
 }
-func TestAppVersion(t *testing.T) {
-	if _, err := hex.DecodeString(_APP_VERSION); err != nil {
-		t.Fatalf("APP_VERSION is not a valid hex string: %v", err)
-	}
-
-	// Save the original registry content
-	originalRegistry := make(map[string]workflowRegistryEntry)
-	maps.Copy(originalRegistry, registry)
-
-	// Restore the registry after the test
-	defer func() {
-		registry = originalRegistry
-	}()
-
-	// Replace the registry and verify the hash is different
-	registry = make(map[string]workflowRegistryEntry)
-
-	WithWorkflow(func(ctx context.Context, input string) (string, error) {
-		return "new-registry-workflow-" + input, nil
-	})
-	hash2 := computeApplicationVersion()
-	if _APP_VERSION == hash2 {
-		t.Fatalf("APP_VERSION hash did not change after replacing registry")
-	}
-}