call pingcancel on shutdown. Shouldn't need it?

Author: maxdml

dbos/conductor.go

@@ -5,7 +5,6 @@ import (
 	"encoding/json"
 	"fmt"
 	"log/slog"
-	"math"
 	"net"
 	"net/url"
 	"os"
@@ -118,6 +117,10 @@ func (c *Conductor) Shutdown(timeout time.Duration) {
 	c.stopOnce.Do(func() {
 		c.logger.Info("Shutting down conductor")
 
+		if c.pingCancel != nil {
+			c.pingCancel()
+		}
+
 		done := make(chan struct{})
 		go func() {
 			c.wg.Wait()
@@ -876,13 +879,9 @@ func (c *Conductor) handleForkWorkflowRequest(data []byte, requestID string) err
 	if req.Body.StartStep < 0 {
 		return fmt.Errorf("invalid StartStep: cannot be negative")
 	}
-	// Additional validation to prevent integer overflow when converting to uint
-	if req.Body.StartStep > math.MaxInt {
-		return fmt.Errorf("invalid StartStep: value too large")
-	}
 	input := ForkWorkflowInput{
 		OriginalWorkflowID: req.Body.WorkflowID,
-		StartStep:          uint(req.Body.StartStep),
+		StartStep:          uint(req.Body.StartStep), // #nosec G115 -- validated above
 	}
 
 	// Set optional fields